DaanHoogland edited a comment on pull request #4399:
URL: https://github.com/apache/cloudstack/pull/4399#issuecomment-744527004
not sure yet, but the build failures are about certificates and i don't
think related, but as a matter of good accounting:
```
[INFO] Running
org.apache.cloudstack.direct.download.DirectDownloadManagerImplTest
java.security.cert.CertificateException: Could not parse certificate:
java.io.IOException: java.lang.IllegalArgumentException: Input byte array has
incorrect ending byte at 1132
at
java.base/sun.security.provider.X509Factory.engineGenerateCertificate(X509Factory.java:115)
at
java.base/java.security.cert.CertificateFactory.generateCertificate(CertificateFactory.java:355)
at
com.cloud.utils.security.CertificateHelper.buildCertificate(CertificateHelper.java:130)
at
org.apache.cloudstack.direct.download.DirectDownloadManagerImpl.getCertificateFromString(DirectDownloadManagerImpl.java:378)
at
org.apache.cloudstack.direct.download.DirectDownloadManagerImpl.certificateSanity(DirectDownloadManagerImpl.java:389)
at
org.apache.cloudstack.direct.download.DirectDownloadManagerImpl$MockitoMock$369926905.certificateSanity$accessor$rf85lrMB(Unknown
Source)
at
org.apache.cloudstack.direct.download.DirectDownloadManagerImpl$MockitoMock$369926905$auxiliary$xgeKzGvM.call(Unknown
Source)
at
org.mockito.internal.invocation.RealMethod$FromCallable$1.call(RealMethod.java:40)
at
org.mockito.internal.invocation.RealMethod$FromBehavior.invoke(RealMethod.java:62)
at
org.mockito.internal.invocation.InterceptedInvocation.callRealMethod(InterceptedInvocation.java:152)
at
org.mockito.internal.stubbing.answers.CallsRealMethods.answer(CallsRealMethods.java:44)
at org.mockito.Answers.answer(Answers.java:100)
at
org.mockito.internal.handler.MockHandlerImpl.handle(MockHandlerImpl.java:103)
at
org.mockito.internal.handler.NullResultGuardian.handle(NullResultGuardian.java:29)
at
org.mockito.internal.handler.InvocationNotifierHandler.handle(InvocationNotifierHandler.java:35)
at
org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:61)
at
org.mockito.internal.creation.bytebuddy.MockMethodInterceptor.doIntercept(MockMethodInterceptor.java:49)
at
org.mockito.internal.creation.bytebuddy.MockMethodInterceptor$DispatcherDefaultingToRealMethod.interceptSuperCallable(MockMethodInterceptor.java:108)
at
org.apache.cloudstack.direct.download.DirectDownloadManagerImpl$MockitoMock$369926905.certificateSanity(Unknown
Source)
at
org.apache.cloudstack.direct.download.DirectDownloadManagerImplTest.testCertificateSanityInvalidCertificate(DirectDownloadManagerImplTest.java:137)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.mockito.internal.runners.DefaultInternalRunner$1$1.evaluate(DefaultInternalRunner.java:46)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at
org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:77)
at
org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:83)
at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:39)
at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:163)
at
org.mockito.runners.MockitoJUnitRunner.run(MockitoJUnitRunner.java:54)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: java.io.IOException: java.lang.IllegalArgumentException: Input
byte array has incorrect ending byte at 1132
at
java.base/sun.security.provider.X509Factory.readOneBlock(X509Factory.java:648)
at
java.base/sun.security.provider.X509Factory.engineGenerateCertificate(X509Factory.java:99)
... 55 more
Caused by: java.lang.IllegalArgumentException: Input byte array has
incorrect ending byte at 1132
at java.base/java.util.Base64$Decoder.decode0(Base64.java:771)
at java.base/java.util.Base64$Decoder.decode(Base64.java:535)
at
java.base/sun.security.provider.X509Factory.readOneBlock(X509Factory.java:646)
... 56 more
```
and in the build summary
```
[ERROR]
importUnmanagedInstanceTest(org.apache.cloudstack.vm.UnmanagedVMsManagerImplTest)
Time elapsed: 0.05 s <<< ERROR!
java.lang.NullPointerException
at
org.apache.cloudstack.vm.UnmanagedVMsManagerImplTest.importUnmanagedInstanceTest(UnmanagedVMsManagerImplTest.java:372)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]