DaanHoogland commented on a change in pull request #4205:
URL: https://github.com/apache/cloudstack/pull/4205#discussion_r544336823
##########
File path:
plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenGuestNetworkGuru.java
##########
@@ -104,11 +104,11 @@ public boolean isMyTrafficType(Networks.TrafficType type)
{
}
@Override
- protected boolean canHandle(NetworkOffering offering,
DataCenter.NetworkType networkType,
+ public boolean canHandle(NetworkOffering offering, DataCenter.NetworkType
networkType,
PhysicalNetwork physicalNetwork) {
if (networkType == DataCenter.NetworkType.Advanced &&
isMyTrafficType(offering.getTrafficType())
&& offering.getGuestType() == Network.GuestType.Isolated &&
isMyIsolationMethod(physicalNetwork)
- &&
ntwkOfferingSrvcDao.isProviderForNetworkOffering(offering.getId(),
Network.Provider.Tungsten)) {
+ &&
_ntwkOfferingSrvcDao.isProviderForNetworkOffering(offering.getId(),
Network.Provider.Tungsten)) {
Review comment:
please use member names without _
##########
File path:
plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenGuestNetworkGuru.java
##########
@@ -71,7 +71,7 @@
private static final Logger s_logger =
Logger.getLogger(TungstenGuestNetworkGuru.class);
@Inject
- NetworkOfferingServiceMapDao ntwkOfferingSrvcDao;
+ public NetworkOfferingServiceMapDao _ntwkOfferingSrvcDao;
Review comment:
why make this public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
