weizhouapache commented on pull request #4551:
URL: https://github.com/apache/cloudstack/pull/4551#issuecomment-748082949


   > @weizhouapache Post migration the volume is pretty much non-existent hence 
is marked as expunged and is removed from the secondary store entirely. But the 
only problem is it doesn't clean up the volume_store_ref table in case it was 
previously downloaded (and url hasn't expired) or there are some entries due to 
some failed migration, etc. So now we just ensure that the db is up to date
   
   @Pearl1594 thanks !
   in storage migration , volume will be moved between primary pools. it should 
not impact the snapshots/volumes on secondary storage I think.
   
   I have quick reviewed the process in AncientDataMotionStrategy.java, it 
copies the volume by the steps
   (1) copy volume to image store
   ```
                   answer = copyObject(srcData, objOnImageStore);
   ```
   (2) copy from image store to another pool
   ```
                   CopyCommand cmd = new CopyCommand(objOnImageStore.getTO(), 
addFullCloneFlagOnVMwareDest(destData.getTO()), _copyvolumewait, 
VirtualMachineManager.ExecuteInSequence.value());
   ```
   (3) remove volume from image store
   ```
               imageStore.delete(objOnImageStore);
   ```
   
   step (3) will remove not only the volume created in step(1), but also the 
volume snapshots created when download the volume in the past. I think it is a 
bug.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to