sureshanaparti commented on a change in pull request #4557:
URL: https://github.com/apache/cloudstack/pull/4557#discussion_r553166011
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -1073,6 +1073,10 @@ public static VMwareDVSPvlanConfigSpec
createDVPortPvlanConfigSpec(int vlanId, i
}
public static VmwareDistributedVirtualSwitchVlanSpec
createDVPortVlanSpec(Integer vlanId, String vlanRange) {
+ if (vlanId != null && vlanId == 4095){
Review comment:
@Spaceman1984 Have you tested this?
this method `createDVPortVlanSpec()` is called only when `vlanId` is null,
so if check here is always 'false' and the underlying code never executes.
Please check and try to fix this in the appropriate top level method in the
call stack.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
