GutoVeronezi opened a new pull request #4585:
URL: https://github.com/apache/cloudstack/pull/4585


   ### Description
   On KVMHAMonitor, the heartbeat timeout is hardcoded to `60000` ms; 
therefore, operators do not have options to choose which timeout they 
want/need. 
   
   This PR intends to externalize the heartbeat timeout configuration on 
KVMHAMonitor.
   
   Depending on the use case, this timeout might need increasing/decreasing. 
Therefore, it is interesting to externalize such configurations for cloud 
operators. The hardcoded value is taken as the default one. Therefore, the 
current behavior is maintained.
   
   ### Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functioanlity)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   - [x] Major
   - [ ] Minor
   
   ### How Has This Been Tested?
   It has been tested locally on a test lab.
   1. I changed my log4j to debug mode.
   2. I added and changed `hearbeat.update.timeout` setting to 
`agent.properties` file several times.
   3. I restarted agent and watched the log.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to