DK101010 commented on pull request #4591: URL: https://github.com/apache/cloudstack/pull/4591#issuecomment-762830326
> @rhtyd done > > @DK101010 I'm also deliberating of a way to select correct root disk without adding new param in API. For API, we already need to pass a diskid-diskoffering map for all data disks so with that info we can simply select the remaining disk as the root disk (will have to refactor some error messages and change the logic). Does that make sense? @shwstppr I'm not quite sure if I understand you right. The VCenter give you a list that enables you to find the right root disk? The diskoffering-map in CS will be created based on the collection sort algo. in my last PR and is wrong in case of that the HardDisk1 not the root disk is. (When I remind me right) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
