DaanHoogland commented on a change in pull request #4601:
URL: https://github.com/apache/cloudstack/pull/4601#discussion_r561831461
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -793,10 +792,10 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
}
}
}
- }
- });
- } catch (Exception e) {
- s_logger.warn("Error while collecting vm disk stats from
hosts", e);
+ });
+ } catch (Exception e) {
+ s_logger.warn("Error while collecting vm disk stats from
hosts", e);
Review comment:
we could add host details in this message
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -684,18 +684,17 @@ protected void runInContext() {
return;
}
// collect the vm disk statistics(total) from hypervisor. added by
weizhou, 2013.03.
- s_logger.trace("Running VM disk stats ...");
- try {
- Transaction.execute(new TransactionCallbackNoReturn() {
- @Override
- public void doInTransactionWithoutResult(TransactionStatus
status) {
- s_logger.debug("VmDiskStatsTask is running...");
+ s_logger.debug("VmDiskStatsTask is running...");
Review comment:
why, this change in message and level?
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -912,10 +911,10 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
}
}
}
- }
- });
- } catch (Exception e) {
- s_logger.warn("Error while collecting vm network stats from
hosts", e);
+ });
+ } catch (Exception e) {
+ s_logger.warn("Error while collecting vm network stats
from hosts", e);
Review comment:
again, we can now add host details to the message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
