rhtyd commented on a change in pull request #4576:
URL: https://github.com/apache/cloudstack/pull/4576#discussion_r564346096
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2247,8 +2247,8 @@ public LibvirtVMDef createVMFromSpec(final
VirtualMachineTO vmTO) {
if (MapUtils.isNotEmpty(customParams) &&
customParams.containsKey(GuestDef.BootType.UEFI.toString())) {
guest.setBootType(GuestDef.BootType.UEFI);
guest.setBootMode(GuestDef.BootMode.LEGACY);
+ guest.setMachineType("q35");
Review comment:
I personally run a toy PI4 env for fun, so I would prefer a suitable
if-else be added based on platform, arch parameters (I'm not sure if the
hard-coded chipset works on RPi4)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
