svn commit: r612289 - /commons/proper/scxml/branches/J5/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java

[rahul]

Author: rahul
Date: Tue Jan 15 15:03:29 2008
New Revision: 612289

URL: http://svn.apache.org/viewvc?rev=612289&view=rev
Log:
Type safety improvements + Using for-each to reduce clutter.

Modified:
    
commons/proper/scxml/branches/J5/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java

Modified: 
commons/proper/scxml/branches/J5/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java
URL: 
http://svn.apache.org/viewvc/commons/proper/scxml/branches/J5/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java?rev=612289&r1=612288&r2=612289&view=diff
==============================================================================
--- 
commons/proper/scxml/branches/J5/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java
 (original)
+++ 
commons/proper/scxml/branches/J5/src/main/java/org/apache/commons/scxml/io/SCXMLParser.java
 Tue Jan 15 15:03:29 2008
@@ -21,6 +21,7 @@
 import java.text.MessageFormat;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
 import javax.xml.parsers.DocumentBuilder;
 import javax.xml.parsers.DocumentBuilderFactory;
@@ -1057,8 +1058,7 @@
         if (customActions == null || customActions.size() == 0) {
             return;
         }
-        for (int i = 0; i < customActions.size(); i++) {
-            CustomAction ca = customActions.get(i);
+        for (CustomAction ca : customActions) {
             if (ca == null) {
                 org.apache.commons.logging.Log log = LogFactory.
                     getLog(SCXMLParser.class);
@@ -1481,10 +1481,10 @@
             Initial ini = new Initial();
             ini.setTransition(t);
             s.setInitial(ini);
-            Map children = externalSCXML.getChildren();
-            Object[] ids = children.keySet().toArray();
-            for (int i = 0; i < ids.length; i++) {
-                s.addChild((TransitionTarget) children.get(ids[i]));
+            Map<String, TransitionTarget> children = 
externalSCXML.getChildren();
+            Set<String> ids = children.keySet();
+            for (String id : ids) {
+                s.addChild(children.get(id));
             }
             s.setDatamodel(externalSCXML.getDatamodel());
         }