Author: luc
Date: Tue Dec 2 06:41:47 2008
New Revision: 722476
URL: http://svn.apache.org/viewvc?rev=722476&view=rev
Log:
don't compute the expensive Q matrix until really needed
Modified:
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/EigenDecompositionImpl.java
Modified:
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/EigenDecompositionImpl.java
URL:
http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/EigenDecompositionImpl.java?rev=722476&r1=722475&r2=722476&view=diff
==============================================================================
---
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/EigenDecompositionImpl.java
(original)
+++
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/EigenDecompositionImpl.java
Tue Dec 2 06:41:47 2008
@@ -76,8 +76,8 @@
/** Squared secondary diagonal of the tridiagonal matrix. */
private double[] squaredSecondary;
- /** Orthogonal matrix of tridiagonal transformation. */
- private RealMatrix orthoTridiag;
+ /** Transformer to tridiagonal (may be null if matrix is already
tridiagonal). */
+ private TriDiagonalTransformer transformer;
/** Lower bound of spectra. */
private double lowerSpectra;
@@ -232,7 +232,7 @@
this.main = main;
this.secondary = secondary;
- orthoTridiag = null;
+ transformer = null;
// pre-compute some elements
squaredSecondary = new double[secondary.length];
@@ -518,7 +518,7 @@
private void transformToTridiagonal(final RealMatrix matrix) {
// transform the matrix to tridiagonal
- TriDiagonalTransformer transformer = new
TriDiagonalTransformer(matrix);
+ transformer = new TriDiagonalTransformer(matrix);
main = transformer.getMainDiagonalRef();
secondary = transformer.getSecondaryDiagonalRef();
@@ -529,8 +529,6 @@
squaredSecondary[i] = s * s;
}
- orthoTridiag = transformer.getQ();
-
}
/**
@@ -1754,9 +1752,9 @@
eigenvector[i] *= inv;
}
- return (orthoTridiag == null) ?
+ return (transformer == null) ?
new RealVectorImpl(eigenvector, false) :
- new RealVectorImpl(orthoTridiag.operate(eigenvector), false);
+ new RealVectorImpl(transformer.getQ().operate(eigenvector),
false);
}