Author: dfabulich
Date: Sat Nov 7 20:36:42 2009
New Revision: 833759
URL: http://svn.apache.org/viewvc?rev=833759&view=rev
Log:
Fixing more FindBugs errors
Modified:
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java
Modified:
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
URL:
http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java?rev=833759&r1=833758&r2=833759&view=diff
==============================================================================
---
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
(original)
+++
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/BasicRowProcessor.java
Sat Nov 7 20:36:42 2009
@@ -212,7 +212,7 @@
* (That's why we call super.remove(oldKey) and not just
* super.put(key, value))
*/
- Object oldKey = lowerCaseMap.put(key.toString().toLowerCase(),
key);
+ Object oldKey = lowerCaseMap.put(key.toLowerCase(), key);
Object oldValue = super.remove(oldKey);
super.put(key, value);
return oldValue;
Modified:
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java
URL:
http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java?rev=833759&r1=833758&r2=833759&view=diff
==============================================================================
---
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java
(original)
+++
commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryLoader.java
Sat Nov 7 20:36:42 2009
@@ -93,6 +93,7 @@
*/
@SuppressWarnings("unchecked")
protected Map<String,String> loadQueries(String path) throws IOException {
+ // Findbugs flags getClass().getResource as a bad practice; maybe we
should change the API?
InputStream in = getClass().getResourceAsStream(path);
if (in == null) {
