[commons-fileupload] branch 1.x updated: Clean up some IDE warnings

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 1.x
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git


The following commit(s) were added to refs/heads/1.x by this push:
     new 21e0121a Clean up some IDE warnings
21e0121a is described below

commit 21e0121abe0aeb58c9df349f7787ad4ae357dc4b
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Sat Sep 16 09:40:55 2023 +0100

    Clean up some IDE warnings
---
 src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java  | 2 +-
 .../java/org/apache/commons/fileupload/MockHttpServletRequest.java    | 4 ----
 src/test/java/org/apache/commons/fileupload/MultipartStreamTest.java  | 3 ++-
 src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java | 4 ++--
 4 files changed, 5 insertions(+), 8 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java 
b/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java
index 7b423100..d6f334a9 100644
--- a/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java
+++ b/src/test/java/org/apache/commons/fileupload/DefaultFileItemTest.java
@@ -34,7 +34,7 @@ import org.junit.Test;
 /**
  * Unit tests for {@link org.apache.commons.fileupload.DefaultFileItem}.
  */
-@SuppressWarnings({"deprecation", "javadoc"}) // unit tests for deprecated 
class
+@SuppressWarnings({"deprecation"}) // unit tests for deprecated class
 public class DefaultFileItemTest {
 
     /**
diff --git 
a/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java 
b/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java
index 71bab95f..e02ce703 100644
--- a/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java
+++ b/src/test/java/org/apache/commons/fileupload/MockHttpServletRequest.java
@@ -416,7 +416,6 @@ public class MockHttpServletRequest implements 
HttpServletRequest {
      * @see javax.servlet.ServletRequest#getLocalName()
      */
     @Override
-    @SuppressWarnings("javadoc") // This is a Servlet 2.4 method
     public String getLocalName() {
         return null;
     }
@@ -433,7 +432,6 @@ public class MockHttpServletRequest implements 
HttpServletRequest {
      * @see javax.servlet.ServletRequest#getLocalPort()
      */
     @Override
-    @SuppressWarnings("javadoc") // This is a Servlet 2.4 method
     public int getLocalPort() {
         return 0;
     }
@@ -442,7 +440,6 @@ public class MockHttpServletRequest implements 
HttpServletRequest {
      * @see javax.servlet.ServletRequest#getRemotePort()
      */
     @Override
-    @SuppressWarnings("javadoc") // This is a Servlet 2.4 method
     public int getRemotePort() {
         return 0;
     }
@@ -467,7 +464,6 @@ public class MockHttpServletRequest implements 
HttpServletRequest {
      * @see javax.servlet.ServletRequest#getLocalAddr()
      */
     @Override
-    @SuppressWarnings("javadoc") // This is a Servlet 2.4 method
     public String getLocalAddr() {
         return null;
     }
diff --git 
a/src/test/java/org/apache/commons/fileupload/MultipartStreamTest.java 
b/src/test/java/org/apache/commons/fileupload/MultipartStreamTest.java
index ef69914f..69ca85b1 100644
--- a/src/test/java/org/apache/commons/fileupload/MultipartStreamTest.java
+++ b/src/test/java/org/apache/commons/fileupload/MultipartStreamTest.java
@@ -53,7 +53,8 @@ public class MultipartStreamTest {
         final InputStream input = new ByteArrayInputStream(contents);
         final byte[] boundary = BOUNDARY_TEXT.getBytes();
         final int iBufSize = 1;
-        new MultipartStream(
+        @SuppressWarnings("unused")
+        MultipartStream unused = new MultipartStream(
                 input,
                 boundary,
                 iBufSize,
diff --git 
a/src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java 
b/src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java
index d7c805e1..c71349a5 100644
--- a/src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java
+++ b/src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java
@@ -54,9 +54,9 @@ public class ProgressListenerTest {
             assertTrue(pItems >= 0  &&  pItems <= expectedItems);
 
             assertTrue(bytesRead == null  ||  pBytesRead >= 
bytesRead.longValue());
-            bytesRead = new Long(pBytesRead);
+            bytesRead = Long.valueOf(pBytesRead);
             assertTrue(items == null  ||  pItems >= items.intValue());
-            items = new Integer(pItems);
+            items = Integer.valueOf(pItems);
         }
 
         void checkFinished(){