[commons-io] branch master updated: Checkstyle wants final everywhere

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git


The following commit(s) were added to refs/heads/master by this push:
     new d3e5bd6d Checkstyle wants final everywhere
d3e5bd6d is described below

commit d3e5bd6de8bc96abbadccea8b934dc038a32e90c
Author: Sebb <s...@apache.org>
AuthorDate: Tue Oct 3 22:25:43 2023 +0100

    Checkstyle wants final everywhere
---
 .../apache/commons/io/input/XmlStreamReaderTest.java  | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java 
b/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java
index 8f08e795..d0fd0d11 100644
--- a/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java
+++ b/src/test/java/org/apache/commons/io/input/XmlStreamReaderTest.java
@@ -573,25 +573,22 @@ public class XmlStreamReaderTest {
         testRawNoBomValid(UTF_8);
     }
 
-    private void parseCharset(String hdr, String enc) throws Exception {
-            try (InputStream stream = new 
ByteArrayInputStream(hdr.getBytes(StandardCharsets.UTF_8))) {
-                try (XmlStreamReader xml = new XmlStreamReader(stream)) {
-                    String getenc = xml.getEncoding();
+    private void parseCharset(final String hdr, final String enc) throws 
Exception {
+            try (final InputStream stream = new 
ByteArrayInputStream(hdr.getBytes(StandardCharsets.UTF_8))) {
+                try (final XmlStreamReader xml = new XmlStreamReader(stream)) {
+                    final String getenc = xml.getEncoding();
                     assertEquals(enc.toUpperCase(Locale.ROOT), getenc, enc);
                 }
             };
     }
     @Test
     public void testIO_815() throws Exception {
-        System.out.println(XmlStreamReader.ENCODING_PATTERN);
-        MessageFormat fmt = new MessageFormat("<?xml version=\"1.0\" 
encoding=''{0}''?>\n<root>text</root>");
+        final MessageFormat fmt = new MessageFormat("<?xml version=\"1.0\" 
encoding=''{0}''?>\n<root>text</root>");
         for (final Map.Entry<String, Charset> entry : 
Charset.availableCharsets().entrySet()) {
-            String csName = entry.getKey();
-            String header = fmt.format(new Object[]{csName});
-            parseCharset(header, csName);
+            final String csName = entry.getKey();
+            parseCharset(fmt.format(new Object[]{csName}), csName);
             for (final String alias : entry.getValue().aliases()) {
-                header = fmt.format(new Object[]{alias});
-                parseCharset(header, alias);
+                parseCharset(fmt.format(new Object[]{alias}), alias);
             }
         }
     }