This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jcs.git
The following commit(s) were added to refs/heads/master by this push:
new af542135 Don't initialize an instance or static variable to its
default value
new f300e6fb Merge branch 'master' of
https://gitbox.apache.org/repos/asf/commons-jcs
af542135 is described below
commit af5421359783131f8b70b804d9e77780eabd36d4
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Oct 27 10:04:56 2023 -0400
Don't initialize an instance or static variable to its default value
---
.../jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java | 4 ++--
.../jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java | 4 ++--
.../auxiliary/lateral/javagroups/LateralCacheJGListener.java | 2 +-
checkstyle.xml | 1 +
.../lateral/socket/tcp/TCPLateralCacheAttributes.java | 2 +-
.../apache/commons/jcs/access/PartitionedCacheAccess.java | 2 +-
.../lateral/socket/udp/LateralCacheUDPListener.java | 2 +-
.../auxiliary/lateral/xmlrpc/LateralCacheXMLRPCListener.java | 2 +-
.../lateral/xmlrpc/LateralXMLRPCReceiverConnection.java | 2 +-
.../apache/commons/jcs/engine/memory/arc/ARCMemoryCache.java | 12 ++++++------
10 files changed, 17 insertions(+), 16 deletions(-)
diff --git
a/auxiliary-builds/javagroups/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
b/auxiliary-builds/javagroups/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
index 4e861664..b59c9047 100644
---
a/auxiliary-builds/javagroups/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
+++
b/auxiliary-builds/javagroups/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
@@ -49,8 +49,8 @@ public class JavaGroupsCacheAttributes implements
AuxiliaryCacheAttributes
private String name;
private String channelFactoryClassName = "org.javagroups.JChannelFactory";
- private String channelProperties = null;
- private boolean getFromPeers = false;
+ private String channelProperties;
+ private boolean getFromPeers;
public String getChannelFactoryClassName()
{
diff --git
a/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
b/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
index bdd25bae..1959d0b1 100644
---
a/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
+++
b/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/javagroups/JavaGroupsCacheAttributes.java
@@ -46,9 +46,9 @@ public class JavaGroupsCacheAttributes
{
private String channelFactoryClassName = "org.jgroups.JChannelFactory";
- private String channelProperties = null;
+ private String channelProperties;
- private boolean getFromPeers = false;
+ private boolean getFromPeers;
public String getChannelFactoryClassName()
{
diff --git
a/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/lateral/javagroups/LateralCacheJGListener.java
b/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/lateral/javagroups/LateralCacheJGListener.java
index ae41b0a3..3066b359 100644
---
a/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/lateral/javagroups/LateralCacheJGListener.java
+++
b/auxiliary-builds/jdk14/src/java/org/apache/commons/jcs/auxiliary/lateral/javagroups/LateralCacheJGListener.java
@@ -60,7 +60,7 @@ public class LateralCacheJGListener
private ILateralCacheAttributes ilca;
- private int puts = 0;
+ private int puts;
/**
* Only need one since it does work for all regions, just reference by
diff --git a/checkstyle.xml b/checkstyle.xml
index 10abc992..16c430ad 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -42,6 +42,7 @@
<module name="TreeWalker">
+ <module name="ExplicitInitializationCheck" />
<property name="cacheFile" value="${checkstyle.cache.file}" />
<!-- ************************************************************** -->
diff --git
a/commons-jcs3-core/src/main/java/org/apache/commons/jcs3/auxiliary/lateral/socket/tcp/TCPLateralCacheAttributes.java
b/commons-jcs3-core/src/main/java/org/apache/commons/jcs3/auxiliary/lateral/socket/tcp/TCPLateralCacheAttributes.java
index adba78c0..d3be8cd7 100644
---
a/commons-jcs3-core/src/main/java/org/apache/commons/jcs3/auxiliary/lateral/socket/tcp/TCPLateralCacheAttributes.java
+++
b/commons-jcs3-core/src/main/java/org/apache/commons/jcs3/auxiliary/lateral/socket/tcp/TCPLateralCacheAttributes.java
@@ -82,7 +82,7 @@ public class TCPLateralCacheAttributes
private boolean udpDiscoveryEnabled = DEFAULT_UDP_DISCOVERY_ENABLED;
/** udp datagram TTL */
- private int udpTTL = 0;
+ private int udpTTL;
/** can we put */
private boolean allowPut = DEFAULT_ALLOW_GET;
diff --git
a/commons-jcs3-sandbox/commons-jcs3-partitioned/src/main/java/org/apache/commons/jcs/access/PartitionedCacheAccess.java
b/commons-jcs3-sandbox/commons-jcs3-partitioned/src/main/java/org/apache/commons/jcs/access/PartitionedCacheAccess.java
index e7165fa7..14f48909 100644
---
a/commons-jcs3-sandbox/commons-jcs3-partitioned/src/main/java/org/apache/commons/jcs/access/PartitionedCacheAccess.java
+++
b/commons-jcs3-sandbox/commons-jcs3-partitioned/src/main/java/org/apache/commons/jcs/access/PartitionedCacheAccess.java
@@ -78,7 +78,7 @@ public class PartitionedCacheAccess<K, V>
private ICacheAccess<K, V>[] partitions;
/** Is the class initialized. */
- private boolean initialized = false;
+ private boolean initialized;
/** Sets default properties heading and group. */
public PartitionedCacheAccess()
diff --git
a/src/experimental/org/apache/commons/jcs/auxiliary/lateral/socket/udp/LateralCacheUDPListener.java
b/src/experimental/org/apache/commons/jcs/auxiliary/lateral/socket/udp/LateralCacheUDPListener.java
index 5de464c0..52949407 100644
---
a/src/experimental/org/apache/commons/jcs/auxiliary/lateral/socket/udp/LateralCacheUDPListener.java
+++
b/src/experimental/org/apache/commons/jcs/auxiliary/lateral/socket/udp/LateralCacheUDPListener.java
@@ -49,7 +49,7 @@ public class LateralCacheUDPListener implements
ILateralCacheListener, Serializa
// instance vars
private LateralUDPReceiver receiver;
private ILateralCacheAttributes ilca;
- private boolean inited = false;
+ private boolean inited;
/**
diff --git
a/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralCacheXMLRPCListener.java
b/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralCacheXMLRPCListener.java
index 4faec7e0..53c9d76d 100644
---
a/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralCacheXMLRPCListener.java
+++
b/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralCacheXMLRPCListener.java
@@ -49,7 +49,7 @@ public class LateralCacheXMLRPCListener implements
ILateralCacheXMLRPCListener,
// instance vars
private LateralXMLRPCReceiver receiver;
private ILateralCacheAttributes ilca;
- private boolean inited = false;
+ private boolean inited;
/**
diff --git
a/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralXMLRPCReceiverConnection.java
b/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralXMLRPCReceiverConnection.java
index 2171b238..58a07957 100644
---
a/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralXMLRPCReceiverConnection.java
+++
b/src/experimental/org/apache/commons/jcs/auxiliary/lateral/xmlrpc/LateralXMLRPCReceiverConnection.java
@@ -44,7 +44,7 @@ public class LateralXMLRPCReceiverConnection implements
XmlRpcHandler, IXMLRPCCo
private ILateralCacheXMLRPCListener ilcl;
- private int puts = 0;
+ private int puts;
/**
* Constructor for the LateralXMLRPCReceiverConnection object
diff --git
a/src/experimental/org/apache/commons/jcs/engine/memory/arc/ARCMemoryCache.java
b/src/experimental/org/apache/commons/jcs/engine/memory/arc/ARCMemoryCache.java
index e38568be..f1754dc7 100644
---
a/src/experimental/org/apache/commons/jcs/engine/memory/arc/ARCMemoryCache.java
+++
b/src/experimental/org/apache/commons/jcs/engine/memory/arc/ARCMemoryCache.java
@@ -54,7 +54,7 @@ public class ARCMemoryCache
// private int[] loc = new int[0];
// maximum size
- private int maxSize = 0;
+ private int maxSize;
private DoubleLinkedList T1 = new DoubleLinkedList();
@@ -77,17 +77,17 @@ public class ARCMemoryCache
protected static final int _B2_ = 4;
// ideal size of T1
- private int target_T1 = 0;
+ private int target_T1;
private ConcurrentHashMap map = new ConcurrentHashMap();
- private int cnt = 0;
+ private int cnt;
- private int hitCnt = 0;
+ private int hitCnt;
- private int missCnt = 0;
+ private int missCnt;
- private int putCnt = 0;
+ private int putCnt;
/**
* Default constructor.
