This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-ognl.git
The following commit(s) were added to refs/heads/master by this push:
new afbe5f5 Don't initialize an instance or static variable to its
default value
afbe5f5 is described below
commit afbe5f5855903cad513c7912775daa73c9d8d261
Author: Gary Gregory <[email protected]>
AuthorDate: Fri Oct 27 10:57:10 2023 -0400
Don't initialize an instance or static variable to its default value
---
src/main/java/org/apache/commons/ognl/ASTProperty.java | 2 +-
src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java | 2 +-
src/main/java/org/apache/commons/ognl/DefaultMemberAccess.java | 6 +++---
src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java | 2 +-
src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java | 2 +-
src/main/java/org/apache/commons/ognl/OgnlContext.java | 8 ++++----
.../java/org/apache/commons/ognl/enhance/ExpressionCompiler.java | 2 +-
.../java/org/apache/commons/ognl/internal/ClassCacheImpl.java | 2 +-
src/test/java/org/apache/commons/ognl/test/Performance.java | 2 +-
src/test/java/org/apache/commons/ognl/test/objects/Bean2.java | 2 +-
src/test/java/org/apache/commons/ognl/test/objects/Root.java | 4 ++--
src/test/java/org/apache/commons/ognl/test/util/NameFactory.java | 4 ++--
12 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/main/java/org/apache/commons/ognl/ASTProperty.java
b/src/main/java/org/apache/commons/ognl/ASTProperty.java
index 0560d53..aba1412 100644
--- a/src/main/java/org/apache/commons/ognl/ASTProperty.java
+++ b/src/main/java/org/apache/commons/ognl/ASTProperty.java
@@ -33,7 +33,7 @@ public class ASTProperty
extends SimpleNode
implements NodeType
{
- private boolean indexedAccess = false;
+ private boolean indexedAccess;
private Class getterClass;
diff --git a/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java
b/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java
index cf9a2f6..824dd46 100644
--- a/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java
@@ -37,7 +37,7 @@ public class ArrayElementsAccessor
{
private final int count = Array.getLength( target );
- private int index = 0;
+ private int index;
public boolean hasMoreElements()
{
diff --git a/src/main/java/org/apache/commons/ognl/DefaultMemberAccess.java
b/src/main/java/org/apache/commons/ognl/DefaultMemberAccess.java
index a44c491..fcb20c1 100644
--- a/src/main/java/org/apache/commons/ognl/DefaultMemberAccess.java
+++ b/src/main/java/org/apache/commons/ognl/DefaultMemberAccess.java
@@ -32,11 +32,11 @@ import java.util.Map;
public class DefaultMemberAccess
implements MemberAccess
{
- private boolean allowPrivateAccess = false;
+ private boolean allowPrivateAccess;
- private boolean allowProtectedAccess = false;
+ private boolean allowProtectedAccess;
- private boolean allowPackageProtectedAccess = false;
+ private boolean allowPackageProtectedAccess;
/*
* ===================================================================
Constructors
diff --git a/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java
b/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java
index 2094104..56ea84d 100644
--- a/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java
@@ -37,7 +37,7 @@ public class NumberElementsAccessor
{
private final int type = OgnlOps.getNumericType( target );
- private long next = 0;
+ private long next;
private final long finish = OgnlOps.longValue( target );
diff --git a/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java
b/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java
index de05572..7014264 100644
--- a/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java
@@ -36,7 +36,7 @@ public class ObjectElementsAccessor
return new Enumeration<Object>()
{
- private boolean seen = false;
+ private boolean seen;
public boolean hasMoreElements()
{
diff --git a/src/main/java/org/apache/commons/ognl/OgnlContext.java
b/src/main/java/org/apache/commons/ognl/OgnlContext.java
index 78a71b0..20b2c6a 100644
--- a/src/main/java/org/apache/commons/ognl/OgnlContext.java
+++ b/src/main/java/org/apache/commons/ognl/OgnlContext.java
@@ -56,9 +56,9 @@ public class OgnlContext
private static final String PROPERTY_KEY_PREFIX = "ognl";
- private static boolean defaultTraceEvaluations = false;
+ private static boolean defaultTraceEvaluations;
- private static boolean defaultKeepLastEvaluation = false;
+ private static boolean defaultKeepLastEvaluation;
public static final DefaultClassResolver DEFAULT_CLASS_RESOLVER = new
DefaultClassResolver();
@@ -129,9 +129,9 @@ public class OgnlContext
private final Stack<Class<?>> accessorStack = new Stack<Class<?>>();
- private int localReferenceCounter = 0;
+ private int localReferenceCounter;
- private Map<String, LocalReference> localReferenceMap = null;
+ private Map<String, LocalReference> localReferenceMap;
/**
* Constructs a new OgnlContext with the default class resolver, type
converter and member access.
diff --git
a/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
b/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
index fa7b0ff..e915ed8 100644
--- a/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
+++ b/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java
@@ -81,7 +81,7 @@ public class ExpressionCompiler
*/
protected ClassPool pool;
- protected int classCounter = 0;
+ protected int classCounter;
/**
* Used by {@link #castExpression(org.apache.commons.ognl.OgnlContext,
org.apache.commons.ognl.Node, String)} to
diff --git a/src/main/java/org/apache/commons/ognl/internal/ClassCacheImpl.java
b/src/main/java/org/apache/commons/ognl/internal/ClassCacheImpl.java
index a9f756c..7b9db8b 100644
--- a/src/main/java/org/apache/commons/ognl/internal/ClassCacheImpl.java
+++ b/src/main/java/org/apache/commons/ognl/internal/ClassCacheImpl.java
@@ -43,7 +43,7 @@ public class ClassCacheImpl<V>
private ClassCacheInspector classInspector;
- private int size = 0;
+ private int size;
/**
* {@inheritDoc}
diff --git a/src/test/java/org/apache/commons/ognl/test/Performance.java
b/src/test/java/org/apache/commons/ognl/test/Performance.java
index 4271b37..0de6155 100644
--- a/src/test/java/org/apache/commons/ognl/test/Performance.java
+++ b/src/test/java/org/apache/commons/ognl/test/Performance.java
@@ -57,7 +57,7 @@ public class Performance
private final String _expressionString;
- private boolean _isMvel = false;
+ private boolean _isMvel;
private long t0;
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/Bean2.java
b/src/test/java/org/apache/commons/ognl/test/objects/Bean2.java
index 7a372be..168d58f 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/Bean2.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/Bean2.java
@@ -22,7 +22,7 @@ public class Bean2
{
private final Bean3 bean3 = new Bean3();
- private boolean _pageBreakAfter = false;
+ private boolean _pageBreakAfter;
public Long getId()
{
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/Root.java
b/src/test/java/org/apache/commons/ognl/test/objects/Root.java
index 424d478..e5dd856 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/Root.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/Root.java
@@ -46,7 +46,7 @@ public class Root
private final int index = 1;
- private int intValue = 0;
+ private int intValue;
private String stringValue;
@@ -90,7 +90,7 @@ public class Root
private final Date _date = new Date();
- private boolean _openWindow = false;
+ private boolean _openWindow;
private final ITreeContentProvider _contentProvider = new
TreeContentProvider();
diff --git a/src/test/java/org/apache/commons/ognl/test/util/NameFactory.java
b/src/test/java/org/apache/commons/ognl/test/util/NameFactory.java
index 78f55cf..c91d5c2 100644
--- a/src/test/java/org/apache/commons/ognl/test/util/NameFactory.java
+++ b/src/test/java/org/apache/commons/ognl/test/util/NameFactory.java
@@ -23,11 +23,11 @@ public class NameFactory
{
private final String classBaseName;
- private int classNameCounter = 0;
+ private int classNameCounter;
private final String variableBaseName;
- private int variableNameCounter = 0;
+ private int variableNameCounter;
/*
* ===================================================================
Constructors
