(commons-compress) branch master updated: Let JUnit manage temporary files

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git


The following commit(s) were added to refs/heads/master by this push:
     new 0929c683 Let JUnit manage temporary files
0929c683 is described below

commit 0929c6833cbda06a36afaca790b34436662f2386
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sat Nov 4 12:27:02 2023 -0400

    Let JUnit manage temporary files
---
 .../commons/compress/archivers/examples/ExpanderTest.java     | 11 +++--------
 .../commons/compress/archivers/tar/TarArchiveEntryTest.java   |  1 -
 .../apache/commons/compress/archivers/zip/ZipFileTest.java    |  8 +++-----
 3 files changed, 6 insertions(+), 14 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/compress/archivers/examples/ExpanderTest.java
 
b/src/test/java/org/apache/commons/compress/archivers/examples/ExpanderTest.java
index 98406d0b..07dced36 100644
--- 
a/src/test/java/org/apache/commons/compress/archivers/examples/ExpanderTest.java
+++ 
b/src/test/java/org/apache/commons/compress/archivers/examples/ExpanderTest.java
@@ -207,14 +207,9 @@ public class ExpanderTest extends AbstractTest {
         assumeFalse(s.exists());
         s.mkdirs();
         assumeTrue(s.exists());
-        s.deleteOnExit();
-        try {
-            setupZip("../" + sibling + "/a");
-            try (ZipFile f = new ZipFile(archive)) {
-                assertThrows(IOException.class, () -> new Expander().expand(f, 
tempResultDir));
-            }
-        } finally {
-            forceDelete(s);
+        setupZip("../" + sibling + "/a");
+        try (ZipFile f = new ZipFile(archive)) {
+            assertThrows(IOException.class, () -> new Expander().expand(f, 
tempResultDir));
         }
     }
 
diff --git 
a/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveEntryTest.java
 
b/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveEntryTest.java
index cad0c374..2e36fc51 100644
--- 
a/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveEntryTest.java
+++ 
b/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveEntryTest.java
@@ -430,7 +430,6 @@ public class TarArchiveEntryTest implements TarConstants {
     @Test
     public void testTarFileWithFSRoot() throws IOException {
         final File f = File.createTempFile("taetest", ".tar");
-        f.deleteOnExit();
         TarArchiveEntry t = new TarArchiveEntry(new File(ROOT));
         try {
             try (TarArchiveOutputStream tout = new 
TarArchiveOutputStream(Files.newOutputStream(f.toPath()))) {
diff --git 
a/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java 
b/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
index 8a2ec029..645588f3 100644
--- a/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
+++ b/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
@@ -744,10 +744,9 @@ public class ZipFileTest extends AbstractTest {
 
     @Test
     public void testReadingOfStoredEntry() throws Exception {
-        final File f = createTempFile("commons-compress-zipfiletest", ".zip");
-        f.deleteOnExit();
+        final File file = createTempFile("commons-compress-zipfiletest", 
".zip");
         ZipArchiveEntry ze;
-        try (OutputStream o = Files.newOutputStream(f.toPath());
+        try (OutputStream o = Files.newOutputStream(file.toPath());
                 ZipArchiveOutputStream zo = new ZipArchiveOutputStream(o)) {
             ze = new ZipArchiveEntry("foo");
             ze.setMethod(ZipEntry.STORED);
@@ -758,7 +757,7 @@ public class ZipFileTest extends AbstractTest {
             zo.closeArchiveEntry();
         }
 
-        zf = new ZipFile(f);
+        zf = new ZipFile(file);
         ze = zf.getEntry("foo");
         assertNotNull(ze);
         try (InputStream i = zf.getInputStream(ze)) {
@@ -777,7 +776,6 @@ public class ZipFileTest extends AbstractTest {
 
         final String testEntryName = "test_self_extract_zip/foo";
         final File extractedFile = new File(testZip.getParentFile(), 
testEntryName);
-        extractedFile.deleteOnExit();
 
         final byte[] testData = { 1, 2, 3, 4 };
         final byte[] buffer = new byte[512];