This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
The following commit(s) were added to refs/heads/master by this push:
new 30735e6a Make package private class final
30735e6a is described below
commit 30735e6abeb01008a2298668728dcb933b6ea301
Author: Gary David Gregory (Code signing key) <[email protected]>
AuthorDate: Sun Nov 5 07:57:44 2023 -0500
Make package private class final
---
src/examples/ClassDumper.java | 4 ++--
src/main/java/org/apache/bcel/util/BCELFactory.java | 2 +-
src/main/java/org/apache/bcel/verifier/VerifyDialog.java | 5 +++--
src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java | 4 ++--
.../org/apache/bcel/classfile/InvalidMethodSigantureTestCase.java | 2 +-
src/test/java/org/apache/bcel/classfile/UtilityTestCase.java | 2 +-
src/test/java/org/apache/bcel/data/AnonymousClassTest.java | 2 +-
src/test/java/org/apache/bcel/data/AttributeTestClassEM01.java | 2 +-
src/test/java/org/apache/bcel/data/LargeMethod.java | 2 +-
src/test/java/org/apache/bcel/generic/EmptyVisitorTestCase.java | 2 +-
src/test/java/org/apache/bcel/generic/LargeJump.java | 2 +-
src/test/java/org/apache/bcel/verifier/JiraBcel369TestFixture.java | 2 +-
12 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/src/examples/ClassDumper.java b/src/examples/ClassDumper.java
index c1772a2a..5770ba50 100644
--- a/src/examples/ClassDumper.java
+++ b/src/examples/ClassDumper.java
@@ -32,7 +32,7 @@ import org.apache.bcel.util.BCELifier;
/**
* Display Java .class file data. Output is based on javap tool. Built using
the BCEL libary.
*/
-class ClassDumper {
+final class ClassDumper {
private final FileImageInputStream file;
private final String fileName;
@@ -341,7 +341,7 @@ class ClassDumper {
}
-class DumpClass {
+final class DumpClass {
public static void main(final String[] args) throws IOException {
diff --git a/src/main/java/org/apache/bcel/util/BCELFactory.java
b/src/main/java/org/apache/bcel/util/BCELFactory.java
index 554e3b13..b00ab703 100644
--- a/src/main/java/org/apache/bcel/util/BCELFactory.java
+++ b/src/main/java/org/apache/bcel/util/BCELFactory.java
@@ -60,7 +60,7 @@ import org.apache.bcel.generic.Type;
*
* @see BCELifier
*/
-class BCELFactory extends EmptyVisitor {
+final class BCELFactory extends EmptyVisitor {
private static final String CONSTANT_PREFIX = Const.class.getSimpleName()
+ ".";
private final MethodGen methodGen;
diff --git a/src/main/java/org/apache/bcel/verifier/VerifyDialog.java
b/src/main/java/org/apache/bcel/verifier/VerifyDialog.java
index 270159bd..9d316b02 100644
--- a/src/main/java/org/apache/bcel/verifier/VerifyDialog.java
+++ b/src/main/java/org/apache/bcel/verifier/VerifyDialog.java
@@ -46,8 +46,8 @@ import org.apache.bcel.classfile.Utility;
*/
public class VerifyDialog extends JDialog {
- /** Machine-generated. */
- class IvjEventHandler implements ActionListener {
+ /** Machine-generated, made final. */
+ final class IvjEventHandler implements ActionListener {
@Override
public void actionPerformed(final ActionEvent e) {
@@ -67,6 +67,7 @@ public class VerifyDialog extends JDialog {
}
private static final long serialVersionUID = -6374807677043142313L;
+
/**
* This field is here to count the number of open VerifyDialog instances
so the JVM can be exited afer every Dialog had
* been closed.
diff --git a/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java
b/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java
index 73c6becc..3c154fac 100644
--- a/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java
+++ b/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java
@@ -33,11 +33,11 @@ import org.apache.bcel.util.ClassPath;
import org.apache.bcel.util.ClassPathRepository;
import org.junit.jupiter.api.Test;
-class ClassWithDoubleConstantPoolItem {
+final class ClassWithDoubleConstantPoolItem {
double d = 42; // here is the key; we need a double constant value
}
-class ClassWithLongConstantPoolItem {
+final class ClassWithLongConstantPoolItem {
long l = 42; // here is the key; we need a double constant value
}
diff --git
a/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTestCase.java
b/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTestCase.java
index 2a4696c3..6547fc27 100644
---
a/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTestCase.java
+++
b/src/test/java/org/apache/bcel/classfile/InvalidMethodSigantureTestCase.java
@@ -50,7 +50,7 @@ final class test$method name with () in it$1 extends
kotlin.jvm.internal.Lambda
*/
public class InvalidMethodSigantureTestCase {
- class TestVisitor extends org.apache.bcel.classfile.EmptyVisitor {
+ final class TestVisitor extends org.apache.bcel.classfile.EmptyVisitor {
@Override
public void visitField(final Field field) {
field.getType();
diff --git a/src/test/java/org/apache/bcel/classfile/UtilityTestCase.java
b/src/test/java/org/apache/bcel/classfile/UtilityTestCase.java
index fb1b8785..8c3144b6 100644
--- a/src/test/java/org/apache/bcel/classfile/UtilityTestCase.java
+++ b/src/test/java/org/apache/bcel/classfile/UtilityTestCase.java
@@ -43,7 +43,7 @@ public class UtilityTestCase {
@Test
public void testCodeToString() throws Exception {
- class CodeToString {
+ final class CodeToString {
int[][] a = new int[0][0];
CodeToString() {
diff --git a/src/test/java/org/apache/bcel/data/AnonymousClassTest.java
b/src/test/java/org/apache/bcel/data/AnonymousClassTest.java
index 7ae31a6d..89b31192 100644
--- a/src/test/java/org/apache/bcel/data/AnonymousClassTest.java
+++ b/src/test/java/org/apache/bcel/data/AnonymousClassTest.java
@@ -18,7 +18,7 @@
package org.apache.bcel.data;
public class AnonymousClassTest {
- class X {
+ final class X {
}
static class Y {
diff --git a/src/test/java/org/apache/bcel/data/AttributeTestClassEM01.java
b/src/test/java/org/apache/bcel/data/AttributeTestClassEM01.java
index ff9f0ad7..dbbe1fb4 100644
--- a/src/test/java/org/apache/bcel/data/AttributeTestClassEM01.java
+++ b/src/test/java/org/apache/bcel/data/AttributeTestClassEM01.java
@@ -20,7 +20,7 @@ package org.apache.bcel.data;
public class AttributeTestClassEM01 {
public static void main(final String[] argv) {
@SuppressWarnings("unused")
- class S {
+ final class S {
public void sayhello() {
System.err.println("hello");
}
diff --git a/src/test/java/org/apache/bcel/data/LargeMethod.java
b/src/test/java/org/apache/bcel/data/LargeMethod.java
index a9c009e7..fd0e829d 100644
--- a/src/test/java/org/apache/bcel/data/LargeMethod.java
+++ b/src/test/java/org/apache/bcel/data/LargeMethod.java
@@ -20,7 +20,7 @@ package org.apache.bcel.data;
// Due to the way try finally is implemented in the standard java compiler
// from Oracle, this class generates a huge (>32767 code bytes) <init> method.
// Verified with javac versions 1.8.0_261, 11.0.10 and 17.0.1.
-class LargeMethod {
+final class LargeMethod {
{
@SuppressWarnings("unused")
int a;
diff --git a/src/test/java/org/apache/bcel/generic/EmptyVisitorTestCase.java
b/src/test/java/org/apache/bcel/generic/EmptyVisitorTestCase.java
index 5159328f..cdbb808b 100644
--- a/src/test/java/org/apache/bcel/generic/EmptyVisitorTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/EmptyVisitorTestCase.java
@@ -28,7 +28,7 @@ import org.apache.commons.lang3.SystemUtils;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
-class EmptyVisitorTestCase {
+final class EmptyVisitorTestCase {
/*
* https://docs.oracle.com/javase/specs/jvms/se17/html/jvms-6.html#jvms-6.2
diff --git a/src/test/java/org/apache/bcel/generic/LargeJump.java
b/src/test/java/org/apache/bcel/generic/LargeJump.java
index e03aed6a..31a82e16 100644
--- a/src/test/java/org/apache/bcel/generic/LargeJump.java
+++ b/src/test/java/org/apache/bcel/generic/LargeJump.java
@@ -16,7 +16,7 @@
*/
package org.apache.bcel.generic;
-class LargeJump {
+final class LargeJump {
public static void methodWithLargeJump(final int i) {
for (; i == 0;) {
try {
diff --git a/src/test/java/org/apache/bcel/verifier/JiraBcel369TestFixture.java
b/src/test/java/org/apache/bcel/verifier/JiraBcel369TestFixture.java
index dae9e712..203ffd66 100644
--- a/src/test/java/org/apache/bcel/verifier/JiraBcel369TestFixture.java
+++ b/src/test/java/org/apache/bcel/verifier/JiraBcel369TestFixture.java
@@ -17,7 +17,7 @@
package org.apache.bcel.verifier;
-class JiraBcel369TestFixture {
+final class JiraBcel369TestFixture {
public JiraBcel369TestFixture(int i) {
try {
