This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
The following commit(s) were added to refs/heads/master by this push:
new 30b581cf Make package private class final
30b581cf is described below
commit 30b581cfaff7fb8ed66d3f8c2c0faca8bd6023c6
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Nov 5 08:08:11 2023 -0500
Make package private class final
---
.../apache/commons/beanutils2/BeanIntrospectionData.java | 2 +-
.../commons/beanutils2/DefaultIntrospectionContext.java | 2 +-
.../org/apache/commons/beanutils2/PropertyDescriptors.java | 2 +-
.../apache/commons/beanutils2/BeanificationTestCase.java | 14 +++++++-------
.../apache/commons/beanutils2/TestBeanPackageSubclass.java | 2 +-
.../apache/commons/beanutils2/bugs/Jira422TestCase.java | 4 ++--
.../apache/commons/beanutils2/bugs/Jira422bTestCase.java | 4 ++--
.../beanutils2/locale/LocaleBeanificationTestCase.java | 14 +++++++-------
.../org/apache/commons/beanutils2/priv/PackageBean.java | 3 ---
.../org/apache/commons/beanutils2/priv/PrivateBean.java | 2 --
.../commons/beanutils2/priv/PrivateBeanSubclass.java | 2 +-
11 files changed, 23 insertions(+), 28 deletions(-)
diff --git
a/src/main/java/org/apache/commons/beanutils2/BeanIntrospectionData.java
b/src/main/java/org/apache/commons/beanutils2/BeanIntrospectionData.java
index 7ca1c382..f8c17dac 100644
--- a/src/main/java/org/apache/commons/beanutils2/BeanIntrospectionData.java
+++ b/src/main/java/org/apache/commons/beanutils2/BeanIntrospectionData.java
@@ -41,7 +41,7 @@ import java.util.Map;
*
* @since 1.9.1
*/
-class BeanIntrospectionData {
+final class BeanIntrospectionData {
/**
* Initializes the map with the names of the write methods for the
supported
* properties. The method names - if defined - need to be stored
separately because
diff --git
a/src/main/java/org/apache/commons/beanutils2/DefaultIntrospectionContext.java
b/src/main/java/org/apache/commons/beanutils2/DefaultIntrospectionContext.java
index af814cb5..c0e75fe0 100644
---
a/src/main/java/org/apache/commons/beanutils2/DefaultIntrospectionContext.java
+++
b/src/main/java/org/apache/commons/beanutils2/DefaultIntrospectionContext.java
@@ -34,7 +34,7 @@ import java.util.Set;
*
* @since 1.9
*/
-class DefaultIntrospectionContext implements IntrospectionContext {
+final class DefaultIntrospectionContext implements IntrospectionContext {
/** The current class for introspection. */
private final Class<?> currentClass;
diff --git
a/src/main/java/org/apache/commons/beanutils2/PropertyDescriptors.java
b/src/main/java/org/apache/commons/beanutils2/PropertyDescriptors.java
index 797bff79..b46c7256 100644
--- a/src/main/java/org/apache/commons/beanutils2/PropertyDescriptors.java
+++ b/src/main/java/org/apache/commons/beanutils2/PropertyDescriptors.java
@@ -19,7 +19,7 @@ package org.apache.commons.beanutils2;
import java.beans.PropertyDescriptor;
-class PropertyDescriptors {
+final class PropertyDescriptors {
static final PropertyDescriptor[] EMPTY_ARRAY = {};
diff --git
a/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
b/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
index 447b6868..87a893ad 100644
--- a/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BeanificationTestCase.java
@@ -35,7 +35,7 @@ import junit.framework.TestSuite;
*/
public class BeanificationTestCase extends TestCase {
- class Signal {
+ final class Signal {
private Exception e;
private int signal;
private BeanUtilsBean bean;
@@ -92,7 +92,7 @@ public class BeanificationTestCase extends TestCase {
}
}
- class TestClassLoader extends ClassLoader {
+ final class TestClassLoader extends ClassLoader {
@Override
public String toString() {
return "TestClassLoader";
@@ -137,7 +137,7 @@ public class BeanificationTestCase extends TestCase {
/** Tests whether different threads can set beanutils instances correctly
*/
public void testBeanUtilsBeanSetInstance() throws Exception {
- class SetInstanceTesterThread extends Thread {
+ final class SetInstanceTesterThread extends Thread {
private final Signal signal;
private final BeanUtilsBean bean;
@@ -183,7 +183,7 @@ public class BeanificationTestCase extends TestCase {
/** Tests whether calls are independent for different classloaders */
public void testContextClassloaderIndependence() throws Exception {
- class TestIndependenceThread extends Thread {
+ final class TestIndependenceThread extends Thread {
private final Signal signal;
private final PrimitiveBean bean;
@@ -239,7 +239,7 @@ public class BeanificationTestCase extends TestCase {
*/
public void testContextClassLoaderLocal() throws Exception {
- class CCLLTesterThread extends Thread {
+ final class CCLLTesterThread extends Thread {
private final Signal signal;
private final ContextClassLoaderLocal<Integer> ccll;
@@ -295,7 +295,7 @@ public class BeanificationTestCase extends TestCase {
*/
public void testGetByContextClassLoader() throws Exception {
- class GetBeanUtilsBeanThread extends Thread {
+ final class GetBeanUtilsBeanThread extends Thread {
private final Signal signal;
@@ -344,7 +344,7 @@ public class BeanificationTestCase extends TestCase {
final WeakReference<ClassLoader> loaderReference = new
WeakReference<>(loader);
BeanUtilsBean.getInstance();
- class GetBeanUtilsBeanThread extends Thread {
+ final class GetBeanUtilsBeanThread extends Thread {
BeanUtilsBean beanUtils;
ConvertUtilsBean convertUtils;
diff --git
a/src/test/java/org/apache/commons/beanutils2/TestBeanPackageSubclass.java
b/src/test/java/org/apache/commons/beanutils2/TestBeanPackageSubclass.java
index cd581d11..0a1c0261 100644
--- a/src/test/java/org/apache/commons/beanutils2/TestBeanPackageSubclass.java
+++ b/src/test/java/org/apache/commons/beanutils2/TestBeanPackageSubclass.java
@@ -22,6 +22,6 @@ package org.apache.commons.beanutils2;
*
*/
-class TestBeanPackageSubclass extends TestBean {
+final class TestBeanPackageSubclass extends TestBean {
}
diff --git
a/src/test/java/org/apache/commons/beanutils2/bugs/Jira422TestCase.java
b/src/test/java/org/apache/commons/beanutils2/bugs/Jira422TestCase.java
index 55e70bf2..eb2304d6 100644
--- a/src/test/java/org/apache/commons/beanutils2/bugs/Jira422TestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/bugs/Jira422TestCase.java
@@ -31,7 +31,7 @@ import org.junit.Assume;
import org.junit.BeforeClass;
import org.junit.Test;
-class FirstChildBean extends RootBean {
+final class FirstChildBean extends RootBean {
}
/**
@@ -101,5 +101,5 @@ class RootBean {
}
-class SecondChildBean extends RootBean {
+final class SecondChildBean extends RootBean {
}
diff --git
a/src/test/java/org/apache/commons/beanutils2/bugs/Jira422bTestCase.java
b/src/test/java/org/apache/commons/beanutils2/bugs/Jira422bTestCase.java
index 0f25bf93..bc992986 100644
--- a/src/test/java/org/apache/commons/beanutils2/bugs/Jira422bTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/bugs/Jira422bTestCase.java
@@ -21,7 +21,7 @@ import static org.junit.Assert.assertEquals;
import org.apache.commons.beanutils2.PropertyUtils;
import org.junit.Test;
-class FirstChildBeanB extends RootBeanB {
+final class FirstChildBeanB extends RootBeanB {
}
/**
@@ -70,5 +70,5 @@ class RootBeanB {
}
-class SecondChildBeanB extends RootBeanB {
+final class SecondChildBeanB extends RootBeanB {
}
diff --git
a/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
b/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
index 88c8efea..368922b3 100644
---
a/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
+++
b/src/test/java/org/apache/commons/beanutils2/locale/LocaleBeanificationTestCase.java
@@ -47,7 +47,7 @@ import org.junit.jupiter.api.Test;
*/
public class LocaleBeanificationTestCase {
- class Signal {
+ final class Signal {
private Exception e;
private int signal;
private LocaleBeanUtilsBean bean;
@@ -95,7 +95,7 @@ public class LocaleBeanificationTestCase {
}
}
- class TestClassLoader extends ClassLoader {
+ final class TestClassLoader extends ClassLoader {
@Override
public String toString() {
return "TestClassLoader";
@@ -117,7 +117,7 @@ public class LocaleBeanificationTestCase {
@Test
public void testBeanUtilsBeanSetInstance() throws Exception {
- class SetInstanceTesterThread extends Thread {
+ final class SetInstanceTesterThread extends Thread {
private final Signal signal;
private final LocaleBeanUtilsBean bean;
@@ -163,7 +163,7 @@ public class LocaleBeanificationTestCase {
/** Tests whether calls are independent for different classloaders */
public void testContextClassloaderIndependence() throws Exception {
- class TestIndependenceThread extends Thread {
+ final class TestIndependenceThread extends Thread {
private final Signal signal;
private final PrimitiveBean bean;
@@ -237,7 +237,7 @@ public class LocaleBeanificationTestCase {
*/
public void testContextClassLoaderLocal() throws Exception {
- class CCLLTesterThread extends Thread {
+ final class CCLLTesterThread extends Thread {
private final Signal signal;
private final ContextClassLoaderLocal<Integer> ccll;
@@ -293,7 +293,7 @@ public class LocaleBeanificationTestCase {
*/
public void testGetByContextClassLoader() throws Exception {
- class GetBeanUtilsBeanThread extends Thread {
+ final class GetBeanUtilsBeanThread extends Thread {
private final Signal signal;
@@ -384,7 +384,7 @@ public class LocaleBeanificationTestCase {
final WeakReference<TestClassLoader> loaderReference = new
WeakReference<>(loader);
LocaleBeanUtilsBean.getLocaleBeanUtilsInstance();
- class GetBeanUtilsBeanThread extends Thread {
+ final class GetBeanUtilsBeanThread extends Thread {
LocaleBeanUtilsBean beanUtils;
LocaleConvertUtilsBean convertUtils;
diff --git a/src/test/java/org/apache/commons/beanutils2/priv/PackageBean.java
b/src/test/java/org/apache/commons/beanutils2/priv/PackageBean.java
index c4bd457a..0ad6598f 100644
--- a/src/test/java/org/apache/commons/beanutils2/priv/PackageBean.java
+++ b/src/test/java/org/apache/commons/beanutils2/priv/PackageBean.java
@@ -22,13 +22,10 @@ package org.apache.commons.beanutils2.priv;
* This class is designed to test the default access jvm problem workaround.
The issue is that public methods of a public subclass contained in a default
access
* superclass are returned by reflection but an IllegalAccessException is
thrown when they are invoked.
* </p>
- *
* <p>
* This is the default access superclass
* </p>
- *
*/
-
class PackageBean {
/**
diff --git a/src/test/java/org/apache/commons/beanutils2/priv/PrivateBean.java
b/src/test/java/org/apache/commons/beanutils2/priv/PrivateBean.java
index 6db07354..75eddd3f 100644
--- a/src/test/java/org/apache/commons/beanutils2/priv/PrivateBean.java
+++ b/src/test/java/org/apache/commons/beanutils2/priv/PrivateBean.java
@@ -24,9 +24,7 @@ package org.apache.commons.beanutils2.priv;
* <li><strong>bar</strong> - Via directly implemented interface
* <li><strong>baz</strong> - Via indirectly implemented interface
* </ul>
- *
*/
-
class PrivateBean implements PrivateDirect {
/**
diff --git
a/src/test/java/org/apache/commons/beanutils2/priv/PrivateBeanSubclass.java
b/src/test/java/org/apache/commons/beanutils2/priv/PrivateBeanSubclass.java
index 793a3a7f..1bef7b9c 100644
--- a/src/test/java/org/apache/commons/beanutils2/priv/PrivateBeanSubclass.java
+++ b/src/test/java/org/apache/commons/beanutils2/priv/PrivateBeanSubclass.java
@@ -22,7 +22,7 @@ package org.apache.commons.beanutils2.priv;
*
*/
-class PrivateBeanSubclass extends PrivateBean {
+final class PrivateBeanSubclass extends PrivateBean {
/**
* Create a new PrivateBeanSubclass instance.
