This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch crypto-174
in repository https://gitbox.apache.org/repos/asf/commons-crypto.git
The following commit(s) were added to refs/heads/crypto-174 by this push:
new 696d38ff Docco [skip ci]
696d38ff is described below
commit 696d38ffa3743d83099f3e8c03cda5524c8c2dcf
Author: Sebb <[email protected]>
AuthorDate: Mon Nov 6 22:03:38 2023 +0000
Docco [skip ci]
---
src/main/java/org/apache/commons/crypto/utils/Utils.java | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/crypto/utils/Utils.java
b/src/main/java/org/apache/commons/crypto/utils/Utils.java
index 7e54001a..6160d64a 100644
--- a/src/main/java/org/apache/commons/crypto/utils/Utils.java
+++ b/src/main/java/org/apache/commons/crypto/utils/Utils.java
@@ -190,7 +190,7 @@ public final class Utils {
/*
* Override the default DLL name if jni.library.path is a valid directory
- * If jni.library.name is defined, this overrides the default name
+ * If jni.library.name is defined, this overrides the default name.
*
* @param name - the default name, passed from native code
* @return the updated library path
@@ -199,7 +199,13 @@ public final class Utils {
* makes maintenance easier.
* The code is intended for use with macOS where SIP makes it hard to
override
* the environment variables needed to override the DLL search path. It
also
- * works for Linux, but is not (currently) used or needed for Windows.
+ * works for Linux.
+ * On both macOS and Linux, different versions of the library are stored
in different directories.
+ * In each case, there is a link from the canonical name (libcrypto.xx) to
the versioned name (libcrypto-1.2.3.xx)
+ * However on Windows, all the DLL versions seem to be stored in the same
directory.
+ * This means that Windows code needs to be given the versioned name (e.g.
crypto-1_1-x64)
+ * This is done by defining jni.library.name.
+ *
* Do not change the method name or its signature!
*/
static String libraryPath(final String name) {
