(commons-vfs) branch master updated: Better terst assertion messages

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git


The following commit(s) were added to refs/heads/master by this push:
     new 0358d5f5 Better terst assertion messages
0358d5f5 is described below

commit 0358d5f599e7624e29445d5caff78cab945195e7
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Nov 8 09:44:38 2023 -0500

    Better terst assertion messages
    
    Better param names
---
 .../org/apache/commons/vfs2/LastModifiedTests.java | 24 +++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git 
a/commons-vfs2/src/test/java/org/apache/commons/vfs2/LastModifiedTests.java 
b/commons-vfs2/src/test/java/org/apache/commons/vfs2/LastModifiedTests.java
index 9cba18d6..1a922811 100644
--- a/commons-vfs2/src/test/java/org/apache/commons/vfs2/LastModifiedTests.java
+++ b/commons-vfs2/src/test/java/org/apache/commons/vfs2/LastModifiedTests.java
@@ -32,24 +32,24 @@ public class LastModifiedTests extends 
AbstractProviderTestCase {
 
     protected static final Duration ONE_DAY = Duration.ofDays(1);
 
-    protected void assertDeltaMillis(final String message, final long 
expected, final long actual, final long delta) {
-        if (expected == actual) {
+    protected void assertDeltaMillis(final String message, final long 
expectedMillis, final long actualMillis, final long deltaMillis) {
+        if (expectedMillis == actualMillis) {
             return;
         }
         // getLastModTimeAccuracy() is not accurate
-        final long actualDelta = Math.abs(expected - actual);
-        if (actualDelta > Math.max(delta, 1000)) {
-            Assertions.fail(String.format("%s expected=%,d (%s), actual=%,d 
(%s), expected delta=%,d, actual delta=%,d",
-                message, Long.valueOf(expected), new 
Date(expected).toString(), Long.valueOf(actual),
-                new Date(actual).toString(), Long.valueOf(delta), 
Long.valueOf(actualDelta)));
+        final long actualDelta = Math.abs(expectedMillis - actualMillis);
+        if (actualDelta > Math.max(deltaMillis, 1000)) {
+            Assertions.fail(String.format("%s expected=%,d (%s), actual=%,d 
(%s), expected delta=%,d, actual delta=%,d millis", message,
+                    Long.valueOf(expectedMillis), new 
Date(expectedMillis).toString(), Long.valueOf(actualMillis), new 
Date(actualMillis).toString(),
+                    Long.valueOf(deltaMillis), Long.valueOf(actualDelta)));
         }
     }
 
-    protected void assertEqualMillis(final String message, final long 
expected, final long actual) {
-        if (expected != actual) {
-            final long delta = Math.abs(expected - actual);
-            Assertions.fail(String.format("%s expected=%,d (%s), actual=%,d 
(%s), delta=%,d", message, Long.valueOf(expected),
-                    new Date(expected).toString(), Long.valueOf(actual), new 
Date(actual).toString(), delta));
+    protected void assertEqualMillis(final String message, final long 
expectedMillis, final long actualMillis) {
+        if (expectedMillis != actualMillis) {
+            final long delta = Math.abs(expectedMillis - actualMillis);
+            Assertions.fail(String.format("%s expected=%,d (%s), actual=%,d 
(%s), delta=%,d millis", message, Long.valueOf(expectedMillis),
+                    new Date(expectedMillis).toString(), 
Long.valueOf(actualMillis), new Date(actualMillis).toString(), delta));
         }
     }