This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jexl.git
The following commit(s) were added to refs/heads/master by this push: new 44b22a66 Remove extra blank lines 44b22a66 is described below commit 44b22a66fffb47de4af108ff3d8840a7b5ced5b8 Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sun Nov 26 14:04:10 2023 -0500 Remove extra blank lines --- src/main/java/org/apache/commons/jexl3/JexlException.java | 3 --- src/main/java/org/apache/commons/jexl3/JexlFeatures.java | 3 --- src/main/java/org/apache/commons/jexl3/internal/Debugger.java | 3 --- src/main/java/org/apache/commons/jexl3/internal/Engine.java | 1 - src/main/java/org/apache/commons/jexl3/internal/Engine32.java | 1 - src/main/java/org/apache/commons/jexl3/internal/IntegerRange.java | 1 - src/main/java/org/apache/commons/jexl3/internal/Interpreter.java | 1 - .../java/org/apache/commons/jexl3/internal/InterpreterBase.java | 1 - src/main/java/org/apache/commons/jexl3/internal/Scope.java | 1 - src/main/java/org/apache/commons/jexl3/internal/SoftCache.java | 4 ---- .../java/org/apache/commons/jexl3/internal/TemplateDebugger.java | 1 - src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java | 3 --- .../commons/jexl3/internal/introspection/EnumerationIterator.java | 1 - .../apache/commons/jexl3/internal/introspection/IndexedType.java | 1 - .../apache/commons/jexl3/internal/introspection/MethodExecutor.java | 2 -- .../java/org/apache/commons/jexl3/introspection/JexlUberspect.java | 1 - .../java/org/apache/commons/jexl3/parser/ASTIdentifierAccess.java | 1 - src/main/java/org/apache/commons/jexl3/parser/JexlParser.java | 1 - src/main/java/org/apache/commons/jexl3/parser/NumberParser.java | 1 - .../java/org/apache/commons/jexl3/parser/TokenMgrException.java | 1 - .../java/org/apache/commons/jexl3/scripting/JexlScriptEngine.java | 2 -- src/test/java/org/apache/commons/jexl3/ArithmeticTest.java | 1 - src/test/java/org/apache/commons/jexl3/ArrayAccessTest.java | 2 -- src/test/java/org/apache/commons/jexl3/CacheTest.java | 1 - src/test/java/org/apache/commons/jexl3/CollectionLiteralTest.java | 1 - src/test/java/org/apache/commons/jexl3/ConcurrentCache.java | 1 - src/test/java/org/apache/commons/jexl3/DoWhileTest.java | 1 - src/test/java/org/apache/commons/jexl3/FeaturesTest.java | 1 - src/test/java/org/apache/commons/jexl3/Foo.java | 1 - src/test/java/org/apache/commons/jexl3/IfTest.java | 1 - src/test/java/org/apache/commons/jexl3/Issues100Test.java | 1 - src/test/java/org/apache/commons/jexl3/Issues200Test.java | 6 ------ src/test/java/org/apache/commons/jexl3/Issues300Test.java | 4 ---- src/test/java/org/apache/commons/jexl3/Issues400Test.java | 1 - src/test/java/org/apache/commons/jexl3/JXLTTest.java | 1 - src/test/java/org/apache/commons/jexl3/LexicalTest.java | 1 - src/test/java/org/apache/commons/jexl3/MethodTest.java | 1 - src/test/java/org/apache/commons/jexl3/PragmaTest.java | 1 - src/test/java/org/apache/commons/jexl3/PropertyAccessTest.java | 4 ---- src/test/java/org/apache/commons/jexl3/ScriptTest.java | 1 - src/test/java/org/apache/commons/jexl3/SideEffectTest.java | 2 -- src/test/java/org/apache/commons/jexl3/SynchronizedArithmetic.java | 1 - .../java/org/apache/commons/jexl3/SynchronizedOverloadsTest.java | 2 -- src/test/java/org/apache/commons/jexl3/VarTest.java | 1 - src/test/java/org/apache/commons/jexl3/examples/AbstractOutput.java | 1 - .../java/org/apache/commons/jexl3/examples/MethodPropertyTest.java | 1 - .../org/apache/commons/jexl3/internal/introspection/NoJexlTest.java | 1 - .../commons/jexl3/internal/introspection/PermissionsTest.java | 3 --- .../jexl3/internal/introspection/nojexlpackage/package-info.java | 1 - .../java/org/apache/commons/jexl3/introspection/SandboxTest.java | 1 - .../java/org/apache/commons/jexl3/jexl342/ReferenceGetExecutor.java | 1 - .../org/apache/commons/jexl3/jexl342/ReferenceMethodExecutor.java | 1 - .../java/org/apache/commons/jexl3/jexl342/ReferenceSetExecutor.java | 1 - .../java/org/apache/commons/jexl3/jexl342/ReferenceUberspect.java | 1 - .../org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java | 1 - 55 files changed, 84 deletions(-) diff --git a/src/main/java/org/apache/commons/jexl3/JexlException.java b/src/main/java/org/apache/commons/jexl3/JexlException.java index c60b7296..0c7a8556 100644 --- a/src/main/java/org/apache/commons/jexl3/JexlException.java +++ b/src/main/java/org/apache/commons/jexl3/JexlException.java @@ -49,7 +49,6 @@ public class JexlException extends RuntimeException { /** Maximum number of characters around exception location. */ private static final int MAX_EXCHARLOC = 42; - /** * Creates a new JexlException. * @@ -771,7 +770,6 @@ public class JexlException extends RuntimeException { this(info, name, args, null); } - /** * Creates a new Method exception instance. * @@ -1065,7 +1063,6 @@ public class JexlException extends RuntimeException { : new JexlException.TryFailed(xinvoke); // fail } - /** * Detailed info message about this error. * Format is "debug![begin,end]: string \n msg" where: diff --git a/src/main/java/org/apache/commons/jexl3/JexlFeatures.java b/src/main/java/org/apache/commons/jexl3/JexlFeatures.java index 805cdf36..4cee5a7d 100644 --- a/src/main/java/org/apache/commons/jexl3/JexlFeatures.java +++ b/src/main/java/org/apache/commons/jexl3/JexlFeatures.java @@ -792,7 +792,6 @@ public final class JexlFeatures { return getFeature(IMPORT_PRAGMA); } - /** * Sets whether annotation constructs are enabled. * <p> @@ -857,7 +856,6 @@ public final class JexlFeatures { return this; } - /** @return whether lexical scope feature is enabled */ public boolean isLexical() { return getFeature(LEXICAL); @@ -877,7 +875,6 @@ public final class JexlFeatures { return this; } - /** @return whether lexical shade feature is enabled */ public boolean isLexicalShade() { return getFeature(LEXICAL_SHADE); diff --git a/src/main/java/org/apache/commons/jexl3/internal/Debugger.java b/src/main/java/org/apache/commons/jexl3/internal/Debugger.java index 3889e131..8cbd5a41 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/Debugger.java +++ b/src/main/java/org/apache/commons/jexl3/internal/Debugger.java @@ -16,7 +16,6 @@ */ package org.apache.commons.jexl3.internal; - import java.util.Collections; import java.util.Map; import java.util.Set; @@ -435,7 +434,6 @@ public class Debugger extends ParserVisitor implements JexlInfo.Detail { return value; } - /** * Checks if a terminal node is the cause to debug & adds its representation to the rebuilt expression. * @param node the child node @@ -743,7 +741,6 @@ public class Debugger extends ParserVisitor implements JexlInfo.Detail { return check(node, "break", data); } - @Override protected Object visit(final ASTForeachStatement node, final Object data) { final int form = node.getLoopForm(); diff --git a/src/main/java/org/apache/commons/jexl3/internal/Engine.java b/src/main/java/org/apache/commons/jexl3/internal/Engine.java index 7153f827..83e826c3 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/Engine.java +++ b/src/main/java/org/apache/commons/jexl3/internal/Engine.java @@ -244,7 +244,6 @@ public class Engine extends JexlEngine { } } - /** * Gets the default instance of Uberspect. * <p>This is lazily initialized to avoid building a default instance if there diff --git a/src/main/java/org/apache/commons/jexl3/internal/Engine32.java b/src/main/java/org/apache/commons/jexl3/internal/Engine32.java index 8391a2e7..e5c0c4bc 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/Engine32.java +++ b/src/main/java/org/apache/commons/jexl3/internal/Engine32.java @@ -16,7 +16,6 @@ */ package org.apache.commons.jexl3.internal; - import org.apache.commons.jexl3.JexlBuilder; import org.apache.commons.jexl3.JexlContext; import org.apache.commons.jexl3.JexlOptions; diff --git a/src/main/java/org/apache/commons/jexl3/internal/IntegerRange.java b/src/main/java/org/apache/commons/jexl3/internal/IntegerRange.java index ce826f9c..10aacb0e 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/IntegerRange.java +++ b/src/main/java/org/apache/commons/jexl3/internal/IntegerRange.java @@ -68,7 +68,6 @@ public abstract class IntegerRange implements Collection<Integer> { return max; } - @Override public int hashCode() { int hash = getClass().hashCode(); diff --git a/src/main/java/org/apache/commons/jexl3/internal/Interpreter.java b/src/main/java/org/apache/commons/jexl3/internal/Interpreter.java index 61b5bed8..4c690273 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/Interpreter.java +++ b/src/main/java/org/apache/commons/jexl3/internal/Interpreter.java @@ -2044,7 +2044,6 @@ public class Interpreter extends InterpreterBase { data = adata; } - @Override public Object call() throws Exception { processed = true; diff --git a/src/main/java/org/apache/commons/jexl3/internal/InterpreterBase.java b/src/main/java/org/apache/commons/jexl3/internal/InterpreterBase.java index 967b393c..b7bd8b6f 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/InterpreterBase.java +++ b/src/main/java/org/apache/commons/jexl3/internal/InterpreterBase.java @@ -16,7 +16,6 @@ */ package org.apache.commons.jexl3.internal; - import java.util.Collection; import java.util.HashMap; import java.util.List; diff --git a/src/main/java/org/apache/commons/jexl3/internal/Scope.java b/src/main/java/org/apache/commons/jexl3/internal/Scope.java index 6c239248..bff7d47d 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/Scope.java +++ b/src/main/java/org/apache/commons/jexl3/internal/Scope.java @@ -349,7 +349,6 @@ public final class Scope { return locals.toArray(new String[0]); } - Scope getParent() { return parent; } diff --git a/src/main/java/org/apache/commons/jexl3/internal/SoftCache.java b/src/main/java/org/apache/commons/jexl3/internal/SoftCache.java index 06d45988..145c4a99 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/SoftCache.java +++ b/src/main/java/org/apache/commons/jexl3/internal/SoftCache.java @@ -173,7 +173,3 @@ public class SoftCache<K, V> implements JexlCache<K, V> { } } - - - - diff --git a/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java b/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java index 5c13f98b..060d0023 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java +++ b/src/main/java/org/apache/commons/jexl3/internal/TemplateDebugger.java @@ -99,7 +99,6 @@ public class TemplateDebugger extends Debugger { return end > 0; } - @Override protected Object visit(final ASTBlock node, final Object data) { // if not really a template, must use super impl diff --git a/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java b/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java index 1504123b..5d74b16d 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java +++ b/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java @@ -126,8 +126,6 @@ public final class TemplateEngine extends JxltEngine { } } - - /** * A helper class to build expressions. * Keeps count of sub-expressions by type. @@ -688,7 +686,6 @@ public final class TemplateEngine extends JxltEngine { } } - @Override public JxltEngine.Expression createExpression(final JexlInfo jexlInfo, final String expression) { final JexlInfo info = jexlInfo == null ? jexl.createInfo() : jexlInfo; diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/EnumerationIterator.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/EnumerationIterator.java index d4d1af94..7d5523f5 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/EnumerationIterator.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/EnumerationIterator.java @@ -17,7 +17,6 @@ package org.apache.commons.jexl3.internal.introspection; - import java.util.Enumeration; import java.util.Iterator; diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/IndexedType.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/IndexedType.java index 61798247..7e67e1fe 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/IndexedType.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/IndexedType.java @@ -17,7 +17,6 @@ package org.apache.commons.jexl3.internal.introspection; - import java.beans.IntrospectionException; import java.lang.reflect.Method; diff --git a/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java b/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java index 8ead74a3..b383113f 100644 --- a/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java +++ b/src/main/java/org/apache/commons/jexl3/internal/introspection/MethodExecutor.java @@ -110,7 +110,6 @@ public final class MethodExecutor extends AbstractExecutor.Method { return JexlEngine.TRY_FAILED; } - /** * Reassembles arguments if the method is a vararg method. * @param args The actual arguments being passed to this method @@ -155,4 +154,3 @@ public final class MethodExecutor extends AbstractExecutor.Method { } } - diff --git a/src/main/java/org/apache/commons/jexl3/introspection/JexlUberspect.java b/src/main/java/org/apache/commons/jexl3/introspection/JexlUberspect.java index b91c152d..172e060c 100644 --- a/src/main/java/org/apache/commons/jexl3/introspection/JexlUberspect.java +++ b/src/main/java/org/apache/commons/jexl3/introspection/JexlUberspect.java @@ -124,7 +124,6 @@ public interface JexlUberspect { JexlResolver.CONTAINER )); - /** * A resolver types list tailored for Maps, favors '[]' over '.'. */ diff --git a/src/main/java/org/apache/commons/jexl3/parser/ASTIdentifierAccess.java b/src/main/java/org/apache/commons/jexl3/parser/ASTIdentifierAccess.java index 2a35c5a2..df135d7a 100644 --- a/src/main/java/org/apache/commons/jexl3/parser/ASTIdentifierAccess.java +++ b/src/main/java/org/apache/commons/jexl3/parser/ASTIdentifierAccess.java @@ -16,7 +16,6 @@ */ package org.apache.commons.jexl3.parser; - /** * Identifiers, variables and registers. */ diff --git a/src/main/java/org/apache/commons/jexl3/parser/JexlParser.java b/src/main/java/org/apache/commons/jexl3/parser/JexlParser.java index 5b6f1147..a5235a53 100644 --- a/src/main/java/org/apache/commons/jexl3/parser/JexlParser.java +++ b/src/main/java/org/apache/commons/jexl3/parser/JexlParser.java @@ -37,7 +37,6 @@ import org.apache.commons.jexl3.JexlInfo; import org.apache.commons.jexl3.internal.LexicalScope; import org.apache.commons.jexl3.internal.Scope; - /** * The base class for parsing, manages the parameter/local variable frame. */ diff --git a/src/main/java/org/apache/commons/jexl3/parser/NumberParser.java b/src/main/java/org/apache/commons/jexl3/parser/NumberParser.java index ecb972b6..2e611928 100644 --- a/src/main/java/org/apache/commons/jexl3/parser/NumberParser.java +++ b/src/main/java/org/apache/commons/jexl3/parser/NumberParser.java @@ -61,7 +61,6 @@ public final class NumberParser implements Serializable { return strb.toString(); } - Class<? extends Number> getLiteralClass() { return clazz; } diff --git a/src/main/java/org/apache/commons/jexl3/parser/TokenMgrException.java b/src/main/java/org/apache/commons/jexl3/parser/TokenMgrException.java index f1cb981a..34df8a66 100644 --- a/src/main/java/org/apache/commons/jexl3/parser/TokenMgrException.java +++ b/src/main/java/org/apache/commons/jexl3/parser/TokenMgrException.java @@ -92,7 +92,6 @@ public class TokenMgrException extends RuntimeException implements JavaccError { + "after : " + StringParser.escapeString(after, '"'); } - /** Constructor with message and reason. */ public TokenMgrException(final String message, final int reason) { super(message); diff --git a/src/main/java/org/apache/commons/jexl3/scripting/JexlScriptEngine.java b/src/main/java/org/apache/commons/jexl3/scripting/JexlScriptEngine.java index 48d1f390..d135b032 100644 --- a/src/main/java/org/apache/commons/jexl3/scripting/JexlScriptEngine.java +++ b/src/main/java/org/apache/commons/jexl3/scripting/JexlScriptEngine.java @@ -134,7 +134,6 @@ public class JexlScriptEngine extends AbstractScriptEngine implements Compilable return engine; } - /** The logger. */ static final Log LOG = LogFactory.getLog(JexlScriptEngine.class); @@ -256,7 +255,6 @@ public class JexlScriptEngine extends AbstractScriptEngine implements Compilable } } - /** * Create a scripting engine using the supplied factory. * diff --git a/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java b/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java index 7f92e95c..a2cc3618 100644 --- a/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java +++ b/src/test/java/org/apache/commons/jexl3/ArithmeticTest.java @@ -346,7 +346,6 @@ public class ArithmeticTest extends JexlTestCase { private final Asserter asserter; - private final JexlArithmetic jexla; private final JexlArithmetic jexlb; diff --git a/src/test/java/org/apache/commons/jexl3/ArrayAccessTest.java b/src/test/java/org/apache/commons/jexl3/ArrayAccessTest.java index e4066dea..879f2b25 100644 --- a/src/test/java/org/apache/commons/jexl3/ArrayAccessTest.java +++ b/src/test/java/org/apache/commons/jexl3/ArrayAccessTest.java @@ -25,7 +25,6 @@ import org.apache.commons.jexl3.junit.Asserter; import org.junit.Before; import org.junit.Test; - /** * Tests for array access operator [] * @@ -283,7 +282,6 @@ public class ArrayAccessTest extends JexlTestCase { asserter.assertExpression("foo.'0'.'1' = 'three'", "three"); asserter.assertExpression("foo.'0'.'1'", "three"); - foo[0][0] = "one"; foo[0][1] = "two"; asserter.assertExpression("foo.0.1", "two"); diff --git a/src/test/java/org/apache/commons/jexl3/CacheTest.java b/src/test/java/org/apache/commons/jexl3/CacheTest.java index f3618739..9ab96551 100644 --- a/src/test/java/org/apache/commons/jexl3/CacheTest.java +++ b/src/test/java/org/apache/commons/jexl3/CacheTest.java @@ -278,7 +278,6 @@ public class CacheTest extends JexlTestCase { } } - public static class Cached3 extends java.util.TreeMap<String, Object> { private static final long serialVersionUID = 1L; boolean flag = false; diff --git a/src/test/java/org/apache/commons/jexl3/CollectionLiteralTest.java b/src/test/java/org/apache/commons/jexl3/CollectionLiteralTest.java index 88756204..5342dca8 100644 --- a/src/test/java/org/apache/commons/jexl3/CollectionLiteralTest.java +++ b/src/test/java/org/apache/commons/jexl3/CollectionLiteralTest.java @@ -56,7 +56,6 @@ public class CollectionLiteralTest extends JexlTestCase { } } - static class CountingArrayBuilder extends ArrayBuilder { final AtomicInteger count; diff --git a/src/test/java/org/apache/commons/jexl3/ConcurrentCache.java b/src/test/java/org/apache/commons/jexl3/ConcurrentCache.java index 6806d87c..4a3297d3 100644 --- a/src/test/java/org/apache/commons/jexl3/ConcurrentCache.java +++ b/src/test/java/org/apache/commons/jexl3/ConcurrentCache.java @@ -46,4 +46,3 @@ public class ConcurrentCache<K, V> extends SoftCache<K, V> { } } - diff --git a/src/test/java/org/apache/commons/jexl3/DoWhileTest.java b/src/test/java/org/apache/commons/jexl3/DoWhileTest.java index fed77a65..c423f375 100644 --- a/src/test/java/org/apache/commons/jexl3/DoWhileTest.java +++ b/src/test/java/org/apache/commons/jexl3/DoWhileTest.java @@ -152,7 +152,6 @@ public class DoWhileTest extends JexlTestCase { o = e.execute(jc); Assert.assertEquals(23, o); - jc.set("x", 1); e = JEXL.createScript("do x += 1; while (x < 23); return 42;"); o = e.execute(jc); diff --git a/src/test/java/org/apache/commons/jexl3/FeaturesTest.java b/src/test/java/org/apache/commons/jexl3/FeaturesTest.java index b05e655d..7b1675d4 100644 --- a/src/test/java/org/apache/commons/jexl3/FeaturesTest.java +++ b/src/test/java/org/apache/commons/jexl3/FeaturesTest.java @@ -279,7 +279,6 @@ public class FeaturesTest extends JexlTestCase { checkFeature(f, scripts); } - @Test public void testNoLoop() throws Exception { final JexlFeatures f = new JexlFeatures().loops(false); diff --git a/src/test/java/org/apache/commons/jexl3/Foo.java b/src/test/java/org/apache/commons/jexl3/Foo.java index 9f17f2d8..59278401 100644 --- a/src/test/java/org/apache/commons/jexl3/Foo.java +++ b/src/test/java/org/apache/commons/jexl3/Foo.java @@ -113,7 +113,6 @@ public class Foo { return true; } - public String repeat(final String str) { return "Repeat : " + str; } diff --git a/src/test/java/org/apache/commons/jexl3/IfTest.java b/src/test/java/org/apache/commons/jexl3/IfTest.java index b65ce1f4..167d7422 100644 --- a/src/test/java/org/apache/commons/jexl3/IfTest.java +++ b/src/test/java/org/apache/commons/jexl3/IfTest.java @@ -317,7 +317,6 @@ public class IfTest extends JexlTestCase { } } - /** * Ternary operator condition undefined or null evaluates to false * independently of engine flags; same for null coalescing operator. diff --git a/src/test/java/org/apache/commons/jexl3/Issues100Test.java b/src/test/java/org/apache/commons/jexl3/Issues100Test.java index 96ab7df9..90fb9222 100644 --- a/src/test/java/org/apache/commons/jexl3/Issues100Test.java +++ b/src/test/java/org/apache/commons/jexl3/Issues100Test.java @@ -92,7 +92,6 @@ public class Issues100Test extends JexlTestCase { } } - public static class C192 { public static Integer callme(final Integer n) { if (n == null) { diff --git a/src/test/java/org/apache/commons/jexl3/Issues200Test.java b/src/test/java/org/apache/commons/jexl3/Issues200Test.java index 1478725c..1e79cec0 100644 --- a/src/test/java/org/apache/commons/jexl3/Issues200Test.java +++ b/src/test/java/org/apache/commons/jexl3/Issues200Test.java @@ -16,7 +16,6 @@ */ package org.apache.commons.jexl3; - import java.io.StringReader; import java.util.ArrayList; import java.util.Arrays; @@ -246,12 +245,10 @@ public class Issues200Test extends JexlTestCase { pool.submit(() -> script.execute(new MapContext(payload))); } - public Issues200Test() { super("Issues200Test", null); } - @Before @Override public void setUp() throws Exception { @@ -345,7 +342,6 @@ public class Issues200Test extends JexlTestCase { Assert.assertNull("oob adverted", r); } - @Test public void test221() throws Exception { final JexlEvalContext jc = new JexlEvalContext(); @@ -450,7 +446,6 @@ public class Issues200Test extends JexlTestCase { Assert.assertEquals(Double.doubleToLongBits(e) + " != " + Double.doubleToLongBits(c), a + b, e, 0.0); } - @Test public void test243a() throws Exception { final JexlEngine jexl = new JexlBuilder().cache(32).create(); @@ -554,7 +549,6 @@ public class Issues200Test extends JexlTestCase { Assert.assertEquals(42, result); } - @Test public void test266() throws Exception { Object result; diff --git a/src/test/java/org/apache/commons/jexl3/Issues300Test.java b/src/test/java/org/apache/commons/jexl3/Issues300Test.java index a6ce39d3..e89e46f1 100644 --- a/src/test/java/org/apache/commons/jexl3/Issues300Test.java +++ b/src/test/java/org/apache/commons/jexl3/Issues300Test.java @@ -207,7 +207,6 @@ public class Issues300Test { ); } - private Object run361a(final JexlEngine jexl) { final String src = "()-> { ()-> { if (versionFile != null) { return 'foo'; } else { return 'bar'; }} }"; final JexlScript script = jexl.createScript(src); @@ -387,7 +386,6 @@ public class Issues300Test { Assert.assertEquals(2, o2); } - @Test public void test306c() { final JexlEngine jexl = new JexlBuilder().safe(true).create(); @@ -762,7 +760,6 @@ public class Issues300Test { Assert.assertTrue(result.toString().contains("\n")); } - @Test public void test347() { final String src = "A.B == 5"; @@ -850,7 +847,6 @@ public class Issues300Test { } } - @Test public void test361c_32() { final JexlEngine jexl = new Engine32(new JexlBuilder().safe(false).strict(false)); diff --git a/src/test/java/org/apache/commons/jexl3/Issues400Test.java b/src/test/java/org/apache/commons/jexl3/Issues400Test.java index f151fd35..c11b28c4 100644 --- a/src/test/java/org/apache/commons/jexl3/Issues400Test.java +++ b/src/test/java/org/apache/commons/jexl3/Issues400Test.java @@ -232,7 +232,6 @@ public class Issues400Test { Assert.assertEquals(0d, result.doubleValue(), 3.e-32); } - @Test public void test412() { final Map<Object, Object> ctl = new HashMap<>(); diff --git a/src/test/java/org/apache/commons/jexl3/JXLTTest.java b/src/test/java/org/apache/commons/jexl3/JXLTTest.java index bad6feaa..c94d28b9 100644 --- a/src/test/java/org/apache/commons/jexl3/JXLTTest.java +++ b/src/test/java/org/apache/commons/jexl3/JXLTTest.java @@ -142,7 +142,6 @@ public class JXLTTest extends JexlTestCase { new JexlBuilder().silent(false).cache(128).strict(true)); } - private static String refactor(final TemplateDebugger td, final JxltEngine.Template ts) { final boolean dbg = td.debug(ts); if (dbg) { diff --git a/src/test/java/org/apache/commons/jexl3/LexicalTest.java b/src/test/java/org/apache/commons/jexl3/LexicalTest.java index 9403cb22..6a5549a8 100644 --- a/src/test/java/org/apache/commons/jexl3/LexicalTest.java +++ b/src/test/java/org/apache/commons/jexl3/LexicalTest.java @@ -872,7 +872,6 @@ public class LexicalTest { Assert.assertEquals(0, o); } - @Test public void testLexical6d() { final String str = "i = 0; for (var i : [42]) i; i"; diff --git a/src/test/java/org/apache/commons/jexl3/MethodTest.java b/src/test/java/org/apache/commons/jexl3/MethodTest.java index abb14d40..919d229b 100644 --- a/src/test/java/org/apache/commons/jexl3/MethodTest.java +++ b/src/test/java/org/apache/commons/jexl3/MethodTest.java @@ -857,5 +857,4 @@ public class MethodTest extends JexlTestCase { Assert.assertEquals(42, jexl.createScript("zzzz(4)").execute(zjc)); } - } diff --git a/src/test/java/org/apache/commons/jexl3/PragmaTest.java b/src/test/java/org/apache/commons/jexl3/PragmaTest.java index 95ba9068..2e535179 100644 --- a/src/test/java/org/apache/commons/jexl3/PragmaTest.java +++ b/src/test/java/org/apache/commons/jexl3/PragmaTest.java @@ -240,7 +240,6 @@ public class PragmaTest extends JexlTestCase { Assert.assertEquals(src, parsed); } - @Test @SuppressWarnings("AssertEqualsBetweenInconvertibleTypes") public void testJxltPragmas() { diff --git a/src/test/java/org/apache/commons/jexl3/PropertyAccessTest.java b/src/test/java/org/apache/commons/jexl3/PropertyAccessTest.java index 3af4a09e..dbf9eecd 100644 --- a/src/test/java/org/apache/commons/jexl3/PropertyAccessTest.java +++ b/src/test/java/org/apache/commons/jexl3/PropertyAccessTest.java @@ -28,7 +28,6 @@ import org.junit.Assert; import org.junit.Before; import org.junit.Test; - /** * Tests for property access operator '.' * @since 3.0 @@ -173,7 +172,6 @@ public class PropertyAccessTest extends JexlTestCase { } } - private Asserter asserter; public PropertyAccessTest() { @@ -251,7 +249,6 @@ public class PropertyAccessTest extends JexlTestCase { } } - @Test public void test275a() throws Exception { final JexlEngine jexl = new JexlBuilder().strict(true).safe(false).create(); @@ -318,7 +315,6 @@ public class PropertyAccessTest extends JexlTestCase { result = script.execute(ctxt, "stuff"); Assert.assertEquals(42, result); - // unprotected navigation script = jexl.createScript("$in.`${p}`.intValue()", "p"); result = script.execute(ctxt, "fail"); diff --git a/src/test/java/org/apache/commons/jexl3/ScriptTest.java b/src/test/java/org/apache/commons/jexl3/ScriptTest.java index 509fe2ee..cb324358 100644 --- a/src/test/java/org/apache/commons/jexl3/ScriptTest.java +++ b/src/test/java/org/apache/commons/jexl3/ScriptTest.java @@ -144,7 +144,6 @@ public class ScriptTest extends JexlTestCase { return response.toString(); } - /** * Create a new test case. */ diff --git a/src/test/java/org/apache/commons/jexl3/SideEffectTest.java b/src/test/java/org/apache/commons/jexl3/SideEffectTest.java index 8c4503ec..e9f47031 100644 --- a/src/test/java/org/apache/commons/jexl3/SideEffectTest.java +++ b/src/test/java/org/apache/commons/jexl3/SideEffectTest.java @@ -33,7 +33,6 @@ import org.junit.Assert; import org.junit.Before; import org.junit.Test; - /** * Tests for array access operator [] * @@ -470,7 +469,6 @@ public class SideEffectTest extends JexlTestCase { run246(new Arithmetic246b(true)); } - @Test public void test248() throws Exception { final MapContext ctx = new MapContext(); diff --git a/src/test/java/org/apache/commons/jexl3/SynchronizedArithmetic.java b/src/test/java/org/apache/commons/jexl3/SynchronizedArithmetic.java index fb65824c..09b48354 100644 --- a/src/test/java/org/apache/commons/jexl3/SynchronizedArithmetic.java +++ b/src/test/java/org/apache/commons/jexl3/SynchronizedArithmetic.java @@ -117,7 +117,6 @@ public class SynchronizedArithmetic extends JexlArithmetic { } } - /** * An iterator that implements Closeable (at least implements a close method) * and uses monitors to protect iteration. diff --git a/src/test/java/org/apache/commons/jexl3/SynchronizedOverloadsTest.java b/src/test/java/org/apache/commons/jexl3/SynchronizedOverloadsTest.java index e31fd9dd..1329c25a 100644 --- a/src/test/java/org/apache/commons/jexl3/SynchronizedOverloadsTest.java +++ b/src/test/java/org/apache/commons/jexl3/SynchronizedOverloadsTest.java @@ -23,7 +23,6 @@ import org.junit.Assert; import org.junit.Before; import org.junit.Test; - /** * Test cases for synchronized calls. * <p>May be a base for synchronized calls. @@ -41,7 +40,6 @@ public class SynchronizedOverloadsTest extends JexlTestCase { java.util.logging.Logger.getLogger(JexlEngine.class.getName()).setLevel(java.util.logging.Level.SEVERE); } - @Test public void testSynchronized() throws Exception { final Map<String, Object> ns = new TreeMap<>(); diff --git a/src/test/java/org/apache/commons/jexl3/VarTest.java b/src/test/java/org/apache/commons/jexl3/VarTest.java index e420c7f4..fe83e9bd 100644 --- a/src/test/java/org/apache/commons/jexl3/VarTest.java +++ b/src/test/java/org/apache/commons/jexl3/VarTest.java @@ -442,7 +442,6 @@ public class VarTest extends JexlTestCase { expect = mkref(new String[][]{{"e"},{"f"}}); Assert.assertTrue(eq(expect, vars)); - e = JEXL.createScript("e[f][g]"); vars = e.getVariables(); expect = mkref(new String[][]{{"e"},{"f"},{"g"}}); diff --git a/src/test/java/org/apache/commons/jexl3/examples/AbstractOutput.java b/src/test/java/org/apache/commons/jexl3/examples/AbstractOutput.java index f368a057..f824296b 100644 --- a/src/test/java/org/apache/commons/jexl3/examples/AbstractOutput.java +++ b/src/test/java/org/apache/commons/jexl3/examples/AbstractOutput.java @@ -51,7 +51,6 @@ public abstract class AbstractOutput { // nothing to do } - /** * Outputs the actual and value or checks the actual equals the expected value. * @param expr the message to output diff --git a/src/test/java/org/apache/commons/jexl3/examples/MethodPropertyTest.java b/src/test/java/org/apache/commons/jexl3/examples/MethodPropertyTest.java index ba4ba70e..ec3a7970 100644 --- a/src/test/java/org/apache/commons/jexl3/examples/MethodPropertyTest.java +++ b/src/test/java/org/apache/commons/jexl3/examples/MethodPropertyTest.java @@ -115,7 +115,6 @@ public class MethodPropertyTest { } - /** * Command line entry point. * @param args command line arguments diff --git a/src/test/java/org/apache/commons/jexl3/internal/introspection/NoJexlTest.java b/src/test/java/org/apache/commons/jexl3/internal/introspection/NoJexlTest.java index 66a56e54..7cd86889 100644 --- a/src/test/java/org/apache/commons/jexl3/internal/introspection/NoJexlTest.java +++ b/src/test/java/org/apache/commons/jexl3/internal/introspection/NoJexlTest.java @@ -48,7 +48,6 @@ public class NoJexlTest { @Override public int method() { return 2; } } - @NoJexl public static class A2 extends A { public A2() {} diff --git a/src/test/java/org/apache/commons/jexl3/internal/introspection/PermissionsTest.java b/src/test/java/org/apache/commons/jexl3/internal/introspection/PermissionsTest.java index 5d3bf1e2..62e88ec1 100644 --- a/src/test/java/org/apache/commons/jexl3/internal/introspection/PermissionsTest.java +++ b/src/test/java/org/apache/commons/jexl3/internal/introspection/PermissionsTest.java @@ -41,14 +41,12 @@ import org.apache.commons.jexl3.introspection.JexlUberspect; import org.junit.Assert; import org.junit.Test; - /** * Checks the CacheMap.MethodKey implementation */ public class PermissionsTest { - public static class A { public int i; public A() {} @@ -331,7 +329,6 @@ public class PermissionsTest { runTestPermissions(permissions0()); } - @Test public void testPermissions1() throws Exception { runTestPermissions(new JexlPermissions.Delegate(permissions0()) { diff --git a/src/test/java/org/apache/commons/jexl3/internal/introspection/nojexlpackage/package-info.java b/src/test/java/org/apache/commons/jexl3/internal/introspection/nojexlpackage/package-info.java index 0c8e112c..084a1eed 100644 --- a/src/test/java/org/apache/commons/jexl3/internal/introspection/nojexlpackage/package-info.java +++ b/src/test/java/org/apache/commons/jexl3/internal/introspection/nojexlpackage/package-info.java @@ -18,4 +18,3 @@ package org.apache.commons.jexl3.internal.introspection.nojexlpackage; import org.apache.commons.jexl3.annotations.NoJexl; - diff --git a/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java b/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java index 98e0602a..3a84522f 100644 --- a/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java +++ b/src/test/java/org/apache/commons/jexl3/introspection/SandboxTest.java @@ -72,7 +72,6 @@ public class SandboxTest extends JexlTestCase { } } - @NoJexl public interface CantCallMe { void tryMe(); diff --git a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceGetExecutor.java b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceGetExecutor.java index 3cb2f880..39c1720d 100644 --- a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceGetExecutor.java +++ b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceGetExecutor.java @@ -19,7 +19,6 @@ package org.apache.commons.jexl3.jexl342; import org.apache.commons.jexl3.JexlEngine; import org.apache.commons.jexl3.introspection.JexlPropertyGet; - /** * Wraps a reference or optional property get executor. */ diff --git a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceMethodExecutor.java b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceMethodExecutor.java index ec4f196f..5a3dd674 100644 --- a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceMethodExecutor.java +++ b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceMethodExecutor.java @@ -20,7 +20,6 @@ import org.apache.commons.jexl3.JexlEngine; import org.apache.commons.jexl3.JexlException; import org.apache.commons.jexl3.introspection.JexlMethod; - /** * Wraps a reference or optional method executor. */ diff --git a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceSetExecutor.java b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceSetExecutor.java index 8ee8d5e1..088a540e 100644 --- a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceSetExecutor.java +++ b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceSetExecutor.java @@ -20,7 +20,6 @@ import org.apache.commons.jexl3.JexlEngine; import org.apache.commons.jexl3.JexlException; import org.apache.commons.jexl3.introspection.JexlPropertySet; - /** * Wraps a reference or optional property set executor. */ diff --git a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceUberspect.java b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceUberspect.java index c3d3b5f7..8870822e 100644 --- a/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceUberspect.java +++ b/src/test/java/org/apache/commons/jexl3/jexl342/ReferenceUberspect.java @@ -354,7 +354,6 @@ public class ReferenceUberspect implements JexlUberspect { return pojoStrategy; } - @Override public int getVersion() { return uberspect.getVersion(); diff --git a/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java b/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java index 825210ee..d9721a7f 100644 --- a/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java +++ b/src/test/java/org/apache/commons/jexl3/scripting/JexlScriptEngineTest.java @@ -265,7 +265,6 @@ public class JexlScriptEngineTest { Assert.assertEquals(System.class,engine.eval("JEXL.System")); } - @Test public void testScriptingGetBy() throws Exception { final ScriptEngineManager manager = new ScriptEngineManager();