(commons-email) branch master updated: Use try-with-resources

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git


The following commit(s) were added to refs/heads/master by this push:
     new 1675cfc  Use try-with-resources
1675cfc is described below

commit 1675cfc3c4cea4adef08984a427107952b79e054
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Fri Dec 15 15:57:45 2023 -0500

    Use try-with-resources
---
 .../org/apache/commons/mail/EmailLiveTest.java     | 39 +++++++++++-----------
 1 file changed, 19 insertions(+), 20 deletions(-)

diff --git a/src/test/java/org/apache/commons/mail/EmailLiveTest.java 
b/src/test/java/org/apache/commons/mail/EmailLiveTest.java
index d90eed4..3155f91 100644
--- a/src/test/java/org/apache/commons/mail/EmailLiveTest.java
+++ b/src/test/java/org/apache/commons/mail/EmailLiveTest.java
@@ -316,29 +316,28 @@ public class EmailLiveTest extends AbstractEmailTest {
 
         // we need to instantiate an email to provide the mail session - a bit 
ugly
         final Session session = create(SimpleEmail.class).getMailSession();
-        final Transport transport = session.getTransport();
-
-        // simulate creating a bunch of emails using an existing mail session
-        for (int i = 0; i < 3; i++) {
-            final SimpleEmail personalizedEmail = (SimpleEmail) 
create(SimpleEmail.class);
-            personalizedEmail.setMailSession(session);
-            personalizedEmail.setSubject("Personalized Test Mail Nr. " + i);
-            personalizedEmail.setMsg("This is a personalized test mail ... 
:-)");
-            personalizedEmail.buildMimeMessage();
-            emails.add(personalizedEmail);
-        }
+        try (Transport transport = session.getTransport()) {
+
+            // simulate creating a bunch of emails using an existing mail 
session
+            for (int i = 0; i < 3; i++) {
+                final SimpleEmail personalizedEmail = (SimpleEmail) 
create(SimpleEmail.class);
+                personalizedEmail.setMailSession(session);
+                personalizedEmail.setSubject("Personalized Test Mail Nr. " + 
i);
+                personalizedEmail.setMsg("This is a personalized test mail ... 
:-)");
+                personalizedEmail.buildMimeMessage();
+                emails.add(personalizedEmail);
+            }
 
-        // send the list of emails using a single 'Transport' instance.
-        if (EmailConfiguration.MAIL_FORCE_SEND) {
-            transport.connect();
+            // send the list of emails using a single 'Transport' instance.
+            if (EmailConfiguration.MAIL_FORCE_SEND) {
+                transport.connect();
 
-            for (final SimpleEmail personalizedEmail : emails) {
-                final MimeMessage mimeMessage = 
personalizedEmail.getMimeMessage();
-                Transport.send(mimeMessage);
-                System.out.println("Successfully sent the following email : " 
+ mimeMessage.getMessageID());
+                for (final SimpleEmail personalizedEmail : emails) {
+                    final MimeMessage mimeMessage = 
personalizedEmail.getMimeMessage();
+                    Transport.send(mimeMessage);
+                    System.out.println("Successfully sent the following email 
: " + mimeMessage.getMessageID());
+                }
             }
-
-            transport.close();
         }
     }