Author: sebb
Date: Wed Mar 31 00:20:49 2010
New Revision: 929344
URL: http://svn.apache.org/viewvc?rev=929344&view=rev
Log:
StringBuffer => StringBuilder for local variables
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/examples/nntp/NNTPUtils.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/bsd/RExecClient.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/daytime/DaytimeTCPClient.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/finger/FingerClient.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTP.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NNTP.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewGroupsOrNewsQuery.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewsgroupInfo.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/SimpleNNTPHeader.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpUtils.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3Client.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/RelayPath.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/SimpleSMTPHeader.java
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/examples/nntp/NNTPUtils.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/examples/nntp/NNTPUtils.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/examples/nntp/NNTPUtils.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/examples/nntp/NNTPUtils.java
Wed Mar 31 00:20:49 2010
@@ -99,10 +99,8 @@ public class NNTPUtils {
*/
public static String readerToString(Reader reader) {
String temp = null;
- StringBuffer sb = null;
BufferedReader bufReader = new BufferedReader(reader);
-
- sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
try {
temp = bufReader.readLine();
while (temp != null) {
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/bsd/RExecClient.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/bsd/RExecClient.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/bsd/RExecClient.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/bsd/RExecClient.java
Wed Mar 31 00:20:49 2010
@@ -222,7 +222,7 @@ public class RExecClient extends SocketC
ch = _input_.read();
if (ch > 0)
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
while ((ch = _input_.read()) != -1 && ch != '\n')
buffer.append((char)ch);
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/daytime/DaytimeTCPClient.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/daytime/DaytimeTCPClient.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/daytime/DaytimeTCPClient.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/daytime/DaytimeTCPClient.java
Wed Mar 31 00:20:49 2010
@@ -72,7 +72,7 @@ public final class DaytimeTCPClient exte
public String getTime() throws IOException
{
int read;
- StringBuffer result = new StringBuffer(__buffer.length);
+ StringBuilder result = new StringBuilder(__buffer.length);
BufferedReader reader;
reader = new BufferedReader(new InputStreamReader(_input_));
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/finger/FingerClient.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/finger/FingerClient.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/finger/FingerClient.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/finger/FingerClient.java
Wed Mar 31 00:20:49 2010
@@ -86,7 +86,7 @@ public class FingerClient extends Socket
public String query(boolean longOutput, String username) throws IOException
{
int read;
- StringBuffer result = new StringBuffer(__buffer.length);
+ StringBuilder result = new StringBuilder(__buffer.length);
BufferedReader input;
input =
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTP.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTP.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTP.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTP.java
Wed Mar 31 00:20:49 2010
@@ -845,7 +845,7 @@ public class FTP extends SocketClient
public int port(InetAddress host, int port) throws IOException
{
int num;
- StringBuffer info = new StringBuffer(24);
+ StringBuilder info = new StringBuilder(24);
info.append(host.getHostAddress().replace('.', ','));
num = port >>> 8;
@@ -886,7 +886,7 @@ public class FTP extends SocketClient
public int eprt(InetAddress host, int port) throws IOException
{
int num;
- StringBuffer info = new StringBuffer();
+ StringBuilder info = new StringBuilder();
String h;
// If IPv6, trim the zone index
@@ -969,7 +969,7 @@ public class FTP extends SocketClient
*/
public int type(int fileType, int formatOrByteSize) throws IOException
{
- StringBuffer arg = new StringBuffer();
+ StringBuilder arg = new StringBuilder();
arg.append(__modes.charAt(fileType));
arg.append(' ');
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/FTPClient.java
Wed Mar 31 00:20:49 2010
@@ -2459,7 +2459,7 @@ implements Configurable
{
if (pathname != null)
{
- StringBuffer sb = new StringBuffer(pathname.length() + 3);
+ StringBuilder sb = new StringBuilder(pathname.length() + 3);
sb.append("-a ");
sb.append(pathname);
return sb.toString();
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/RegexFTPFileEntryParserImpl.java
Wed Mar 31 00:20:49 2010
@@ -127,7 +127,7 @@ public abstract class RegexFTPFileEntryP
*/
public String getGroupsAsString() {
- StringBuffer b = new StringBuffer();
+ StringBuilder b = new StringBuilder();
for (int i = 1; i <= this.result.groupCount(); i++) {
b.append(i).append(") ").append(this.result.group(i)).append(
System.getProperty("line.separator"));
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java
Wed Mar 31 00:20:49 2010
@@ -240,7 +240,7 @@ public class VMSFTPEntryParser extends C
public String readNextEntry(BufferedReader reader) throws IOException
{
String line = reader.readLine();
- StringBuffer entry = new StringBuffer();
+ StringBuilder entry = new StringBuilder();
while (line != null)
{
if (line.startsWith("Directory") || line.startsWith("Total")) {
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NNTP.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NNTP.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NNTP.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NNTP.java
Wed Mar 31 00:20:49 2010
@@ -790,7 +790,7 @@ public class NNTP extends SocketClient
public int newgroups(String date, String time, boolean GMT,
String distributions) throws IOException
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
buffer.append(date);
buffer.append(' ');
@@ -838,7 +838,7 @@ public class NNTP extends SocketClient
public int newnews(String newsgroups, String date, String time, boolean
GMT,
String distributions) throws IOException
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
buffer.append(newsgroups);
buffer.append(' ');
@@ -991,7 +991,7 @@ public class NNTP extends SocketClient
* command or receiving the server reply.
***/
public int xhdr(String header, String selectedArticles) throws IOException
{
- StringBuffer command = new StringBuffer(header);
+ StringBuilder command = new StringBuilder(header);
command.append(" ");
command.append(selectedArticles);
return sendCommand(NNTPCommand.XHDR, command.toString());
@@ -1007,7 +1007,7 @@ public class NNTP extends SocketClient
* @throws IOException
*/
public int listActive(String wildmat) throws IOException {
- StringBuffer command = new StringBuffer("ACTIVE ");
+ StringBuilder command = new StringBuilder("ACTIVE ");
command.append(wildmat);
return sendCommand(NNTPCommand.LIST, command.toString());
}
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewGroupsOrNewsQuery.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewGroupsOrNewsQuery.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewGroupsOrNewsQuery.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewGroupsOrNewsQuery.java
Wed Mar 31 00:20:49 2010
@@ -60,13 +60,13 @@ public final class NewGroupsOrNewsQuery
{
int num;
String str;
- StringBuffer buffer;
+ StringBuilder buffer;
__distributions = null;
__newsgroups = null;
__isGMT = gmt;
- buffer = new StringBuffer();
+ buffer = new StringBuilder();
// Get year
num = date.get(Calendar.YEAR);
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewsgroupInfo.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewsgroupInfo.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewsgroupInfo.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/NewsgroupInfo.java
Wed Mar 31 00:20:49 2010
@@ -137,7 +137,7 @@ public final class NewsgroupInfo
/*
public String toString() {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
buffer.append(__newsgroup);
buffer.append(' ');
buffer.append(__lastArticle);
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/SimpleNNTPHeader.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/SimpleNNTPHeader.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/SimpleNNTPHeader.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/nntp/SimpleNNTPHeader.java
Wed Mar 31 00:20:49 2010
@@ -146,7 +146,7 @@ public class SimpleNNTPHeader
@Override
public String toString()
{
- StringBuffer header = new StringBuffer();
+ StringBuilder header = new StringBuilder();
header.append("From: ");
header.append(__from);
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpUtils.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpUtils.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpUtils.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/NtpUtils.java
Wed Mar 31 00:20:49 2010
@@ -67,7 +67,7 @@ public final class NtpUtils {
int refId = message.getReferenceId();
if (refId == 0)
return "";
- StringBuffer buf = new StringBuffer(4);
+ StringBuilder buf = new StringBuilder(4);
// start at highest-order byte (0x4c434c00 -> LCL)
for (int shiftBits = 24; shiftBits >= 0; shiftBits -= 8)
{
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/TimeStamp.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/ntp/TimeStamp.java
Wed Mar 31 00:20:49 2010
@@ -360,10 +360,10 @@ public class TimeStamp implements java.i
/***
* Left-pad 8-character hex string with 0's
*
- * @param buf - StringBuffer which is appended with leading 0's.
+ * @param buf - StringBuilder which is appended with leading 0's.
* @param l - a long.
*/
- private static void appendHexString(StringBuffer buf, long l)
+ private static void appendHexString(StringBuilder buf, long l)
{
String s = Long.toHexString(l);
for (int i = s.length(); i < 8; i++)
@@ -382,7 +382,7 @@ public class TimeStamp implements java.i
*/
public static String toString(long ntpTime)
{
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
// high-order second bits (32..63) as hexstring
appendHexString(buf, (ntpTime >>> 32) & 0xffffffffL);
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3.java
Wed Mar 31 00:20:49 2010
@@ -342,7 +342,7 @@ public class POP3 extends SocketClient
public String getReplyString()
{
Enumeration<String> en;
- StringBuffer buffer = new StringBuffer(256);
+ StringBuilder buffer = new StringBuilder(256);
en = _replyLines.elements();
while (en.hasMoreElements())
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3Client.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3Client.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3Client.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/pop3/POP3Client.java
Wed Mar 31 00:20:49 2010
@@ -182,7 +182,7 @@ public class POP3Client extends POP3
{
int i;
byte[] digest;
- StringBuffer buffer, digestBuffer;
+ StringBuilder buffer, digestBuffer;
MessageDigest md5;
if (getState() != AUTHORIZATION_STATE)
@@ -191,12 +191,12 @@ public class POP3Client extends POP3
md5 = MessageDigest.getInstance("MD5");
timestamp += secret;
digest = md5.digest(timestamp.getBytes());
- digestBuffer = new StringBuffer(128);
+ digestBuffer = new StringBuilder(128);
for (i = 0; i < digest.length; i++)
digestBuffer.append(Integer.toHexString(digest[i] & 0xff));
- buffer = new StringBuffer(256);
+ buffer = new StringBuilder(256);
buffer.append(username);
buffer.append(' ');
buffer.append(digestBuffer.toString());
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/RelayPath.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/RelayPath.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/RelayPath.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/RelayPath.java
Wed Mar 31 00:20:49 2010
@@ -73,7 +73,7 @@ public final class RelayPath
@Override
public String toString()
{
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
Enumeration<String> hosts;
buffer.append('<');
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/SimpleSMTPHeader.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/SimpleSMTPHeader.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/SimpleSMTPHeader.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/smtp/SimpleSMTPHeader.java
Wed Mar 31 00:20:49 2010
@@ -120,7 +120,7 @@ public class SimpleSMTPHeader
@Override
public String toString()
{
- StringBuffer header = new StringBuffer();
+ StringBuilder header = new StringBuilder();
if (__headerFields.length() > 0)
header.append(__headerFields.toString());
Modified:
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java
URL:
http://svn.apache.org/viewvc/commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java?rev=929344&r1=929343&r2=929344&view=diff
==============================================================================
---
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java
(original)
+++
commons/proper/net/branches/NET_2_0/src/main/java/org/apache/commons/net/tftp/TFTPErrorPacket.java
Wed Mar 31 00:20:49 2010
@@ -108,7 +108,7 @@ public final class TFTPErrorPacket exten
super(TFTPPacket.ERROR, datagram.getAddress(), datagram.getPort());
int index, length;
byte[] data;
- StringBuffer buffer;
+ StringBuilder buffer;
data = datagram.getData();
length = datagram.getLength();
@@ -122,7 +122,7 @@ public final class TFTPErrorPacket exten
throw new TFTPPacketException("Bad error packet. No message.");
index = 4;
- buffer = new StringBuffer();
+ buffer = new StringBuilder();
while (index < length && data[index] != 0)
{
