This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-email.git
The following commit(s) were added to refs/heads/master by this push:
new 4b94173 Javadoc and comments: Use an HTTPS URL
4b94173 is described below
commit 4b94173faf5729c37e722713b5a4768a3ab5ca21
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jan 14 11:06:33 2024 -0500
Javadoc and comments: Use an HTTPS URL
---
.../src/main/java/org/apache/commons/mail2/core/EmailConstants.java | 4 ++--
.../src/main/java/org/apache/commons/mail2/core/EmailUtils.java | 2 +-
.../src/main/java/org/apache/commons/mail2/jakarta/HtmlEmail.java | 2 +-
.../test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java | 2 +-
.../src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java | 4 ++--
.../src/test/java/org/apache/commons/mail2/jakarta/HtmlEmailTest.java | 2 +-
.../src/main/java/org/apache/commons/mail2/javax/HtmlEmail.java | 2 +-
.../test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java | 2 +-
.../test/java/org/apache/commons/mail2/javax/EmailAttachmentTest.java | 2 +-
.../src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java | 4 ++--
.../src/test/java/org/apache/commons/mail2/javax/HtmlEmailTest.java | 2 +-
11 files changed, 14 insertions(+), 14 deletions(-)
diff --git
a/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailConstants.java
b/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailConstants.java
index ffe8c61..38e2e00 100644
---
a/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailConstants.java
+++
b/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailConstants.java
@@ -22,8 +22,8 @@ import java.time.Duration;
/**
* Constants used by Email classes.
*
- * A description of the mail session parameter you find at <a
href="http://java.sun.com/products/javamail/javadocs/com/sun/mail/smtp/package-summary.html">
- *
http://java.sun.com/products/javamail/javadocs/com/sun/mail/smtp/package-summary.html</a>.
+ * A description of the mail session parameter you find at <a
href="https://java.sun.com/products/javamail/javadocs/com/sun/mail/smtp/package-summary.html">
+ *
https://java.sun.com/products/javamail/javadocs/com/sun/mail/smtp/package-summary.html</a>.
*
* @since 1.3
*/
diff --git
a/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailUtils.java
b/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailUtils.java
index 7957a4e..d03c055 100644
---
a/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailUtils.java
+++
b/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailUtils.java
@@ -91,7 +91,7 @@ public final class EmailUtils {
*
* @param input the input string to be URL encoded
* @return a URL encoded string
- * @see <a href="http://tools.ietf.org/html/rfc2392">RFC 2392</a>
+ * @see <a href="https://tools.ietf.org/html/rfc2392">RFC 2392</a>
*/
public static String encodeUrl(final String input) {
if (input == null) {
diff --git
a/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/HtmlEmail.java
b/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/HtmlEmail.java
index 9656f85..f4e6a4b 100644
---
a/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/HtmlEmail.java
+++
b/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/HtmlEmail.java
@@ -222,7 +222,7 @@ public class HtmlEmail extends MultiPartEmail {
// EMAIL-142: if we have both an HTML and TEXT body, but no
attachments or
// inline images, the root container should have mimetype
// "multipart/alternative".
- // reference: http://tools.ietf.org/html/rfc2046#section-5.1.4
+ // reference: https://tools.ietf.org/html/rfc2046#section-5.1.4
if (!EmailUtils.isEmpty(inlineEmbeds) || isBoolHasAttachments()) {
// If both HTML and TEXT bodies are provided, create an
alternative
// container and add it to the root container
diff --git
a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java
b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java
index 40bf41d..5ca8e31 100644
---
a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java
+++
b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java
@@ -102,7 +102,7 @@ public abstract class AbstractEmailTest {
/**
* Create a mocked URL object which always throws an IOException when the
openStream() method is called.
* <p>
- * Several ISPs do resolve invalid URLs like {@code
http://example.invalid} to some error page causing tests to fail otherwise.
+ * Several ISPs do resolve invalid URLs like {@code
https://example.invalid} to some error page causing tests to fail otherwise.
* </p>
*
* @return an invalid URL
diff --git
a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java
b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java
index 8386f63..75ac32b 100644
---
a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java
+++
b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java
@@ -44,7 +44,7 @@ import jakarta.mail.internet.MimeMessage;
* These are regression test sending REAL email to REAL mail servers using
REAL recipients.
*
* The intention is to field-test certain aspects of email using a variety of
mail clients since I'm not a mockist (see
- *
http://martinfowler.com/articles/mocksArentStubs.html#ClassicalAndMockistTesting).
+ *
https://martinfowler.com/articles/mocksArentStubs.html#ClassicalAndMockistTesting).
*/
public class EmailLiveTest extends AbstractEmailTest {
/**
@@ -97,7 +97,7 @@ public class EmailLiveTest extends AbstractEmailTest {
System.setProperty("mail.mime.charset", StandardCharsets.UTF_8.name());
// enforce encoding of non-ASCII characters (violating the MIME
specification - see
- //
http://java.sun.com/products/javamail/javadocs/javax/mail/internet/package-summary.html
+ //
https://java.sun.com/products/javamail/javadocs/javax/mail/internet/package-summary.html
System.setProperty("mail.mime.encodefilename", "true");
}
diff --git
a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/HtmlEmailTest.java
b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/HtmlEmailTest.java
index 034cf28..e15a021 100644
---
a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/HtmlEmailTest.java
+++
b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/HtmlEmailTest.java
@@ -87,7 +87,7 @@ public class HtmlEmailTest extends AbstractEmailTest {
/**
* Create a HTML email containing an URL pointing to a ZIP file to be
downloaded. According to EMAIL-93 the resulting URL
- * "http://paradisedelivery.homeip.net/delivery/?file=TZC268X93337..zip"
contains TWO dots instead of one dot which breaks the link.
+ * "https://paradisedelivery.homeip.net/delivery/?file=TZC268X93337..zip"
contains TWO dots instead of one dot which breaks the link.
*/
@Test
public void testAddZipUrl() throws Exception {
diff --git
a/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/HtmlEmail.java
b/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/HtmlEmail.java
index f558d24..6110ca6 100644
---
a/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/HtmlEmail.java
+++
b/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/HtmlEmail.java
@@ -222,7 +222,7 @@ public class HtmlEmail extends MultiPartEmail {
// EMAIL-142: if we have both an HTML and TEXT body, but no
attachments or
// inline images, the root container should have mimetype
// "multipart/alternative".
- // reference: http://tools.ietf.org/html/rfc2046#section-5.1.4
+ // reference: https://tools.ietf.org/html/rfc2046#section-5.1.4
if (!EmailUtils.isEmpty(inlineEmbeds) || isBoolHasAttachments()) {
// If both HTML and TEXT bodies are provided, create an
alternative
// container and add it to the root container
diff --git
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java
index 3a9eec8..a20dc28 100644
---
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java
+++
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java
@@ -102,7 +102,7 @@ public abstract class AbstractEmailTest {
/**
* Create a mocked URL object which always throws an IOException when the
openStream() method is called.
* <p>
- * Several ISPs do resolve invalid URLs like {@code
http://example.invalid} to some error page causing tests to fail otherwise.
+ * Several ISPs do resolve invalid URLs like {@code
https://example.invalid} to some error page causing tests to fail otherwise.
* </p>
*
* @return an invalid URL
diff --git
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailAttachmentTest.java
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailAttachmentTest.java
index 6dfdf2c..ceb0e3c 100644
---
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailAttachmentTest.java
+++
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailAttachmentTest.java
@@ -70,7 +70,7 @@ public class EmailAttachmentTest extends AbstractEmailTest {
@Test
public void testGetSetURL() throws Exception {
- final String[] tests = { "http://localhost/",
"http://www.apache.org/", "http://foo.notexisting.org" };
+ final String[] tests = { "https://localhost/",
"http://www.apache.org/", "http://foo.notexisting.org" };
for (final String urlString : tests) {
final URL testURL = new URL(urlString);
diff --git
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java
index 29eb782..260017e 100644
---
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java
+++
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java
@@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test;
* These are regression test sending REAL email to REAL mail servers using
REAL recipients.
*
* The intention is to field-test certain aspects of email using a variety of
mail clients since I'm not a mockist (see
- *
http://martinfowler.com/articles/mocksArentStubs.html#ClassicalAndMockistTesting).
+ *
https://martinfowler.com/articles/mocksArentStubs.html#ClassicalAndMockistTesting).
*/
public class EmailLiveTest extends AbstractEmailTest {
/**
@@ -97,7 +97,7 @@ public class EmailLiveTest extends AbstractEmailTest {
System.setProperty("mail.mime.charset", StandardCharsets.UTF_8.name());
// enforce encoding of non-ASCII characters (violating the MIME
specification - see
- //
http://java.sun.com/products/javamail/javadocs/javax/mail/internet/package-summary.html
+ //
https://java.sun.com/products/javamail/javadocs/javax/mail/internet/package-summary.html
System.setProperty("mail.mime.encodefilename", "true");
}
diff --git
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/HtmlEmailTest.java
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/HtmlEmailTest.java
index 8240f84..afc5dff 100644
---
a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/HtmlEmailTest.java
+++
b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/HtmlEmailTest.java
@@ -87,7 +87,7 @@ public class HtmlEmailTest extends AbstractEmailTest {
/**
* Create a HTML email containing an URL pointing to a ZIP file to be
downloaded. According to EMAIL-93 the resulting URL
- * "http://paradisedelivery.homeip.net/delivery/?file=TZC268X93337..zip"
contains TWO dots instead of one dot which breaks the link.
+ * "https://paradisedelivery.homeip.net/delivery/?file=TZC268X93337..zip"
contains TWO dots instead of one dot which breaks the link.
*/
@Test
public void testAddZipUrl() throws Exception {