This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-compress.git
The following commit(s) were added to refs/heads/master by this push:
new f91ef8a44 Test Lister with non-corrupt ar files
f91ef8a44 is described below
commit f91ef8a446bead1583d72ab0e2e85e64937eb3f2
Author: Gary Gregory <[email protected]>
AuthorDate: Thu Feb 1 20:02:55 2024 -0500
Test Lister with non-corrupt ar files
---
.../org/apache/commons/compress/archivers/ListerTest.java | 2 +-
.../compress/archivers/ar/ArArchiveInputStreamTest.java | 6 +++---
.../ar/number_parsing/{bad_group.ar => bad_group-fail.ar} | 0
.../ar/number_parsing/{bad_length.ar => bad_length-fail.ar} | 0
...bad_long_namelen_bsd.ar => bad_long_namelen_bsd-fail.ar} | 0
...d_long_namelen_gnu1.ar => bad_long_namelen_gnu1-fail.ar} | 0
...d_long_namelen_gnu2.ar => bad_long_namelen_gnu2-fail.ar} | 0
...d_long_namelen_gnu3.ar => bad_long_namelen_gnu3-fail.ar} | Bin
.../{bad_modified.ar => bad_modified-fail.ar} | 0
...bad_table_length_gnu.ar => bad_table_length_gnu-fail.ar} | 0
.../ar/number_parsing/{bad_user.ar => bad_user-fail.ar} | 0
11 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/src/test/java/org/apache/commons/compress/archivers/ListerTest.java
b/src/test/java/org/apache/commons/compress/archivers/ListerTest.java
index de18b3128..ba0f40808 100644
--- a/src/test/java/org/apache/commons/compress/archivers/ListerTest.java
+++ b/src/test/java/org/apache/commons/compress/archivers/ListerTest.java
@@ -32,7 +32,7 @@ import org.junit.jupiter.params.provider.MethodSource;
public class ListerTest {
public static Stream<Path> getFixtures() throws IOException {
- return PathUtils.walk(Paths.get("src/test/resources"), new
RegexFileFilter("^(?!.*(-fail)).*\\.(tar|arj|apk|dump)$"), 10, false);
+ return PathUtils.walk(Paths.get("src/test/resources"), new
RegexFileFilter("^(?!.*(-fail)).*\\.(tar|ar|arj|apk|dump)$"), 10, false);
}
@ParameterizedTest
diff --git
a/src/test/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStreamTest.java
b/src/test/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStreamTest.java
index 5ac3a710a..08490af0e 100644
---
a/src/test/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStreamTest.java
+++
b/src/test/java/org/apache/commons/compress/archivers/ar/ArArchiveInputStreamTest.java
@@ -85,8 +85,8 @@ public class ArArchiveInputStreamTest extends AbstractTest {
}
@ParameterizedTest
- @ValueSource(strings = { "bad_long_namelen_bsd.ar",
"bad_long_namelen_gnu1.ar", "bad_long_namelen_gnu2.ar",
"bad_long_namelen_gnu3.ar",
- "bad_table_length_gnu.ar" })
+ @ValueSource(strings = { "bad_long_namelen_bsd-fail.ar",
"bad_long_namelen_gnu1-fail.ar", "bad_long_namelen_gnu2-fail.ar",
"bad_long_namelen_gnu3-fail.ar",
+ "bad_table_length_gnu-fail.ar" })
public void testInvalidLongNameLength(final String testFileName) throws
Exception {
try (InputStream in =
newInputStream("org/apache/commons/compress/ar/number_parsing/" + testFileName);
ArArchiveInputStream archive = new ArArchiveInputStream(in)) {
@@ -95,7 +95,7 @@ public class ArArchiveInputStreamTest extends AbstractTest {
}
@ParameterizedTest
- @ValueSource(strings = { "bad_group.ar", "bad_length.ar",
"bad_modified.ar", "bad_user.ar" })
+ @ValueSource(strings = { "bad_group-fail.ar", "bad_length-fail.ar",
"bad_modified.ar", "bad_user.ar" })
public void testInvalidNumericFields(final String testFileName) throws
Exception {
try (InputStream in =
newInputStream("org/apache/commons/compress/ar/number_parsing/" + testFileName);
ArArchiveInputStream archive = new ArArchiveInputStream(in)) {
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_group.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_group-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_group.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_group-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_length.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_length-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_length.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_length-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_bsd.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_bsd-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_bsd.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_bsd-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu1.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu1-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu1.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu1-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu2.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu2-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu2.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu2-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu3.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu3-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu3.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_long_namelen_gnu3-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_modified.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_modified-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_modified.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_modified-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_table_length_gnu.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_table_length_gnu-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_table_length_gnu.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_table_length_gnu-fail.ar
diff --git
a/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_user.ar
b/src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_user-fail.ar
similarity index 100%
rename from
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_user.ar
rename to
src/test/resources/org/apache/commons/compress/ar/number_parsing/bad_user-fail.ar
