(commons-lang) 02/04: Test refactoring

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit af8575dd25bf99bb25e9ad424c0839e27d1ff608
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Wed Apr 24 16:00:25 2024 -0400

    Test refactoring
---
 .../apache/commons/lang3/math/NumberUtilsTest.java | 35 +++++++++++-----------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java 
b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
index 0748e05fb..c42db3d7f 100644
--- a/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
@@ -32,7 +32,6 @@ import java.text.NumberFormat;
 import java.text.ParseException;
 
 import org.apache.commons.lang3.AbstractLangTest;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -98,7 +97,7 @@ public class NumberUtilsTest extends AbstractLangTest {
         assertTrue(NumberUtils.compare((short) 213, (short) 32) > 0);
     }
 
-    private boolean isIntParsable(final String s) {
+    private boolean isIntegerParsable(final String s) {
         final NumberFormat instance = NumberFormat.getInstance();
         instance.setParseIntegerOnly(false);
         try {
@@ -842,22 +841,6 @@ public class NumberUtilsTest extends AbstractLangTest {
         assertFalse(NumberUtils.isDigits("abc"), "isDigits(String) neg 4 
failed");
     }
 
-    @Test
-    public void testIsIntParsableLang1729() {
-        assertTrue(isIntParsable("1"));
-        assertFalse(isIntParsable("1 2 3"));
-        assertTrue(isIntParsable("１２３"));
-        assertFalse(isIntParsable("１ ２ ３"));
-    }
-
-    @Test
-    public void testIsLongParsableLang1729() {
-        assertTrue(isLongParsable("1"));
-        assertFalse(isLongParsable("1 2 3"));
-        assertTrue(isLongParsable("１２３"));
-        assertFalse(isLongParsable("１ ２ ３"));
-    }
-
     /**
      * Tests isCreatable(String) and tests that createNumber(String) returns a 
valid number iff isCreatable(String)
      * returns false.
@@ -1008,6 +991,22 @@ public class NumberUtilsTest extends AbstractLangTest {
         compareIsCreatableWithCreateNumber("+2.0", true);
     }
 
+    @Test
+    public void testLang1729IsParsableInteger() {
+        assertTrue(isIntegerParsable("1"));
+        assertFalse(isIntegerParsable("1 2 3"));
+        assertTrue(isIntegerParsable("１２３"));
+        assertFalse(isIntegerParsable("１ ２ ３"));
+    }
+
+    @Test
+    public void testLang1729IsParsableLong() {
+        assertTrue(isLongParsable("1"));
+        assertFalse(isLongParsable("1 2 3"));
+        assertTrue(isLongParsable("１２３"));
+        assertFalse(isLongParsable("１ ２ ３"));
+    }
+
     @Test
     public void testLang300() {
         NumberUtils.createNumber("-1l");