This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit bd6a8c422731f93dde59f238dbb81aac7545010e Author: Gary Gregory <[email protected]> AuthorDate: Wed Apr 24 19:13:43 2024 -0400 Refactor magic string into an private constant --- src/main/java/org/apache/commons/lang3/SystemUtils.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/SystemUtils.java b/src/main/java/org/apache/commons/lang3/SystemUtils.java index 8ce72a1c1..cbb4721fb 100644 --- a/src/main/java/org/apache/commons/lang3/SystemUtils.java +++ b/src/main/java/org/apache/commons/lang3/SystemUtils.java @@ -34,6 +34,11 @@ import java.io.File; */ public class SystemUtils { + /** + * The regex to split version strings. + */ + private static final String VERSION_SPLIT_REGEX = "\\."; + /** * The prefix String for all Windows OS. */ @@ -2148,8 +2153,8 @@ public class SystemUtils { } // Compare parts of the version string instead of using String.startsWith(String) because otherwise // osVersionPrefix 10.1 would also match osVersion 10.10 - final String[] versionPrefixParts = osVersionPrefix.split("\\."); - final String[] versionParts = osVersion.split("\\."); + final String[] versionPrefixParts = osVersionPrefix.split(VERSION_SPLIT_REGEX); + final String[] versionParts = osVersion.split(VERSION_SPLIT_REGEX); for (int i = 0; i < Math.min(versionPrefixParts.length, versionParts.length); i++) { if (!versionPrefixParts[i].equals(versionParts[i])) { return false;
