This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-compress.git
commit b41a81845f3fd6603f7a58f94bb3d31274182541 Author: Gary Gregory <[email protected]> AuthorDate: Fri May 17 14:03:22 2024 -0400 Use try-with-resources --- .../compress/harmony/unpack200/SegmentTest.java | 32 ++++++++++------------ 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/src/test/java/org/apache/commons/compress/harmony/unpack200/SegmentTest.java b/src/test/java/org/apache/commons/compress/harmony/unpack200/SegmentTest.java index f4ba3d671..0a838c93b 100644 --- a/src/test/java/org/apache/commons/compress/harmony/unpack200/SegmentTest.java +++ b/src/test/java/org/apache/commons/compress/harmony/unpack200/SegmentTest.java @@ -54,23 +54,21 @@ public class SegmentTest extends AbstractTempDirTest { final JarEntry entry = jarFile.getJarEntry("org/apache/harmony/archive/tests/internal/pack200/HelloWorld.class"); assertNotNull(entry); final InputStream ours = jarFile.getInputStream(entry); - - final JarFile jarFile2 = new JarFile(new File(Segment.class.getResource("/pack200/hw.jar").toURI())); - final JarEntry entry2 = jarFile2.getJarEntry("org/apache/harmony/archive/tests/internal/pack200/HelloWorld.class"); - assertNotNull(entry2); - - final InputStream expected = jarFile2.getInputStream(entry2); - - try (BufferedReader reader1 = new BufferedReader(new InputStreamReader(ours)); - BufferedReader reader2 = new BufferedReader(new InputStreamReader(expected))) { - String line1 = reader1.readLine(); - String line2 = reader2.readLine(); - int i = 1; - while (line1 != null || line2 != null) { - assertEquals(line2, line1, "Unpacked class files differ ar line " + i); - line1 = reader1.readLine(); - line2 = reader2.readLine(); - i++; + try (JarFile jarFile2 = new JarFile(new File(Segment.class.getResource("/pack200/hw.jar").toURI()))) { + final JarEntry entry2 = jarFile2.getJarEntry("org/apache/harmony/archive/tests/internal/pack200/HelloWorld.class"); + assertNotNull(entry2); + final InputStream expected = jarFile2.getInputStream(entry2); + try (BufferedReader reader1 = new BufferedReader(new InputStreamReader(ours)); + BufferedReader reader2 = new BufferedReader(new InputStreamReader(expected))) { + String line1 = reader1.readLine(); + String line2 = reader2.readLine(); + int i = 1; + while (line1 != null || line2 != null) { + assertEquals(line2, line1, "Unpacked class files differ ar line " + i); + line1 = reader1.readLine(); + line2 = reader2.readLine(); + i++; + } } } }
