(commons-jexl) 01/02: Deprecate SimpleNode.SimpleNode(Parser, int) in favor of SimpleNode.SimpleNode(int)

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jexl.git

commit 963b918f66c116a71dbb5fe95c3f3af83e94ded0
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Tue May 21 13:54:59 2024 -0400

    Deprecate SimpleNode.SimpleNode(Parser, int) in favor of
    SimpleNode.SimpleNode(int)
---
 src/changes/changes.xml                                       | 6 ++++++
 src/main/java/org/apache/commons/jexl3/parser/JexlNode.java   | 8 ++++++++
 src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java | 5 ++++-
 3 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 2213f77d..e0de8faa 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -91,6 +91,12 @@
             <action dev="ggregory" type="fix" due-to="PMD, Gary Gregory">
                 Guard logging calls.
             </action>
+            <action dev="ggregory" type="fix" due-to="PMD, Gary Gregory">
+                Deprecate SimpleNode.SimpleNode(Parser, int) in favor of 
SimpleNode.SimpleNode(int).
+            </action>
+            <action dev="ggregory" type="fix" due-to="PMD, Gary Gregory">
+                Deprecate JexlNode.JexlNode(Parser, int) in favor of 
JexlNode.JexlNode(int).
+            </action>
             <!-- UPDATE -->
             <action dev="henrib" type="update" due-to="dependabot">
                 Bump github actions.
diff --git a/src/main/java/org/apache/commons/jexl3/parser/JexlNode.java 
b/src/main/java/org/apache/commons/jexl3/parser/JexlNode.java
index 3527ce4d..a60ecdd4 100644
--- a/src/main/java/org/apache/commons/jexl3/parser/JexlNode.java
+++ b/src/main/java/org/apache/commons/jexl3/parser/JexlNode.java
@@ -46,6 +46,14 @@ public abstract class JexlNode extends SimpleNode {
         super(id);
     }
 
+    /**
+     * Constructs a new instance.
+     *
+     * @param p not used.
+     * @param id the node type identifier
+     * @deprecated Use {@link #JexlNode(int)}.
+     */
+    @Deprecated
     public JexlNode(final Parser p, final int id) {
         super(p, id);
     }
diff --git a/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java 
b/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java
index 0ed19cd9..9f2f1fe1 100644
--- a/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java
+++ b/src/main/java/org/apache/commons/jexl3/parser/SimpleNode.java
@@ -53,10 +53,13 @@ public class SimpleNode implements Node {
     }
 
     /**
-     * Creates a SimpleNode instance.
+     * Constructs a SimpleNode instance.
+     *
      * @param p not used.
      * @param i the node type identifier
+     * @deprecated Use {@link #SimpleNode(int)}.
      */
+    @Deprecated
     public SimpleNode(final Parser p, final int i) {
         this(i);
     }