This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git

commit 5ebd823ae30a51026cf48f68710573c066a32c70
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Jun 23 14:21:26 2024 -0400

    Use Collections.sort(List) for clarity
---
 .../java/org/apache/commons/collections4/FluentIterableTest.java    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/collections4/FluentIterableTest.java 
b/src/test/java/org/apache/commons/collections4/FluentIterableTest.java
index 6d1aa48d6..2a528be1f 100644
--- a/src/test/java/org/apache/commons/collections4/FluentIterableTest.java
+++ b/src/test/java/org/apache/commons/collections4/FluentIterableTest.java
@@ -165,7 +165,7 @@ public class FluentIterableTest {
         final List<Integer> combinedList = new ArrayList<>();
         CollectionUtils.addAll(combinedList, iterableOdd);
         CollectionUtils.addAll(combinedList, iterableEven);
-        combinedList.sort(null);
+        Collections.sort(combinedList);
         assertEquals(combinedList, result);
 
         assertThrows(NullPointerException.class, () -> 
FluentIterable.of(iterableOdd).collate(null).toList(),
@@ -183,7 +183,7 @@ public class FluentIterableTest {
         final List<Integer> combinedList = new ArrayList<>();
         CollectionUtils.addAll(combinedList, iterableOdd);
         CollectionUtils.addAll(combinedList, iterableEven);
-        combinedList.sort(null);
+        Collections.sort(combinedList);
         assertEquals(combinedList, result);
 
         // null comparator is equivalent to natural ordering
@@ -446,7 +446,7 @@ public class FluentIterableTest {
         List<Integer> combinedList = new ArrayList<>();
         CollectionUtils.addAll(combinedList, iterableOdd);
         CollectionUtils.addAll(combinedList, iterableEven);
-        combinedList.sort(null);
+        Collections.sort(combinedList);
         assertEquals(combinedList, result);
 
         assertThrows(NullPointerException.class, () -> 
FluentIterable.of(iterableOdd).zip((Iterable<Integer>) null).toList(),

Reply via email to