This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch 1.X in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit a958c4d6838e9a5cf2f6b949ee2ef17237ee24f1 Author: Gary Gregory <[email protected]> AuthorDate: Thu Jul 25 17:20:39 2024 -0400 Use valueOf() --- .../converters/FloatLocaleConverterTestCase.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java index 32689bd8..62f90d10 100644 --- a/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java +++ b/src/test/java/org/apache/commons/beanutils/locale/converters/FloatLocaleConverterTestCase.java @@ -48,8 +48,8 @@ public class FloatLocaleConverterTestCase extends BaseLocaleConverterTestCase { super.setUp(); - defaultValue = new Float("9.99"); - expectedValue = new Float(expectedDecimalValue); + defaultValue = Float.valueOf("9.99"); + expectedValue = Float.valueOf(expectedDecimalValue); } @@ -88,7 +88,7 @@ public class FloatLocaleConverterTestCase extends BaseLocaleConverterTestCase { // quite happily turning "1,234.56" into "1.234" // I guess this is one of the limitations of DecimalFormat // ************************************************************************** - convertValueNoPattern(converter, "(B)", defaultDecimalValue, new Float("1.234")); + convertValueNoPattern(converter, "(B)", defaultDecimalValue, Float.valueOf("1.234")); // ************************************************************************** @@ -271,12 +271,12 @@ public class FloatLocaleConverterTestCase extends BaseLocaleConverterTestCase { converter = new FloatLocaleConverter(defaultLocale, defaultDecimalPattern); final DecimalFormat fmt = new DecimalFormat("#.#############################################################"); - assertEquals(new Float(-0.12), converter.convert("-0.12")); - assertEquals("Positive Float.MAX_VALUE", new Float(Float.MAX_VALUE), converter.convert(fmt.format(Float.MAX_VALUE))); - assertEquals("Positive Float.MIN_VALUE", new Float(Float.MIN_VALUE), converter.convert(fmt.format(Float.MIN_VALUE))); + assertEquals(Float.valueOf((float) -0.12), converter.convert("-0.12")); + assertEquals("Positive Float.MAX_VALUE", Float.valueOf(Float.MAX_VALUE), converter.convert(fmt.format(Float.MAX_VALUE))); + assertEquals("Positive Float.MIN_VALUE", Float.valueOf(Float.MIN_VALUE), converter.convert(fmt.format(Float.MIN_VALUE))); - assertEquals("Negative Float.MAX_VALUE", new Float(Float.MAX_VALUE * -1), converter.convert(fmt.format(Float.MAX_VALUE * -1))); - assertEquals("Negative Float.MIN_VALUE", new Float(Float.MIN_VALUE * -1), converter.convert(fmt.format(Float.MIN_VALUE * -1))); + assertEquals("Negative Float.MAX_VALUE", Float.valueOf(Float.MAX_VALUE * -1), converter.convert(fmt.format(Float.MAX_VALUE * -1))); + assertEquals("Negative Float.MIN_VALUE", Float.valueOf(Float.MIN_VALUE * -1), converter.convert(fmt.format(Float.MIN_VALUE * -1))); try { @@ -312,7 +312,7 @@ public class FloatLocaleConverterTestCase extends BaseLocaleConverterTestCase { public void testParseZero() { try { final Object result = LocaleConvertUtils.convert("0", Float.class, Locale.US, null); - assertEquals(new Float(0), result); + assertEquals(Float.valueOf(0), result); } catch (final ConversionException e) { fail("Zero threw ConversionException: " + e); }
