This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-cli.git

commit 25b52e4deac5cec186ba71e85b467404c755c9f3
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Aug 10 08:53:14 2024 -0400

    Better parameter name
    
    Better instance variable name
---
 src/main/java/org/apache/commons/cli/Option.java | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/apache/commons/cli/Option.java 
b/src/main/java/org/apache/commons/cli/Option.java
index 2e49cdb..d2c6f5c 100644
--- a/src/main/java/org/apache/commons/cli/Option.java
+++ b/src/main/java/org/apache/commons/cli/Option.java
@@ -417,7 +417,7 @@ public class Option implements Cloneable, Serializable {
     private List<String> values = new ArrayList<>();
 
     /** The character that is the value separator. */
-    private char valuesep;
+    private char valueSeparator;
 
     /**
      * Private constructor used by the nested Builder class.
@@ -435,7 +435,7 @@ public class Option implements Cloneable, Serializable {
         this.required = builder.required;
         this.since = builder.since;
         this.type = builder.type;
-        this.valuesep = builder.valueSeparator;
+        this.valueSeparator = builder.valueSeparator;
         this.converter = builder.converter;
     }
 
@@ -727,7 +727,7 @@ public class Option implements Cloneable, Serializable {
      * @return the value separator character.
      */
     public char getValueSeparator() {
-        return valuesep;
+        return valueSeparator;
     }
 
     /**
@@ -805,7 +805,7 @@ public class Option implements Cloneable, Serializable {
      * @since 1.1
      */
     public boolean hasValueSeparator() {
-        return valuesep > 0;
+        return valueSeparator > 0;
     }
 
     /**
@@ -969,10 +969,10 @@ public class Option implements Cloneable, Serializable {
     /**
      * Sets the value separator. For example if the argument value was a Java 
property, the value separator would be '='.
      *
-     * @param sep The value separator.
+     * @param valueSeparator The value separator.
      */
-    public void setValueSeparator(final char sep) {
-        this.valuesep = sep;
+    public void setValueSeparator(final char valueSeparator) {
+        this.valueSeparator = valueSeparator;
     }
 
     String toDeprecatedString() {

Reply via email to