This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 4f8ab90bce8a8f339e35d9cd55220b2da28d88a0 Author: Gary Gregory <[email protected]> AuthorDate: Sun Aug 18 08:24:10 2024 -0400 Remove redundant call to super() Use final --- .../commons/beanutils2/converters/DimensionConverter.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/apache/commons/beanutils2/converters/DimensionConverter.java b/src/main/java/org/apache/commons/beanutils2/converters/DimensionConverter.java index 0d4de490..58d27942 100644 --- a/src/main/java/org/apache/commons/beanutils2/converters/DimensionConverter.java +++ b/src/main/java/org/apache/commons/beanutils2/converters/DimensionConverter.java @@ -43,7 +43,6 @@ public class DimensionConverter extends AbstractConverter<Dimension> { * occurs. */ public DimensionConverter() { - super(); } /** @@ -86,18 +85,18 @@ public class DimensionConverter extends AbstractConverter<Dimension> { throw new IllegalArgumentException("Dimensions can not be empty."); } - Matcher matcher = DIMENSION_PATTERN.matcher(stringValue); + final Matcher matcher = DIMENSION_PATTERN.matcher(stringValue); if (!matcher.matches()) { throw new IllegalArgumentException( "Dimension doesn't match format: {width/height} or {width}x{height}"); } - String x = matcher.group(1); - String y = matcher.group(2); + final String x = matcher.group(1); + final String y = matcher.group(2); - int xValue = Integer.parseInt(x); - int yValue = (y == null || x.equals(y)) ? xValue : Integer.parseInt(y); + final int xValue = Integer.parseInt(x); + final int yValue = y == null || x.equals(y) ? xValue : Integer.parseInt(y); return type.cast(new Dimension(xValue, yValue)); }
