This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch 1.x in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit 1d1445ded7b7e0c32c7a01e59670adce2f33a1d0 Author: Gary Gregory <[email protected]> AuthorDate: Sun Aug 25 12:07:26 2024 -0400 Use try-with-resources --- .../apache/commons/fileupload/DiskFileItemSerializeTest.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java b/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java index 0313277b..18eaa523 100644 --- a/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java +++ b/src/test/java/org/apache/commons/fileupload/DiskFileItemSerializeTest.java @@ -97,23 +97,18 @@ public class DiskFileItemSerializeTest { private FileItem createFileItem(final byte[] contentBytes, final File repository) { final FileItemFactory factory = new DiskFileItemFactory(threshold, repository); final String textFieldName = "textField"; - final FileItem item = factory.createItem( textFieldName, textContentType, true, "My File Name" ); - try { - final OutputStream os = item.getOutputStream(); + try (OutputStream os = item.getOutputStream()) { os.write(contentBytes); - os.close(); } catch(final IOException e) { fail("Unexpected IOException" + e); } - return item; - } /** @@ -121,12 +116,10 @@ public class DiskFileItemSerializeTest { */ private Object deserialize(final ByteArrayOutputStream baos) throws Exception { Object result = null; - final ByteArrayInputStream bais = - new ByteArrayInputStream(baos.toByteArray()); + final ByteArrayInputStream bais = new ByteArrayInputStream(baos.toByteArray()); final ObjectInputStream ois = new ObjectInputStream(bais); result = ois.readObject(); bais.close(); - return result; }
