This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit 7023b20fbe3be4c795e855078fd92ef6ad2bd434 Author: Gary Gregory <[email protected]> AuthorDate: Sun Aug 25 16:31:49 2024 -0400 Better parameter names --- .../java/org/apache/commons/collections4/bidimap/TreeBidiMap.java | 4 ++-- .../collections4/iterators/AbstractMapIteratorDecorator.java | 4 ++-- .../iterators/AbstractOrderedMapIteratorDecorator.java | 4 ++-- .../commons/collections4/keyvalue/AbstractMapEntryDecorator.java | 4 ++-- .../org/apache/commons/collections4/list/AbstractLinkedList.java | 4 ++-- .../org/apache/commons/collections4/map/AbstractReferenceMap.java | 8 ++++---- .../java/org/apache/commons/collections4/map/StaticBucketMap.java | 8 ++++---- .../org/apache/commons/collections4/map/UnmodifiableEntrySet.java | 2 +- 8 files changed, 19 insertions(+), 19 deletions(-) diff --git a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java index 13a3c2aa1..1f5c66acf 100644 --- a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java +++ b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java @@ -515,7 +515,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>> } @Override - public K setValue(final K obj) { + public K setValue(final K value) { throw new UnsupportedOperationException(); } } @@ -860,7 +860,7 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>> } @Override - public V setValue(final V obj) { + public V setValue(final V value) { throw new UnsupportedOperationException(); } } diff --git a/src/main/java/org/apache/commons/collections4/iterators/AbstractMapIteratorDecorator.java b/src/main/java/org/apache/commons/collections4/iterators/AbstractMapIteratorDecorator.java index 995c54d86..8ed627a53 100644 --- a/src/main/java/org/apache/commons/collections4/iterators/AbstractMapIteratorDecorator.java +++ b/src/main/java/org/apache/commons/collections4/iterators/AbstractMapIteratorDecorator.java @@ -85,8 +85,8 @@ public class AbstractMapIteratorDecorator<K, V> implements MapIterator<K, V> { /** {@inheritDoc} */ @Override - public V setValue(final V obj) { - return iterator.setValue(obj); + public V setValue(final V value) { + return iterator.setValue(value); } } diff --git a/src/main/java/org/apache/commons/collections4/iterators/AbstractOrderedMapIteratorDecorator.java b/src/main/java/org/apache/commons/collections4/iterators/AbstractOrderedMapIteratorDecorator.java index 2f1210df3..cbeaab2c6 100644 --- a/src/main/java/org/apache/commons/collections4/iterators/AbstractOrderedMapIteratorDecorator.java +++ b/src/main/java/org/apache/commons/collections4/iterators/AbstractOrderedMapIteratorDecorator.java @@ -97,8 +97,8 @@ public class AbstractOrderedMapIteratorDecorator<K, V> implements OrderedMapIter /** {@inheritDoc} */ @Override - public V setValue(final V obj) { - return iterator.setValue(obj); + public V setValue(final V value) { + return iterator.setValue(value); } } diff --git a/src/main/java/org/apache/commons/collections4/keyvalue/AbstractMapEntryDecorator.java b/src/main/java/org/apache/commons/collections4/keyvalue/AbstractMapEntryDecorator.java index 442b6eeb3..08bd0d24e 100644 --- a/src/main/java/org/apache/commons/collections4/keyvalue/AbstractMapEntryDecorator.java +++ b/src/main/java/org/apache/commons/collections4/keyvalue/AbstractMapEntryDecorator.java @@ -77,8 +77,8 @@ public abstract class AbstractMapEntryDecorator<K, V> implements Map.Entry<K, V> } @Override - public V setValue(final V object) { - return entry.setValue(object); + public V setValue(final V value) { + return entry.setValue(value); } @Override diff --git a/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java b/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java index eef3e27b4..0a941b6e4 100644 --- a/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java +++ b/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java @@ -213,9 +213,9 @@ public abstract class AbstractLinkedList<E> implements List<E> { } @Override - public void set(final E obj) { + public void set(final E value) { checkModCount(); - getLastNodeReturned().setValue(obj); + getLastNodeReturned().setValue(value); } } diff --git a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java index 0f926a474..7ff279752 100644 --- a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java +++ b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java @@ -329,17 +329,17 @@ public abstract class AbstractReferenceMap<K, V> extends AbstractHashedMap<K, V> /** * Sets the value of the entry. * - * @param obj the object to store + * @param value the object to store * @return the previous value */ @Override @SuppressWarnings("unchecked") - public V setValue(final V obj) { + public V setValue(final V value) { final V old = getValue(); if (parent.valueType != ReferenceStrength.HARD) { - ((Reference<V>) value).clear(); + ((Reference<V>) this.value).clear(); } - value = toReference(parent.valueType, obj, hashCode); + this.value = toReference(parent.valueType, value, hashCode); return old; } diff --git a/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java b/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java index 2abd65ab1..861141280 100644 --- a/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java +++ b/src/main/java/org/apache/commons/collections4/map/StaticBucketMap.java @@ -304,10 +304,10 @@ public final class StaticBucketMap<K, V> extends AbstractIterableMap<K, V> { } @Override - public V setValue(final V obj) { - final V retVal = value; - value = obj; - return retVal; + public V setValue(final V value) { + final V old = this.value; + this.value = value; + return old; } } diff --git a/src/main/java/org/apache/commons/collections4/map/UnmodifiableEntrySet.java b/src/main/java/org/apache/commons/collections4/map/UnmodifiableEntrySet.java index 050536117..9a4674c82 100644 --- a/src/main/java/org/apache/commons/collections4/map/UnmodifiableEntrySet.java +++ b/src/main/java/org/apache/commons/collections4/map/UnmodifiableEntrySet.java @@ -52,7 +52,7 @@ public final class UnmodifiableEntrySet<K, V> } @Override - public V setValue(final V obj) { + public V setValue(final V value) { throw new UnsupportedOperationException(); } }
