This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-cli.git
commit 3896533713d1e7541958a80b6e70f354c3a5da94 Author: Gary Gregory <[email protected]> AuthorDate: Sat Oct 19 07:59:06 2024 -0400 Use assertThrows() --- .../org/apache/commons/cli/PatternOptionBuilderTest.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java b/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java index 8ccb000a..ca7dd422 100644 --- a/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java +++ b/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java @@ -24,8 +24,6 @@ import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.junit.jupiter.api.Assertions.fail; - import java.io.File; import java.io.FileInputStream; import java.net.URL; @@ -104,13 +102,9 @@ public class PatternOptionBuilderTest { public void testRequiredOption() throws Exception { final Options options = PatternOptionBuilder.parsePattern("!n%m%"); final CommandLineParser parser = new PosixParser(); - try { - parser.parse(options, new String[] {""}); - fail("MissingOptionException wasn't thrown"); - } catch (final MissingOptionException e) { - assertEquals(1, e.getMissingOptions().size()); - assertTrue(e.getMissingOptions().contains("n")); - } + final MissingOptionException e = assertThrows(MissingOptionException.class, () -> parser.parse(options, new String[] { "" })); + assertEquals(1, e.getMissingOptions().size()); + assertTrue(e.getMissingOptions().contains("n")); } @Test
