svn commit: r1026193 - in /commons/proper/collections/trunk/src/test/org/apache/commons/collections: comparators/TestFixedOrderComparator.java iterators/TestObjectGraphIterator.java list/TestCursorableLinkedList.java

[sebb]

Author: sebb
Date: Fri Oct 22 01:29:03 2010
New Revision: 1026193

URL: http://svn.apache.org/viewvc?rev=1026193&view=rev
Log:
No cast needed

Modified:
    
commons/proper/collections/trunk/src/test/org/apache/commons/collections/comparators/TestFixedOrderComparator.java
    
commons/proper/collections/trunk/src/test/org/apache/commons/collections/iterators/TestObjectGraphIterator.java
    
commons/proper/collections/trunk/src/test/org/apache/commons/collections/list/TestCursorableLinkedList.java

Modified: 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/comparators/TestFixedOrderComparator.java
URL: 
http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/test/org/apache/commons/collections/comparators/TestFixedOrderComparator.java?rev=1026193&r1=1026192&r2=1026193&view=diff
==============================================================================
--- 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/comparators/TestFixedOrderComparator.java
 (original)
+++ 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/comparators/TestFixedOrderComparator.java
 Fri Oct 22 01:29:03 2010
@@ -76,7 +76,7 @@ public class TestFixedOrderComparator ex
         for (int i = 0; i < topCities.length; i++) {
             comparator.add(topCities[i]);
         }
-        String[] keys = (String[]) topCities.clone();
+        String[] keys = topCities.clone();
         assertComparatorYieldsOrder(keys, comparator);
     }
 
@@ -84,8 +84,8 @@ public class TestFixedOrderComparator ex
      * Tests that the array constructor compares items properly.
      */
     public void testArrayConstructor() {
-        String[] keys = (String[]) topCities.clone();
-        String[] topCitiesForTest = (String[]) topCities.clone();
+        String[] keys = topCities.clone();
+        String[] topCitiesForTest = topCities.clone();
         FixedOrderComparator<String> comparator = new 
FixedOrderComparator<String>(topCitiesForTest);
         assertComparatorYieldsOrder(keys, comparator);
         // test that changing input after constructor has no effect
@@ -97,7 +97,7 @@ public class TestFixedOrderComparator ex
      * Tests the list constructor.
      */
     public void testListConstructor() {
-        String[] keys = (String[]) topCities.clone();
+        String[] keys = topCities.clone();
         List<String> topCitiesForTest = new 
LinkedList<String>(Arrays.asList(topCities));
         FixedOrderComparator<String> comparator = new 
FixedOrderComparator<String>(topCitiesForTest);
         assertComparatorYieldsOrder(keys, comparator);

Modified: 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/iterators/TestObjectGraphIterator.java
URL: 
http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/test/org/apache/commons/collections/iterators/TestObjectGraphIterator.java?rev=1026193&r1=1026192&r2=1026193&view=diff
==============================================================================
--- 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/iterators/TestObjectGraphIterator.java
 (original)
+++ 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/iterators/TestObjectGraphIterator.java
 Fri Oct 22 01:29:03 2010
@@ -382,7 +382,7 @@ public class TestObjectGraphIterator ext
         }
 
         Tree getTree(int index) {
-            return (Tree) trees.get(index);
+            return trees.get(index);
         }
 
         Iterator<Tree> treeIterator() {
@@ -399,7 +399,7 @@ public class TestObjectGraphIterator ext
         }
 
         Branch getBranch(int index) {
-            return (Branch) branches.get(index);
+            return branches.get(index);
         }
 
         Iterator<Branch> branchIterator() {
@@ -416,7 +416,7 @@ public class TestObjectGraphIterator ext
         }
 
         Leaf getLeaf(int index) {
-            return (Leaf) leaves.get(index);
+            return leaves.get(index);
         }
 
         Iterator<Leaf> leafIterator() {

Modified: 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/list/TestCursorableLinkedList.java
URL: 
http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/test/org/apache/commons/collections/list/TestCursorableLinkedList.java?rev=1026193&r1=1026192&r2=1026193&view=diff
==============================================================================
--- 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/list/TestCursorableLinkedList.java
 (original)
+++ 
commons/proper/collections/trunk/src/test/org/apache/commons/collections/list/TestCursorableLinkedList.java
 Fri Oct 22 01:29:03 2010
@@ -1400,7 +1400,7 @@ public class TestCursorableLinkedList<E>
         assertEquals("5", elts[4]);
         assertEquals(5, elts.length);
 
-        String[] elts2 = (String[]) (list.toArray(new String[0]));
+        String[] elts2 = (list.toArray(new String[0]));
         assertEquals("1", elts2[0]);
         assertEquals("2", elts2[1]);
         assertEquals("3", elts2[2]);
@@ -1418,7 +1418,7 @@ public class TestCursorableLinkedList<E>
         assertEquals(5, elts3.length);
 
         String[] elts4 = new String[3];
-        String[] elts4b = (String[]) (list.toArray(elts4));
+        String[] elts4b = (list.toArray(elts4));
         assertTrue(elts4 != elts4b);
         assertEquals("1", elts4b[0]);
         assertEquals("2", elts4b[1]);
@@ -1520,7 +1520,7 @@ public class TestCursorableLinkedList<E>
             list.add(prefix + bulk + ignored[i]);
             list.add(prefix + bulk + bulk + ignored[i]);
         }
-        return (String[]) list.toArray(new String[0]);
+        return list.toArray(new String[0]);
     }
 
     @Override