This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git

commit 470c69c53e87aed08d62b60894a8ed400d5994f0
Author: Gary D. Gregory <[email protected]>
AuthorDate: Sat Dec 28 11:39:42 2024 -0500

    Deprecate GenericValidator.GenericValidator()
---
 src/changes/changes.xml                                    |  1 +
 .../org/apache/commons/validator/GenericValidator.java     | 14 ++++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4fa2bc14..5f850f0c 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -71,6 +71,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action type="fix" dev="ggregory" due-to="Johannes 
Weberhofer">InetAddressValidator does not need its instance variable, so uses a 
touch less memory.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Pick up 
maven-antrun-plugin version from parent POM org.apache:apache.</action>
     <action type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate 
GenericTypeValidator.GenericTypeValidator().</action>
+    <action type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate 
GenericValidator.GenericValidator().</action>
     <!-- ADD -->
     <action type="add" issue="VALIDATOR-497" dev="sjaranowski" 
due-to="Slawomir Jaranowski">IBANValidator: add method validate with validation 
status</action>
     <action type="add" dev="sebb">DomainValidatorTest: added Maven profile to 
simplfy execution.</action>
diff --git a/src/main/java/org/apache/commons/validator/GenericValidator.java 
b/src/main/java/org/apache/commons/validator/GenericValidator.java
index a57a2047..837887bb 100644
--- a/src/main/java/org/apache/commons/validator/GenericValidator.java
+++ b/src/main/java/org/apache/commons/validator/GenericValidator.java
@@ -341,8 +341,6 @@ public class GenericValidator implements Serializable {
         return value <= max;
     }
 
-    // See https://issues.apache.org/bugzilla/show_bug.cgi?id=29015 WRT the 
"value" methods
-
     /**
      * <p>Checks if the value is less than or equal to the max.</p>
      *
@@ -354,6 +352,8 @@ public class GenericValidator implements Serializable {
         return value <= max;
     }
 
+    // See https://issues.apache.org/bugzilla/show_bug.cgi?id=29015 WRT the 
"value" methods
+
     /**
      * <p>Checks if the value is less than or equal to the max.</p>
      *
@@ -433,4 +433,14 @@ public class GenericValidator implements Serializable {
         return value >= min;
     }
 
+    /**
+     * Constructs a new instance.
+     *
+     * @deprecated Will be private in the next major version.
+     */
+    @Deprecated
+    public GenericValidator() {
+        // empty
+    }
+
 }

Reply via email to