This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit fc3638e0fc8dc82136753c085f90ae4f773c01ba Author: Gary D. Gregory <[email protected]> AuthorDate: Tue Jan 7 12:22:35 2025 -0500 Add tests - Rename test - Format tweak --- src/main/java/org/apache/commons/lang3/tuple/Pair.java | 8 ++++++-- .../java/org/apache/commons/lang3/tuple/PairTest.java | 16 +++++++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/tuple/Pair.java b/src/main/java/org/apache/commons/lang3/tuple/Pair.java index d47d7553e..2264b62ce 100644 --- a/src/main/java/org/apache/commons/lang3/tuple/Pair.java +++ b/src/main/java/org/apache/commons/lang3/tuple/Pair.java @@ -159,8 +159,12 @@ public abstract class Pair<L, R> implements Map.Entry<L, R>, Comparable<Pair<L, */ @Override public int compareTo(final Pair<L, R> other) { - return new CompareToBuilder().append(getLeft(), other.getLeft()) - .append(getRight(), other.getRight()).toComparison(); + // @formatter:off + return new CompareToBuilder() + .append(getLeft(), other.getLeft()) + .append(getRight(), other.getRight()) + .toComparison(); + // @formatter:on } /** diff --git a/src/test/java/org/apache/commons/lang3/tuple/PairTest.java b/src/test/java/org/apache/commons/lang3/tuple/PairTest.java index 6b7eaa9cb..03f5e91e0 100644 --- a/src/test/java/org/apache/commons/lang3/tuple/PairTest.java +++ b/src/test/java/org/apache/commons/lang3/tuple/PairTest.java @@ -82,7 +82,7 @@ public class PairTest extends AbstractLangTest { } @Test - public void testComparable1() { + public void testComparableAllDifferent() { final Pair<String, String> pair1 = Pair.of("A", "D"); final Pair<String, String> pair2 = Pair.of("B", "C"); assertEquals(0, pair1.compareTo(pair1)); @@ -93,8 +93,18 @@ public class PairTest extends AbstractLangTest { @Test public void testComparableLeftEquals() { - final Pair<String, String> pair1 = Pair.of("A", "C"); - final Pair<String, String> pair2 = Pair.of("A", "D"); + final Pair<String, String> pair1 = Pair.of("E", "C"); + final Pair<String, String> pair2 = Pair.of("E", "D"); + assertEquals(0, pair1.compareTo(pair1)); + assertTrue(pair1.compareTo(pair2) < 0); + assertEquals(0, pair2.compareTo(pair2)); + assertTrue(pair2.compareTo(pair1) > 0); + } + + @Test + public void testComparableRightEquals() { + final Pair<String, String> pair1 = Pair.of("A", "E"); + final Pair<String, String> pair2 = Pair.of("B", "E"); assertEquals(0, pair1.compareTo(pair1)); assertTrue(pair1.compareTo(pair2) < 0); assertEquals(0, pair2.compareTo(pair2));
