This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch POOL_2_X in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit 644a4325f5f45a6d504560436674e84c9ab6b33a Author: Gary D. Gregory <[email protected]> AuthorDate: Mon Feb 10 16:32:08 2025 -0500 Sort Checkstyle entries Remove comments that duplicate Checkstyle docs --- src/conf/checkstyle.xml | 69 ++++++++++++++++++++----------------------------- 1 file changed, 28 insertions(+), 41 deletions(-) diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml index 644d13dd..d6de8e57 100644 --- a/src/conf/checkstyle.xml +++ b/src/conf/checkstyle.xml @@ -24,53 +24,13 @@ --> <module name="Checker"> <property name="localeLanguage" value="en" /> - <!-- No tabs allowed! --> <module name="FileTabCharacter" /> - <module name="TreeWalker"> - <!-- Operator must be at end of wrapped line --> - <module name="OperatorWrap"> - <property name="option" value="eol" /> - </module> - <!-- Interfaces must be types (not just constants) --> - <module name="InterfaceIsType" /> - <!-- Must have class / interface header comments --> - <module name="JavadocType" /> - <!-- Require method javadocs, allow undeclared RTE --> - <module name="JavadocMethod"> - </module> - <!-- Require field javadoc --> - <module name="JavadocVariable"> - <property name="scope" value="protected" /> - </module> - <!-- No public fields --> - <module name="VisibilityModifier"> - <property name="packageAllowed" value="true" /> - <property name="protectedAllowed" value="true" /> - </module> - <!-- Require hash code override when equals is --> - <module name="EqualsHashCode" /> - <!-- Disallow unnecessary instantiation of Boolean, String --> - <module name="IllegalInstantiation"> - <property name="classes" value="java.lang.Boolean, java.lang.String" /> - </module> - <module name="ImportOrder"> - <property name="option" value="top" /> - <property name="groups" value="java,javax,org" /> - <property name="ordered" value="true" /> - <property name="separated" value="true" /> - </module> - <module name="ParenPad" /> - <module name="TypecastParenPad" /> - </module> - <!-- Require package Javadoc --> <module name="JavadocPackage"> - <!-- setting allowLegacy means it will check for package.html instead of just package-info.java --> <property name="allowLegacy" value="true" /> </module> <module name="LineLength"> <property name="max" value="160" /> </module> - <!-- @author tags are deprecated --> <module name="RegexpSingleline"> <property name="format" value="^\s+\*\s+@author\s" /> <property name="message" value="Deprecated @author tag" /> @@ -78,8 +38,35 @@ <property name="severity" value="warning" /> </module> <module name="RegexpSingleline"> - <!-- \s matches whitespace character, $ matches end of line. --> <property name="format" value="\s+$" /> <property name="message" value="Line has trailing spaces." /> </module> + <module name="TreeWalker"> + <module name="EqualsHashCode" /> + <module name="IllegalInstantiation"> + <property name="classes" value="java.lang.Boolean, java.lang.String" /> + </module> + <module name="ImportOrder"> + <property name="option" value="top" /> + <property name="groups" value="java,javax,org" /> + <property name="ordered" value="true" /> + <property name="separated" value="true" /> + </module> + <module name="InterfaceIsType" /> + <module name="JavadocType" /> + <module name="JavadocMethod"> + </module> + <module name="JavadocVariable"> + <property name="scope" value="protected" /> + </module> + <module name="OperatorWrap"> + <property name="option" value="eol" /> + </module> + <module name="ParenPad" /> + <module name="TypecastParenPad" /> + <module name="VisibilityModifier"> + <property name="packageAllowed" value="true" /> + <property name="protectedAllowed" value="true" /> + </module> + </module> </module>
