Author: niallp Date: Sun Jan 9 21:35:32 2011 New Revision: 1057037 URL: http://svn.apache.org/viewvc?rev=1057037&view=rev Log: Fix a couple of FindBugs issues
Modified: commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/BooleanUtils.java commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/Entities.java Modified: commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/BooleanUtils.java URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/BooleanUtils.java?rev=1057037&r1=1057036&r2=1057037&view=diff ============================================================================== --- commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/BooleanUtils.java (original) +++ commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/BooleanUtils.java Sun Jan 9 21:35:32 2011 @@ -726,7 +726,7 @@ public class BooleanUtils { * @return the boolean value of the string, <code>false</code> if no match or the String is null */ public static boolean toBoolean(String str) { - return toBooleanObject(str) == Boolean.TRUE; + return toBoolean(toBooleanObject(str)); } /** Modified: commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/Entities.java URL: http://svn.apache.org/viewvc/commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/Entities.java?rev=1057037&r1=1057036&r2=1057037&view=diff ============================================================================== --- commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/Entities.java (original) +++ commons/proper/lang/branches/LANG_2_X/src/main/java/org/apache/commons/lang/Entities.java Sun Jan 9 21:35:32 2011 @@ -538,7 +538,7 @@ class Entities { // TODO this class is not thread-safe private String[] lookupTable; - private final int LOOKUP_TABLE_SIZE = 256; + private static final int LOOKUP_TABLE_SIZE = 256; /** * {...@inheritdoc}