This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit ded7b8edd7d3db32e35061e1155862010e10c8b7
Author: Alex Herbert <aherb...@apache.org>
AuthorDate: Mon Sep 22 13:45:09 2025 +0100
pmd fix: Use java naming conventions for generic types
---
.../commons/rng/simple/internal/NoOpConverter.java | 6 +++---
.../rng/simple/internal/ProviderBuilder.java | 4 ++--
.../rng/simple/internal/Seed2ArrayConverter.java | 8 ++++----
.../commons/rng/simple/internal/SeedConverter.java | 8 ++++----
.../rng/simple/internal/SeedConverterComposer.java | 21 +++++++++++----------
5 files changed, 24 insertions(+), 23 deletions(-)
diff --git
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/NoOpConverter.java
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/NoOpConverter.java
index f70ac333..ba3d4ad4 100644
---
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/NoOpConverter.java
+++
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/NoOpConverter.java
@@ -21,11 +21,11 @@ package org.apache.commons.rng.simple.internal;
* Dummy converter that simply passes on its input.
* It can be useful to avoid "unchecked" compiler warnings.
*
- * @param <SEED> Seed type.
+ * @param <T> Seed type.
*
* @since 1.0
*/
-public class NoOpConverter<SEED> implements SeedConverter<SEED, SEED> {
+public class NoOpConverter<T> implements SeedConverter<T, T> {
/** Create an instance. */
public NoOpConverter() {
// Do nothing
@@ -33,7 +33,7 @@ public class NoOpConverter<SEED> implements
SeedConverter<SEED, SEED> {
/** {@inheritDoc} */
@Override
- public SEED convert(SEED seed) {
+ public T convert(T seed) {
return seed;
}
}
diff --git
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
index 63a2ea1e..def9a36b 100644
---
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
+++
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
@@ -541,13 +541,13 @@ public final class ProviderBuilder {
* Checks whether the type of given {@code seed} is the native type
* of the implementation.
*
- * @param <SEED> Seed type.
+ * @param <T> Seed type.
*
* @param seed Seed value.
* @return {@code true} if the seed can be passed to the builder
* for this RNG type.
*/
- public <SEED> boolean isNativeSeed(SEED seed) {
+ public <T> boolean isNativeSeed(T seed) {
return seed != null && getSeed().equals(seed.getClass());
}
diff --git
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Seed2ArrayConverter.java
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Seed2ArrayConverter.java
index 3dfa8a9b..92c5a2bc 100644
---
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Seed2ArrayConverter.java
+++
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Seed2ArrayConverter.java
@@ -19,11 +19,11 @@ package org.apache.commons.rng.simple.internal;
/**
* Seed converter to create an output array type.
*
- * @param <IN> Input seed type.
- * @param <OUT> Output seed type.
+ * @param <T> Input seed type.
+ * @param <R> Output seed type.
* @since 1.3
*/
-public interface Seed2ArrayConverter<IN, OUT> extends SeedConverter<IN, OUT> {
+public interface Seed2ArrayConverter<T, R> extends SeedConverter<T, R> {
/**
* Converts seed from input type to output type. The output type is
expected to be an array.
*
@@ -31,5 +31,5 @@ public interface Seed2ArrayConverter<IN, OUT> extends
SeedConverter<IN, OUT> {
* @param outputSize Output size.
* @return the converted seed value.
*/
- OUT convert(IN seed, int outputSize);
+ R convert(T seed, int outputSize);
}
diff --git
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverter.java
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverter.java
index 3dacf816..32948438 100644
---
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverter.java
+++
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverter.java
@@ -19,18 +19,18 @@ package org.apache.commons.rng.simple.internal;
/**
* Seed converter.
*
- * @param <IN> Input seed type.
- * @param <OUT> Output seed type.
+ * @param <T> Input seed type.
+ * @param <R> Output seed type.
*
* @since 1.0
*/
@FunctionalInterface
-public interface SeedConverter<IN, OUT> {
+public interface SeedConverter<T, R> {
/**
* Converts seed from input type to output type.
*
* @param seed Original seed value.
* @return the converted seed value.
*/
- OUT convert(IN seed);
+ R convert(T seed);
}
diff --git
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverterComposer.java
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverterComposer.java
index 15c4e180..f4d74ac2 100644
---
a/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverterComposer.java
+++
b/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/SeedConverterComposer.java
@@ -16,20 +16,21 @@
*/
package org.apache.commons.rng.simple.internal;
+
/**
* Composes two {@link SeedConverter converters}.
*
- * @param <IN> Input seed type.
- * @param <TRANS> Transitional seed type.
- * @param <OUT> Output seed type.
+ * @param <T> Input seed type.
+ * @param <S> Transitional seed type.
+ * @param <R> Output seed type.
*
* @since 1.0
*/
-public class SeedConverterComposer<IN, TRANS, OUT> implements
SeedConverter<IN, OUT> {
+public class SeedConverterComposer<T, S, R> implements SeedConverter<T, R> {
/** First conversion. */
- private final SeedConverter<IN, TRANS> first;
+ private final SeedConverter<T, S> first;
/** Second conversion. */
- private final SeedConverter<TRANS, OUT> second;
+ private final SeedConverter<S, R> second;
/**
* Create an instance.
@@ -37,16 +38,16 @@ public class SeedConverterComposer<IN, TRANS, OUT>
implements SeedConverter<IN,
* @param first First conversion.
* @param second second conversion.
*/
- public SeedConverterComposer(SeedConverter<IN, TRANS> first,
- SeedConverter<TRANS, OUT> second) {
+ public SeedConverterComposer(SeedConverter<T, S> first,
+ SeedConverter<S, R> second) {
this.first = first;
this.second = second;
}
/** {@inheritDoc} */
@Override
- public OUT convert(IN seed) {
- final TRANS trans = first.convert(seed);
+ public R convert(T seed) {
+ final S trans = first.convert(seed);
return second.convert(trans);
}
}
