This is an automated email from the ASF dual-hosted git repository.

psteitz pushed a commit to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git


The following commit(s) were added to refs/heads/POOL_2_X by this push:
     new acc2b95a Javdoc / comments only.
acc2b95a is described below

commit acc2b95a4ea5e18adf9a7f174f852e02fabee2fb
Author: Phil Steitz <[email protected]>
AuthorDate: Tue Nov 4 13:13:56 2025 -0700

    Javdoc / comments only.
---
 .../org/apache/commons/pool2/impl/GenericObjectPool.java     | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java 
b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
index 952b919b..15d4d63c 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
@@ -93,24 +93,20 @@ public class GenericObjectPool<T> extends 
BaseGenericObjectPool<T>
     private final PooledObjectFactory<T> factory;
 
     /*
-     * TODO The references to _maxActive are from 1.x and need to be updated.
-     *
      * All of the objects currently associated with this pool in any state. It
      * excludes objects that have been destroyed. The size of
      * {@link #allObjects} will always be less than or equal to {@link
-     * #_maxActive}. Map keys are pooled objects, values are the PooledObject
+     * #getMaxTotal()}. Map keys are pooled objects, values are the 
PooledObject
      * wrappers used internally by the pool.
      */
     private final ConcurrentHashMap<IdentityWrapper<T>, PooledObject<T>> 
allObjects = new ConcurrentHashMap<>();
 
     /*
-     * TODO The references to _maxActive are from 1.x and need to be updated.
-     *
      * The combined count of the currently created objects and those in the
-     * process of being created. Under load, it may exceed {@link #_maxActive}
+     * process of being created. Under load, it may exceed {@link 
#getMaxTotal()}
      * if multiple threads try and create a new object at the same time but
      * {@link #create()} will ensure that there are never more than
-     * {@link #_maxActive} objects created at any one time.
+     * {@link #getMaxTotal()} objects created at any one time.
      */
     private final AtomicLong createCount = new AtomicLong();
 
@@ -761,8 +757,6 @@ public class GenericObjectPool<T> extends 
BaseGenericObjectPool<T>
                             }
                         }
                         underTest.endEvictionTest(idleObjects);
-                        // TODO - May need to add code here once additional
-                        // states are used
                     }
                 }
             }

Reply via email to