This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jxpath.git
commit dc1fdad3b78fb0091d04afe13e1f7fc35bb3845e Author: Gary Gregory <[email protected]> AuthorDate: Sun Nov 16 10:27:55 2025 -0500 Use try-with-resources --- .../org/apache/commons/jxpath/JXPathContextFactory.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/apache/commons/jxpath/JXPathContextFactory.java b/src/main/java/org/apache/commons/jxpath/JXPathContextFactory.java index 69db0f1b..00bd2612 100644 --- a/src/main/java/org/apache/commons/jxpath/JXPathContextFactory.java +++ b/src/main/java/org/apache/commons/jxpath/JXPathContextFactory.java @@ -107,13 +107,14 @@ public abstract class JXPathContextFactory { if (debug) { System.err.println("JXPath: found " + serviceId); } - final BufferedReader rd = new BufferedReader(new InputStreamReader(is, "UTF-8")); - final String factory = rd.readLine(); - if (factory != null && !"".equals(factory)) { - if (debug) { - System.err.println("JXPath: loaded from services: " + factory); + try (BufferedReader rd = new BufferedReader(new InputStreamReader(is, "UTF-8"))) { + final String factory = rd.readLine(); + if (factory != null && !"".equals(factory)) { + if (debug) { + System.err.println("JXPath: loaded from services: " + factory); + } + return factory; } - return factory; } } }
