This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
commit 60c72af72cee84d4c6e694d2f147aa2f325df647 Author: Mark Thomas <[email protected]> AuthorDate: Tue Dec 16 17:18:15 2025 +0000 Remove unnecessary modifiers --- src/main/java/org/apache/commons/dbcp2/LifetimeExceededException.java | 4 ++-- src/main/java/org/apache/commons/dbcp2/ObjectNameWrapper.java | 2 +- .../apache/commons/dbcp2/datasources/AbstractConnectionFactory.java | 3 ++- .../org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java | 2 +- .../apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java | 2 +- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/apache/commons/dbcp2/LifetimeExceededException.java b/src/main/java/org/apache/commons/dbcp2/LifetimeExceededException.java index 2ac2fa7a..4e019326 100644 --- a/src/main/java/org/apache/commons/dbcp2/LifetimeExceededException.java +++ b/src/main/java/org/apache/commons/dbcp2/LifetimeExceededException.java @@ -30,7 +30,7 @@ final class LifetimeExceededException extends SQLException { /** * Constructs a new instance. */ - public LifetimeExceededException() { + LifetimeExceededException() { } /** @@ -38,7 +38,7 @@ final class LifetimeExceededException extends SQLException { * * @param reason a description of the exception */ - public LifetimeExceededException(final String reason) { + LifetimeExceededException(final String reason) { super(reason); } } diff --git a/src/main/java/org/apache/commons/dbcp2/ObjectNameWrapper.java b/src/main/java/org/apache/commons/dbcp2/ObjectNameWrapper.java index 67a81658..6a7ff8f1 100644 --- a/src/main/java/org/apache/commons/dbcp2/ObjectNameWrapper.java +++ b/src/main/java/org/apache/commons/dbcp2/ObjectNameWrapper.java @@ -61,7 +61,7 @@ final class ObjectNameWrapper { private final ObjectName objectName; - public ObjectNameWrapper(final ObjectName objectName) { + ObjectNameWrapper(final ObjectName objectName) { this.objectName = objectName; } diff --git a/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java index 91ea7fcb..4aef3f46 100644 --- a/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java +++ b/src/main/java/org/apache/commons/dbcp2/datasources/AbstractConnectionFactory.java @@ -54,7 +54,8 @@ class AbstractConnectionFactory { protected final String validationQuery; protected final Duration validationQueryTimeoutDuration; - public AbstractConnectionFactory(final ConnectionPoolDataSource cpds, final String validationQuery, final Duration validationQueryTimeoutDuration, final boolean rollbackAfterValidation) { + AbstractConnectionFactory(final ConnectionPoolDataSource cpds, final String validationQuery, + final Duration validationQueryTimeoutDuration, final boolean rollbackAfterValidation) { this.cpds = cpds; this.validationQuery = validationQuery; this.validationQueryTimeoutDuration = validationQueryTimeoutDuration; diff --git a/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java index f5a68ec4..1ae9d99b 100644 --- a/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java +++ b/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java @@ -63,7 +63,7 @@ final class CPDSConnectionFactory extends AbstractConnectionFactory * The password to use to create connections * @since 2.10.0 */ - public CPDSConnectionFactory(final ConnectionPoolDataSource cpds, final String validationQuery, + CPDSConnectionFactory(final ConnectionPoolDataSource cpds, final String validationQuery, final Duration validationQueryTimeoutDuration, final boolean rollbackAfterValidation, final String userName, final char[] userPassword) { super(cpds, validationQuery, validationQueryTimeoutDuration, rollbackAfterValidation); diff --git a/src/main/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java b/src/main/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java index c0ae6501..40b76fe2 100644 --- a/src/main/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java +++ b/src/main/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java @@ -57,7 +57,7 @@ final class KeyedCPDSConnectionFactory extends AbstractConnectionFactory * whether a rollback should be issued after {@link #validateObject validating} {@link Connection}s. * @since 2.10.0 */ - public KeyedCPDSConnectionFactory(final ConnectionPoolDataSource cpds, final String validationQuery, final Duration validationQueryTimeoutDuration, + KeyedCPDSConnectionFactory(final ConnectionPoolDataSource cpds, final String validationQuery, final Duration validationQueryTimeoutDuration, final boolean rollbackAfterValidation) { super(cpds, validationQuery, validationQueryTimeoutDuration, rollbackAfterValidation); }
