(commons-beanutils) branch master updated: Static fields should be final or protected by synch.

[sebb]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git


The following commit(s) were added to refs/heads/master by this push:
     new 485bfa2f Static fields should be final or protected by synch.
485bfa2f is described below

commit 485bfa2ff45cfe772b2079e074971dd0290411cd
Author: Sebb <s...@apache.org>
AuthorDate: Sun Dec 28 23:20:40 2025 +0000

    Static fields should be final or protected by synch.
---
 src/changes/changes.xml                                       | 1 +
 src/main/java/org/apache/commons/beanutils2/LazyDynaBean.java | 5 +----
 src/main/java/org/apache/commons/beanutils2/MethodUtils.java  | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4378310c..def6c85e 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -33,6 +33,7 @@
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix typo in 
exception message throws from 
org.apache.commons.beanutils2.PropertyUtilsBean.setMappedProperty(Object, 
String, String, Object).</action>
       <action type="fix" dev="ggregory" due-to="Basil Crow, Piotr P. Karwasz, 
Gary Gregory">Simplify FluentPropertyBeanIntrospector#propertyName 
(#363).</action>
       <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix malformed 
Javadoc comments.</action>
+      <action type="fix" dev="sebb">Static fields should be final or protected 
by synch.</action>
       <!-- ADD -->
       <action type="add" dev="ggregory" due-to="Gary Gregory">Use varargs for 
org.apache.commons.beanutils2.MethodUtils.getAccessibleMethod(Class, String, 
Class...), and remove last argument variants using Class[] and Class.</action>
       <action type="add" dev="ggregory" due-to="SethFalco, Melloware, Gary 
Gregory">Add Instant converter and improve enum converter #49.</action>
diff --git a/src/main/java/org/apache/commons/beanutils2/LazyDynaBean.java 
b/src/main/java/org/apache/commons/beanutils2/LazyDynaBean.java
index 61f12bed..e350321b 100644
--- a/src/main/java/org/apache/commons/beanutils2/LazyDynaBean.java
+++ b/src/main/java/org/apache/commons/beanutils2/LazyDynaBean.java
@@ -129,7 +129,7 @@ public class LazyDynaBean implements DynaBean {
     /**
      * Commons Logging
      */
-    private static transient Log LOG = LogFactory.getLog(LazyDynaBean.class);
+    private static final transient Log LOG = 
LogFactory.getLog(LazyDynaBean.class);
 
     /** BigInteger Zero */
     protected static final BigInteger BigInteger_ZERO = new BigInteger("0");
@@ -673,9 +673,6 @@ public class LazyDynaBean implements DynaBean {
      * Returns the {@code Log}.
      */
     private Log logger() {
-        if (LOG == null) {
-            LOG = LogFactory.getLog(LazyDynaBean.class);
-        }
         return LOG;
     }
 
diff --git a/src/main/java/org/apache/commons/beanutils2/MethodUtils.java 
b/src/main/java/org/apache/commons/beanutils2/MethodUtils.java
index 2e1ab671..0d8f2b05 100644
--- a/src/main/java/org/apache/commons/beanutils2/MethodUtils.java
+++ b/src/main/java/org/apache/commons/beanutils2/MethodUtils.java
@@ -118,7 +118,7 @@ public final class MethodUtils {
      * would mean having a map keyed by context classloader which may 
introduce memory-leak problems.
      * </p>
      */
-    private static boolean CACHE_ENABLED = true;
+    private static boolean CACHE_ENABLED = true; //NOPMD @GuardedBy("this")
 
     /**
      * Stores a cache of MethodKey -> Method.