This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-jelly.git
commit d7deb1e7d992749fe5f317b00880e384d143218b Author: Gary Gregory <[email protected]> AuthorDate: Sun Jan 4 10:37:40 2026 -0500 Remove dead comments --- .../apache/commons/jelly/tags/sql/DateParamTag.java | 18 ------------------ .../apache/commons/jelly/tags/sql/DriverTag.java | 9 --------- .../org/apache/commons/jelly/tags/sql/ParamTag.java | 3 --- .../org/apache/commons/jelly/tags/sql/QueryTag.java | 9 --------- .../commons/jelly/tags/sql/SetDataSourceTag.java | 9 --------- .../commons/jelly/tags/sql/SqlTagSupport.java | 12 ------------ .../commons/jelly/tags/sql/TransactionTag.java | 21 --------------------- .../apache/commons/jelly/tags/sql/UpdateTag.java | 6 ------ 8 files changed, 87 deletions(-) diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DateParamTag.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DateParamTag.java index ac1aa6b8..1c1ea446 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DateParamTag.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DateParamTag.java @@ -32,28 +32,16 @@ import org.apache.commons.jelly.tags.Resources; public class DateParamTag extends TagSupport { - //********************************************************************* - // Private constants - private static final String TIMESTAMP_TYPE = "timestamp"; private static final String TIME_TYPE = "time"; private static final String DATE_TYPE = "date"; - //********************************************************************* - // Protected state - protected String type; protected java.util.Date value; - //********************************************************************* - // Constructor - public DateParamTag() { } - //********************************************************************* - // Properties - private void convertValue() throws JellyTagException { if (type == null || type.equalsIgnoreCase(TIMESTAMP_TYPE)) { @@ -92,16 +80,10 @@ public class DateParamTag extends TagSupport { parent.addSQLParameter(value); } - //********************************************************************* - // Tag logic - public void setType(final String type) { this.type = type; } - //********************************************************************* - // Private utility methods - public void setValue(final Date value) { this.value = value; } diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DriverTag.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DriverTag.java index 34e1f9da..38c3bdac 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DriverTag.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/DriverTag.java @@ -38,9 +38,6 @@ public class DriverTag extends TagSupport { private String userName; private String var; - //********************************************************************* - // Accessor methods - @Override public void doTag(final XMLOutput output) throws JellyTagException { final DataSourceWrapper ds = new DataSourceWrapper(); @@ -78,9 +75,6 @@ public class DriverTag extends TagSupport { return getInitParameter(PASSWORD); } - //********************************************************************* - // Tag logic - private String getUserName() { if (userName != null) { return userName; @@ -88,9 +82,6 @@ public class DriverTag extends TagSupport { return getInitParameter(USER_NAME); } - //********************************************************************* - // Private utility methods - public void setDriver(final String driverClassName) { this.driverClassName = driverClassName; } diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/ParamTag.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/ParamTag.java index e96ecd6f..75e27cc2 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/ParamTag.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/ParamTag.java @@ -56,9 +56,6 @@ public class ParamTag extends TagSupport { parent.addSQLParameter(paramValue); } - //********************************************************************* - // Tag logic - public void setValue(final Object value) { this.value = value; } diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/QueryTag.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/QueryTag.java index 18a3bd0f..7d84b37a 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/QueryTag.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/QueryTag.java @@ -54,15 +54,9 @@ public class QueryTag extends SqlTagSupport { */ private Connection conn; - //********************************************************************* - // Constructor and initialization - public QueryTag() { } - //********************************************************************* - // Accessor methods - /** * <p>Execute the SQL statement, set either through the {@code sql} * attribute or as the body, and save the result as a variable @@ -210,9 +204,6 @@ public class QueryTag extends SqlTagSupport { this.maxRowsSpecified = true; } - //********************************************************************* - // Tag logic - /** * The index of the first row returned can be * specified using startRow. diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SetDataSourceTag.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SetDataSourceTag.java index 1fa66846..00e9f381 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SetDataSourceTag.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SetDataSourceTag.java @@ -45,15 +45,9 @@ public class SetDataSourceTag extends TagSupport { private String scope = "page"; private String var; - //********************************************************************* - // Constructor and initialization - public SetDataSourceTag() { } - //********************************************************************* - // Accessor methods - @Override public void doTag(final XMLOutput output) throws JellyTagException { DataSource ds = null; @@ -122,9 +116,6 @@ public class SetDataSourceTag extends TagSupport { this.userName = userName; } - //********************************************************************* - // Tag logic - public void setVar(final String var) { this.var = var; } diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SqlTagSupport.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SqlTagSupport.java index f1ac54fc..b2ca16f4 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SqlTagSupport.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/SqlTagSupport.java @@ -55,16 +55,10 @@ public abstract class SqlTagSupport extends TagSupport implements SQLExecutionTa private List parameters; protected boolean isPartOfTransaction; - //********************************************************************* - // Constructor and initialization - public SqlTagSupport() { super.setEscapeText(false); } - //********************************************************************* - // Accessor methods - /** * Called by nested parameter elements to add PreparedStatement * parameter values. @@ -119,9 +113,6 @@ public abstract class SqlTagSupport extends TagSupport implements SQLExecutionTa return parameters != null && parameters.size() > 0; } - //********************************************************************* - // Public utility methods - /** * Sets the SQL DataSource. DataSource can be * a String or a DataSource object. @@ -131,9 +122,6 @@ public abstract class SqlTagSupport extends TagSupport implements SQLExecutionTa this.dataSourceSpecified = true; } - //********************************************************************* - // Protected utility methods - protected void setParameters(final PreparedStatement ps) throws SQLException { if (parameters != null) { diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/TransactionTag.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/TransactionTag.java index 57f129a3..4383b8d8 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/TransactionTag.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/TransactionTag.java @@ -33,30 +33,18 @@ import org.apache.commons.jelly.tags.Resources; public class TransactionTag extends TagSupport { - //********************************************************************* - // Private constants - private static final String TRANSACTION_READ_COMMITTED = "read_committed"; private static final String TRANSACTION_READ_UNCOMMITTED = "read_uncommitted"; private static final String TRANSACTION_REPEATABLE_READ = "repeatable_read"; private static final String TRANSACTION_SERIALIZABLE = "serializable"; - //********************************************************************* - // Protected state - protected Object rawDataSource; protected boolean dataSourceSpecified; - //********************************************************************* - // Private state - private Connection conn; private int isolation = Connection.TRANSACTION_NONE; private int origIsolation; - //********************************************************************* - // Constructor and initialization - public TransactionTag() { } @@ -81,9 +69,6 @@ public class TransactionTag extends TagSupport { conn = null; } - //********************************************************************* - // Tag logic - /** * Prepares for execution by setting the initial state, such as * getting the {@code Connection} and preparing it for @@ -146,9 +131,6 @@ public class TransactionTag extends TagSupport { } } - //********************************************************************* - // Public utility methods - /** * Called by nested parameter elements to get a reference to * the Connection. @@ -166,9 +148,6 @@ public class TransactionTag extends TagSupport { this.dataSourceSpecified = true; } - //********************************************************************* - // Implementation methods methods - /** * Sets the transaction isolation level. */ diff --git a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/UpdateTag.java b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/UpdateTag.java index 2e66ee61..3a362292 100644 --- a/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/UpdateTag.java +++ b/jelly-tags/sql/src/main/java/org/apache/commons/jelly/tags/sql/UpdateTag.java @@ -42,15 +42,9 @@ public class UpdateTag extends SqlTagSupport { */ private Connection conn; - //********************************************************************* - // Constructor and initialization - public UpdateTag() { } - //********************************************************************* - // Tag logic - /** * <p>Execute the SQL statement, set either through the {@code sql} * attribute or as the body, and save the result as a variable
