This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-email.git
commit 94b4e3a291d7ea84bb1cd2c12402ae30c9323fd8 Author: Gary Gregory <[email protected]> AuthorDate: Sun Jan 4 12:43:30 2026 -0500 Javadoc Add an empty line before a Javadoc comment --- .../src/main/java/org/apache/commons/mail2/core/EmailException.java | 1 + .../commons/mail2/jakarta/resolver/DataSourceClassPathResolver.java | 1 + .../test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java | 1 + .../src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java | 1 + .../org/apache/commons/mail2/jakarta/InvalidInternetAddressTest.java | 1 + .../apache/commons/mail2/javax/resolver/DataSourceClassPathResolver.java | 1 + .../src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java | 1 + .../src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java | 1 + .../java/org/apache/commons/mail2/javax/InvalidInternetAddressTest.java | 1 + .../java/org/apache/commons/mail2/javax/SendWithAttachmentsTest.java | 1 + 10 files changed, 10 insertions(+) diff --git a/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailException.java b/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailException.java index 879d2cca..17cb29b1 100644 --- a/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailException.java +++ b/commons-email2-core/src/main/java/org/apache/commons/mail2/core/EmailException.java @@ -31,6 +31,7 @@ import java.util.function.Supplier; * @since 1.0 */ public class EmailException extends Exception { + /** Serializable version identifier. */ private static final long serialVersionUID = 5550674499282474616L; diff --git a/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/resolver/DataSourceClassPathResolver.java b/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/resolver/DataSourceClassPathResolver.java index 51661899..85656537 100644 --- a/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/resolver/DataSourceClassPathResolver.java +++ b/commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/resolver/DataSourceClassPathResolver.java @@ -30,6 +30,7 @@ import jakarta.mail.util.ByteArrayDataSource; * @since 1.3 */ public class DataSourceClassPathResolver extends DataSourceBaseResolver { + /** The base string of the resource relative to the classpath when resolving relative paths */ private final String classPathBase; diff --git a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java index 5eb72dc9..90c2f7d0 100644 --- a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java +++ b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/AbstractEmailTest.java @@ -49,6 +49,7 @@ import jakarta.mail.internet.MimeMessage; * Base test case for Email test classes. */ public abstract class AbstractEmailTest { + /** Padding at end of body added by wiser/send */ public static final int BODY_END_PAD = 3; diff --git a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java index 759de991..2d2ad785 100644 --- a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java +++ b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailLiveTest.java @@ -47,6 +47,7 @@ import jakarta.mail.internet.MimeMessage; * https://martinfowler.com/articles/mocksArentStubs.html#ClassicalAndMockistTesting). */ class EmailLiveTest extends AbstractEmailTest { + /** * Factory method to create a pre-configured email instance. * diff --git a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/InvalidInternetAddressTest.java b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/InvalidInternetAddressTest.java index 75158c14..d2202e3b 100644 --- a/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/InvalidInternetAddressTest.java +++ b/commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/InvalidInternetAddressTest.java @@ -31,6 +31,7 @@ import jakarta.mail.internet.InternetAddress; * JUnit test case demonstrating InternetAddress validation. */ class InvalidInternetAddressTest extends AbstractEmailTest { + /** */ private static final String VALID_QUOTED_EMAIL = "\"John O'Groats\"@domain.com"; diff --git a/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/resolver/DataSourceClassPathResolver.java b/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/resolver/DataSourceClassPathResolver.java index 2c4874bc..91a290e9 100644 --- a/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/resolver/DataSourceClassPathResolver.java +++ b/commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/resolver/DataSourceClassPathResolver.java @@ -30,6 +30,7 @@ import javax.mail.util.ByteArrayDataSource; * @since 1.3 */ public class DataSourceClassPathResolver extends DataSourceBaseResolver { + /** The base string of the resource relative to the classpath when resolving relative paths */ private final String classPathBase; diff --git a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java index d3ba59f1..5b1a43fa 100644 --- a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java +++ b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/AbstractEmailTest.java @@ -49,6 +49,7 @@ import org.subethamail.wiser.WiserMessage; * Base test case for Email test classes. */ public abstract class AbstractEmailTest { + /** Padding at end of body added by wiser/send */ public static final int BODY_END_PAD = 3; diff --git a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java index 09783788..917f04b2 100644 --- a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java +++ b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/EmailLiveTest.java @@ -47,6 +47,7 @@ import org.junit.jupiter.api.Test; * https://martinfowler.com/articles/mocksArentStubs.html#ClassicalAndMockistTesting). */ class EmailLiveTest extends AbstractEmailTest { + /** * Factory method to create a pre-configured email instance. * diff --git a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/InvalidInternetAddressTest.java b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/InvalidInternetAddressTest.java index aa19efdb..44a58434 100644 --- a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/InvalidInternetAddressTest.java +++ b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/InvalidInternetAddressTest.java @@ -31,6 +31,7 @@ import org.junit.jupiter.api.Test; * JUnit test case demonstrating InternetAddress validation. */ class InvalidInternetAddressTest extends AbstractEmailTest { + /** */ private static final String VALID_QUOTED_EMAIL = "\"John O'Groats\"@domain.com"; diff --git a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/SendWithAttachmentsTest.java b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/SendWithAttachmentsTest.java index 940e0494..4878f195 100644 --- a/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/SendWithAttachmentsTest.java +++ b/commons-email2-javax/src/test/java/org/apache/commons/mail2/javax/SendWithAttachmentsTest.java @@ -104,6 +104,7 @@ class SendWithAttachmentsTest extends AbstractEmailTest { email.addTo(strTestMailTo); /** File to be used to test file attachments (Must be valid) */ + /** Use umlaut characters to test if the file name is properly encoded */ // use short name to avoid folding. Otherwise need to unfold when checking result. attachment.setName("a>ä, o>ö, u>ü, au>äu");
