This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit b08f067e1ea9547da5447721f01914e56b099ed9 Author: Gary Gregory <[email protected]> AuthorDate: Sun Jan 4 15:21:22 2026 -0500 Javadoc Add an empty line before a Javadoc comment --- src/main/java/org/apache/commons/pool3/PoolUtils.java | 4 ++++ .../java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java | 2 ++ .../org/apache/commons/pool3/impl/ResilientPooledObjectFactory.java | 1 + .../org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java | 6 ++++++ .../apache/commons/pool3/impl/TestResilientPooledObjectFactory.java | 1 + 5 files changed, 14 insertions(+) diff --git a/src/main/java/org/apache/commons/pool3/PoolUtils.java b/src/main/java/org/apache/commons/pool3/PoolUtils.java index 4222f902..b788ee61 100644 --- a/src/main/java/org/apache/commons/pool3/PoolUtils.java +++ b/src/main/java/org/apache/commons/pool3/PoolUtils.java @@ -113,6 +113,7 @@ public final class PoolUtils { } } } + /** * Decorates a keyed object pool, adding "eroding" behavior. Based on the * configured erosion factor, objects returning to the pool @@ -471,6 +472,7 @@ public final class PoolUtils { pool + '}'; } } + /** * Extends ErodingKeyedObjectPool to allow erosion to take place on a * per-key basis. Timing of erosion events is tracked separately for @@ -522,6 +524,7 @@ public final class PoolUtils { ", keyedPool=" + getKeyedPool() + '}'; } } + /** * Timer task that adds objects to the pool until the number of idle * instances for the given key reaches the configured minIdle. Note that @@ -602,6 +605,7 @@ public final class PoolUtils { return sb.toString(); } } + /** * Timer task that adds objects to the pool until the number of idle * instances reaches the configured minIdle. Note that this is not the same diff --git a/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java b/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java index 8a586de9..e71a8440 100644 --- a/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java +++ b/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java @@ -98,6 +98,7 @@ final class LinkedBlockingDeque<E> extends AbstractQueue<E> * Base class for Iterators for LinkedBlockingDeque */ private abstract class AbstractItr implements Iterator<E> { + /** * The next node to return in next() */ @@ -252,6 +253,7 @@ final class LinkedBlockingDeque<E> extends AbstractQueue<E> * @param <E> node item type */ private static final class Node<E> { + /** * The item, or null if this node has been removed. */ diff --git a/src/main/java/org/apache/commons/pool3/impl/ResilientPooledObjectFactory.java b/src/main/java/org/apache/commons/pool3/impl/ResilientPooledObjectFactory.java index 4d36c6e4..b8fabc18 100644 --- a/src/main/java/org/apache/commons/pool3/impl/ResilientPooledObjectFactory.java +++ b/src/main/java/org/apache/commons/pool3/impl/ResilientPooledObjectFactory.java @@ -260,6 +260,7 @@ public class ResilientPooledObjectFactory<T, E extends Exception> implements Poo /** * @return the factory wrapped by this resilient factory */ + /** Whether or not the monitor thread is running */ private boolean monitoring; diff --git a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java index 980fcc7c..16c31937 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestGenericKeyedObjectPool.java @@ -361,16 +361,22 @@ class TestGenericKeyedObjectPool extends AbstractTestKeyedObjectPool { /** GKOP to hit */ private final KeyedObjectPool<String, T, E> pool; + /** Number of borrow/return iterations */ private final int iter; + /** Delay before borrow */ private final int startDelay; + /** Delay before return */ private final int holdTime; + /** Whether or not delays are random (with max = configured values) */ private final boolean randomDelay; + /** Expected object */ private final T expectedObject; + /** Key used in borrow / return sequence - null means random */ private final String key; diff --git a/src/test/java/org/apache/commons/pool3/impl/TestResilientPooledObjectFactory.java b/src/test/java/org/apache/commons/pool3/impl/TestResilientPooledObjectFactory.java index 8d1ac26e..49ffa115 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestResilientPooledObjectFactory.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestResilientPooledObjectFactory.java @@ -28,6 +28,7 @@ import org.apache.commons.pool3.PooledObjectFactory; import org.junit.jupiter.api.Test; class TestResilientPooledObjectFactory { + /** * Factory that suffers outages and fails in configurable ways when it is down. */
