This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit f4fdc2355b7324060a3c7c2ccf1fe66a37055f73 Author: Gary Gregory <[email protected]> AuthorDate: Tue Jan 20 22:02:31 2026 +0000 Reduce vertical whitespace --- .../pool3/impl/TestDefaultPooledObjectInfo.java | 38 +++------------------- 1 file changed, 4 insertions(+), 34 deletions(-) diff --git a/src/test/java/org/apache/commons/pool3/impl/TestDefaultPooledObjectInfo.java b/src/test/java/org/apache/commons/pool3/impl/TestDefaultPooledObjectInfo.java index 69df7c3d..0e793465 100644 --- a/src/test/java/org/apache/commons/pool3/impl/TestDefaultPooledObjectInfo.java +++ b/src/test/java/org/apache/commons/pool3/impl/TestDefaultPooledObjectInfo.java @@ -14,6 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.apache.commons.pool3.impl; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -31,20 +32,15 @@ class TestDefaultPooledObjectInfo { @Test void testGetLastBorrowTrace() throws Exception { final AbandonedConfig abandonedConfig = new AbandonedConfig(); - abandonedConfig.setRemoveAbandonedOnBorrow(true); abandonedConfig.setRemoveAbandonedTimeout(TestConstants.ONE_SECOND_DURATION); abandonedConfig.setLogAbandoned(true); - try (GenericObjectPool<String, TestException> pool = new GenericObjectPool<>(new SimpleFactory(), - new GenericObjectPoolConfig<>(), abandonedConfig)) { - + try (GenericObjectPool<String, TestException> pool = new GenericObjectPool<>(new SimpleFactory(), new GenericObjectPoolConfig<>(), abandonedConfig)) { pool.borrowObject(); // pool.returnObject(s1); // Object not returned, causes abandoned object created exception - final Set<DefaultPooledObjectInfo> strings = pool.listAllObjects(); final DefaultPooledObjectInfo s1Info = strings.iterator().next(); final String lastBorrowTrace = s1Info.getLastBorrowTrace(); - assertTrue(lastBorrowTrace.startsWith("Pooled object created")); } } @@ -52,15 +48,10 @@ class TestDefaultPooledObjectInfo { @Test void testGetPooledObjectToString() throws Exception { try (GenericObjectPool<String, TestException> pool = new GenericObjectPool<>(new SimpleFactory())) { - final String s1 = pool.borrowObject(); - final Set<DefaultPooledObjectInfo> strings = pool.listAllObjects(); - assertEquals(1, strings.size()); - final DefaultPooledObjectInfo s1Info = strings.iterator().next(); - assertEquals(s1, s1Info.getPooledObjectToString()); } } @@ -68,15 +59,10 @@ class TestDefaultPooledObjectInfo { @Test void testGetPooledObjectType() throws Exception { try (GenericObjectPool<String, TestException> pool = new GenericObjectPool<>(new SimpleFactory())) { - pool.borrowObject(); - final Set<DefaultPooledObjectInfo> strings = pool.listAllObjects(); - assertEquals(1, strings.size()); - final DefaultPooledObjectInfo s1Info = strings.iterator().next(); - assertEquals(String.class.getName(), s1Info.getPooledObjectType()); } } @@ -84,47 +70,31 @@ class TestDefaultPooledObjectInfo { @Test void testTiming() throws Exception { try (GenericObjectPool<String, TestException> pool = new GenericObjectPool<>(new SimpleFactory())) { - final long t1Millis = System.currentTimeMillis(); - Thread.sleep(50); final String s1 = pool.borrowObject(); Thread.sleep(50); - final long t2Millis = System.currentTimeMillis(); - Thread.sleep(50); pool.returnObject(s1); Thread.sleep(50); - final long t3Millis = System.currentTimeMillis(); - Thread.sleep(50); pool.borrowObject(); Thread.sleep(50); - final long t4Millis = System.currentTimeMillis(); - final Set<DefaultPooledObjectInfo> strings = pool.listAllObjects(); - assertEquals(1, strings.size()); - final DefaultPooledObjectInfo s1Info = strings.iterator().next(); - final SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss Z"); - assertTrue(s1Info.getCreateTime() > t1Millis); assertEquals(sdf.format(Long.valueOf(s1Info.getCreateTime())), s1Info.getCreateTimeFormatted()); assertTrue(s1Info.getCreateTime() < t2Millis); - assertTrue(s1Info.getLastReturnTime() > t2Millis); - assertEquals(sdf.format(Long.valueOf(s1Info.getLastReturnTime())), - s1Info.getLastReturnTimeFormatted()); + assertEquals(sdf.format(Long.valueOf(s1Info.getLastReturnTime())), s1Info.getLastReturnTimeFormatted()); assertTrue(s1Info.getLastReturnTime() < t3Millis); - assertTrue(s1Info.getLastBorrowTime() > t3Millis); - assertEquals(sdf.format(Long.valueOf(s1Info.getLastBorrowTime())), - s1Info.getLastBorrowTimeFormatted()); + assertEquals(sdf.format(Long.valueOf(s1Info.getLastBorrowTime())), s1Info.getLastBorrowTimeFormatted()); assertTrue(s1Info.getLastBorrowTime() < t4Millis); } }
